)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fcfbbe13caf5fa6232c81c527f817172faf8ddd3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the get console API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the conole get api from v1/nodes/\u003cuuid\u003e/states/console"},{"line_number":10,"context_line":"to v1/nodes/\u003cuuid\u003e/console. It also changed the return value"},{"line_number":11,"context_line":"from string to the following JSON object:"},{"line_number":12,"context_line":"{\u0027console_enabled\u0027: True, \u0027console_info\u0027: {\u0027type\u0027: \u0027shellinaboxd\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXH%2F%2F9LY%3D","line":9,"updated":"2014-04-16 09:27:49.000000000","message":"typo","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"8232293de4ff071b063b3324b8be9018b2ba7528","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the get console API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed the conole get api from v1/nodes/\u003cuuid\u003e/states/console"},{"line_number":10,"context_line":"to v1/nodes/\u003cuuid\u003e/console. It also changed the return value"},{"line_number":11,"context_line":"from string to the following JSON object:"},{"line_number":12,"context_line":"{\u0027console_enabled\u0027: True, \u0027console_info\u0027: {\u0027type\u0027: \u0027shellinaboxd\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXH%2F%2F6ZM%3D","line":9,"in_reply_to":"AAAAXH%2F%2F9LY%3D","updated":"2014-04-16 20:19:23.000000000","message":"Oops, thanks. Done","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"75351d83f8c170ddff7104b84bdf17217984a32d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ConsoleInfo(base.APIBase):"},{"line_number":59,"context_line":"    \"\"\"API representation of the states of a node.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    console_enabled \u003d types.boolean"},{"line_number":62,"context_line":"    \"The console state: if the console is enabled or not.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F8hc%3D","line":59,"updated":"2014-04-16 10:38:47.000000000","message":"It\u0027s representing the state of the console specifically\n\n\"\"\"API representation of the console state.\"\"\" ? or something similar","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"8232293de4ff071b063b3324b8be9018b2ba7528","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ConsoleInfo(base.APIBase):"},{"line_number":59,"context_line":"    \"\"\"API representation of the states of a node.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    console_enabled \u003d types.boolean"},{"line_number":62,"context_line":"    \"The console state: if the console is enabled or not.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F6KM%3D","line":59,"in_reply_to":"AAAAXH%2F%2F8hc%3D","updated":"2014-04-16 20:19:23.000000000","message":"Done.\nIt should be the API presentation of the console information. :)","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fcfbbe13caf5fa6232c81c527f817172faf8ddd3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    console_enabled \u003d types.boolean"},{"line_number":62,"context_line":"    \"The console state: if the console is enabled or not.\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    console_info \u003d {wtypes.text: types.MultiType(wtypes.text,"},{"line_number":65,"context_line":"                                                 six.integer_types)}"},{"line_number":66,"context_line":"    \"The console information. It includes the url to access the console\""},{"line_number":67,"context_line":"    \"and the type of the application that hosts the console.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F9M0%3D","line":64,"updated":"2014-04-16 09:27:49.000000000","message":"IMO should be console_info \u003d {wtypes.text: wtypes.text}","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"8232293de4ff071b063b3324b8be9018b2ba7528","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    console_enabled \u003d types.boolean"},{"line_number":62,"context_line":"    \"The console state: if the console is enabled or not.\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    console_info \u003d {wtypes.text: types.MultiType(wtypes.text,"},{"line_number":65,"context_line":"                                                 six.integer_types)}"},{"line_number":66,"context_line":"    \"The console information. It includes the url to access the console\""},{"line_number":67,"context_line":"    \"and the type of the application that hosts the console.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F6To%3D","line":64,"in_reply_to":"AAAAXH%2F%2F8gk%3D","updated":"2014-04-16 20:19:23.000000000","message":"Then I\u0027ll keep as it now :).  It really depends what information the drives returns. The get_console_information in the driver returns a dict.","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"75351d83f8c170ddff7104b84bdf17217984a32d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    console_enabled \u003d types.boolean"},{"line_number":62,"context_line":"    \"The console state: if the console is enabled or not.\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    console_info \u003d {wtypes.text: types.MultiType(wtypes.text,"},{"line_number":65,"context_line":"                                                 six.integer_types)}"},{"line_number":66,"context_line":"    \"The console information. It includes the url to access the console\""},{"line_number":67,"context_line":"    \"and the type of the application that hosts the console.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F8gk%3D","line":64,"in_reply_to":"AAAAXH%2F%2F9M0%3D","updated":"2014-04-16 10:38:47.000000000","message":"I\u0027m fine with the interger_types... if one want\u0027s to have port as a separated field for example.","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e9da647d843166b4ae1c27fc6e2ee37eda9d26f6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return ConsoleInfo(console_enabled\u003dconsole_state, console_info\u003dconsole)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, types.boolean, status_code\u003d202)"},{"line_number":97,"context_line":"    def put(self, node_uuid, target):"},{"line_number":98,"context_line":"        \"\"\"Start and stop the node console."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param node_uuid: UUID of a node."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fn4g%3D","line":97,"updated":"2014-04-18 18:28:48.000000000","message":"I see no reason to change the parameter name from \"enabled\" to \"target\" in this patch.\n\nIt is an unnecessary and backwards-incompatible API change -- not that we\u0027re committed to API compat for the console API yet, but this just doesn\u0027t seem necessary.","commit_id":"903d8940921c6f4fef1521de875b4d3eab4f3a5b"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"653d92b14c47222dcb8ad19bd1caf857539119a6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return ConsoleInfo(console_enabled\u003dconsole_state, console_info\u003dconsole)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, types.boolean, status_code\u003d202)"},{"line_number":97,"context_line":"    def put(self, node_uuid, target):"},{"line_number":98,"context_line":"        \"\"\"Start and stop the node console."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param node_uuid: UUID of a node."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FngU%3D","line":97,"in_reply_to":"AAAAXH%2F%2Fn4g%3D","updated":"2014-04-18 19:50:59.000000000","message":"Done","commit_id":"903d8940921c6f4fef1521de875b4d3eab4f3a5b"}],"ironic/conductor/manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"75351d83f8c170ddff7104b84bdf17217984a32d","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                op \u003d _(\u0027enabled\u0027) if enabled else _(\u0027disabled\u0027)"},{"line_number":831,"context_line":"                LOG.info(_(\"No console action was triggered because the \""},{"line_number":832,"context_line":"                           \"console is already %s\") % op)"},{"line_number":833,"context_line":"                task.release_resources()"},{"line_number":834,"context_line":"            else:"},{"line_number":835,"context_line":"                node.last_error \u003d None"},{"line_number":836,"context_line":"                node.save(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F8gM%3D","line":833,"updated":"2014-04-16 10:38:47.000000000","message":"good catch :)","commit_id":"836726c9af8515ab87ca664b1b10d530120ba036"}]}