)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2c77cff61408bd4eaf7314a7e2ae2e9cf957a3c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db106b66_8eaf2789","updated":"2023-04-24 04:06:53.000000000","message":"Thanks for the review, will take a look on comments.","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5c3ba428ddc14aa7fed555ab51456e31db6e2af6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"15cb4036_6b8550c3","updated":"2023-06-19 15:59:32.000000000","message":"recheck","commit_id":"ae7760af0fc39f3cf0edf5e6852fcd5c6ef5f830"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"33e56433c156ee5861a8c14e7e3f27dcb92a3dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"470efa98_a6a29d05","updated":"2023-08-29 08:34:53.000000000","message":"recheck","commit_id":"ae7760af0fc39f3cf0edf5e6852fcd5c6ef5f830"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"52148bda119267bda6a6224be3e1b0d6890cd1a7","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        # Remove symbolic link when deploy is done."},{"line_number":619,"context_line":"        deploy_utils.remove_http_instance_symlink(task.node.uuid)"},{"line_number":620,"context_line":"        if CONF.agent.image_download_source \u003d\u003d \u0027http\u0027:"},{"line_number":621,"context_line":"            deploy_utils.destroy_images(task.node.uuid)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8aa28a71_621134f8","line":620,"updated":"2023-04-12 10:34:26.000000000","message":"Is there any reason not to do it in any case? We don\u0027t need images at this point.","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ed3fcfdf6a9a510b191ca74c20583f354022de5b","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        # Remove symbolic link when deploy is done."},{"line_number":619,"context_line":"        deploy_utils.remove_http_instance_symlink(task.node.uuid)"},{"line_number":620,"context_line":"        if CONF.agent.image_download_source \u003d\u003d \u0027http\u0027:"},{"line_number":621,"context_line":"            deploy_utils.destroy_images(task.node.uuid)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"922b47c8_67050ec0","line":620,"in_reply_to":"8aa28a71_621134f8","updated":"2023-04-30 07:17:43.000000000","message":"Not sure how local files are handled, it appears we also cache for this type, so replaced with a helper which cleans symlink and image.","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"52148bda119267bda6a6224be3e1b0d6890cd1a7","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        # Remove symbolic link when deploy is done."},{"line_number":619,"context_line":"        deploy_utils.remove_http_instance_symlink(task.node.uuid)"},{"line_number":620,"context_line":"        if CONF.agent.image_download_source \u003d\u003d \u0027http\u0027:"},{"line_number":621,"context_line":"            deploy_utils.destroy_images(task.node.uuid)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"class AgentRAID(base.RAIDInterface):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c641d894_400896bc","line":621,"updated":"2023-04-12 10:34:26.000000000","message":"Shouldn\u0027t it be a part of clean_up (and the previous line potentially too)?","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"52148bda119267bda6a6224be3e1b0d6890cd1a7","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":1389,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":1390,"context_line":"        self.node.save()"},{"line_number":1391,"context_line":"        with task_manager. acquire(self.context, self.node.uuid,"},{"line_number":1392,"context_line":"                                   shared\u003dFalse) as task:"},{"line_number":1393,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d True"},{"line_number":1394,"context_line":"            task.driver.deploy.prepare_instance_boot(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"16944b13_bffaad13","line":1391,"updated":"2023-04-12 10:34:26.000000000","message":"nit: redundant space added?","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ed3fcfdf6a9a510b191ca74c20583f354022de5b","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":1389,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":1390,"context_line":"        self.node.save()"},{"line_number":1391,"context_line":"        with task_manager. acquire(self.context, self.node.uuid,"},{"line_number":1392,"context_line":"                                   shared\u003dFalse) as task:"},{"line_number":1393,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d True"},{"line_number":1394,"context_line":"            task.driver.deploy.prepare_instance_boot(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec517815_19a0c1a5","line":1391,"in_reply_to":"16944b13_bffaad13","updated":"2023-04-30 07:17:43.000000000","message":"Done","commit_id":"170793c7f9f72c4fa831b5b7888c2f884f76704f"}]}