)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e5df73362b55c9c82c2b8a92e0c6684cb10df7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0ad63b58_d921350a","updated":"2023-07-28 00:47:27.000000000","message":"recheck ironic-tempest-bios-ipmi-direct-tinyipa timed out","commit_id":"8fc8372e748cc46b4afd11e3529ef621728fd35a"}],"ironic/conductor/steps.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c621fadda624fa7bb69ad1b9662c7e334df043fd","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        if \u0027seconds\u0027 in step_args:"},{"line_number":845,"context_line":"            # If we have a seconds argument, just pause."},{"line_number":846,"context_line":"            rec_seconds \u003d int(step_args[\u0027seconds\u0027])"},{"line_number":847,"context_line":"            if rec_seconds \u003e CONF.conductor.max_conductor_wait_step_seconds:"},{"line_number":848,"context_line":"                warning \u003d ("},{"line_number":849,"context_line":"                    _(\u0027A wait time exceeding the configured maximum \u0027"},{"line_number":850,"context_line":"                      \u0027has been requested. Holding for %s, got %s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":5,"id":"46c31c48_56b23837","line":847,"updated":"2023-06-06 21:07:00.000000000","message":"Wonder if we should enforce this config as being less than the total deploy/clean timeout","commit_id":"e178666a156d4691423ecea4fb1b66bc93b8970a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3c6358868383de9fa741021690443f898f356824","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        if \u0027seconds\u0027 in step_args:"},{"line_number":845,"context_line":"            # If we have a seconds argument, just pause."},{"line_number":846,"context_line":"            rec_seconds \u003d int(step_args[\u0027seconds\u0027])"},{"line_number":847,"context_line":"            if rec_seconds \u003e CONF.conductor.max_conductor_wait_step_seconds:"},{"line_number":848,"context_line":"                warning \u003d ("},{"line_number":849,"context_line":"                    _(\u0027A wait time exceeding the configured maximum \u0027"},{"line_number":850,"context_line":"                      \u0027has been requested. Holding for %s, got %s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b46bd67_9be04616","line":847,"in_reply_to":"3acbc3b8_db675148","updated":"2023-07-10 17:18:24.000000000","message":"So I thought about it more. And I think the risk here is two fold. One someone sets the default to be some giant number, which then collides with timeouts and then there is a race. Obviously we should prevent that with default maximum config which I\u0027ve done in the next revision.\n\nThe other issue is someone setting the timeouts so low, that they also collide with those timeouts in general. A startup warning makes the most sense for that, and I\u0027ve added that as well.","commit_id":"e178666a156d4691423ecea4fb1b66bc93b8970a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d231a0851b5d963e9d7194bb4db5a49b7cd81433","unresolved":true,"context_lines":[{"line_number":844,"context_line":"        if \u0027seconds\u0027 in step_args:"},{"line_number":845,"context_line":"            # If we have a seconds argument, just pause."},{"line_number":846,"context_line":"            rec_seconds \u003d int(step_args[\u0027seconds\u0027])"},{"line_number":847,"context_line":"            if rec_seconds \u003e CONF.conductor.max_conductor_wait_step_seconds:"},{"line_number":848,"context_line":"                warning \u003d ("},{"line_number":849,"context_line":"                    _(\u0027A wait time exceeding the configured maximum \u0027"},{"line_number":850,"context_line":"                      \u0027has been requested. Holding for %s, got %s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acbc3b8_db675148","line":847,"in_reply_to":"46c31c48_56b23837","updated":"2023-07-07 18:37:30.000000000","message":"we can likely do that in the config.","commit_id":"e178666a156d4691423ecea4fb1b66bc93b8970a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"febc73774e9aee446de79a54a92b0395e3add789","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        if \u0027seconds\u0027 in step_args:"},{"line_number":845,"context_line":"            # If we have a seconds argument, just pause."},{"line_number":846,"context_line":"            rec_seconds \u003d int(step_args[\u0027seconds\u0027])"},{"line_number":847,"context_line":"            if rec_seconds \u003e CONF.conductor.max_conductor_wait_step_seconds:"},{"line_number":848,"context_line":"                warning \u003d ("},{"line_number":849,"context_line":"                    _(\u0027A wait time exceeding the configured maximum \u0027"},{"line_number":850,"context_line":"                      \u0027has been requested. Holding for %s, got %s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":5,"id":"d5c8763c_7d457cdb","line":847,"in_reply_to":"7b46bd67_9be04616","updated":"2023-07-24 22:43:16.000000000","message":"check added as part of conductor startup.","commit_id":"e178666a156d4691423ecea4fb1b66bc93b8970a"}]}