)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15c05df78069c0a42ed49ec36dc4d9686d8d0262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74b31f10_f318f0a6","updated":"2023-05-09 22:40:29.000000000","message":"Code LGTM; -1 only for documentation issues.","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"379dd1f30bf19aac3cc4f0a5792c3854fc77c5f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"101eea02_b06ee500","updated":"2023-05-11 14:19:07.000000000","message":"lgtm I will +2 after we update the things Jay mentioned","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e9f6ff5001a78007dfc666cc88e2356ca4defbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9eec95f7_6a1b1397","updated":"2023-05-20 22:41:01.000000000","message":"recheck db upgrade froze in grenade after db stats were collected","commit_id":"3cb47acdd822a01dab277579a5ef2fb3b9a103cf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2e54a0b96f086b0833d50fa00fedd07b3a086302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0c015265_9be83b00","updated":"2023-05-22 15:21:04.000000000","message":"recheck grenade failure issues, need to get a held node","commit_id":"3cb47acdd822a01dab277579a5ef2fb3b9a103cf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f3f4e301f5461ce57c013c492620b3026fffc401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ea9dd3ef_3b0ac010","updated":"2023-05-24 02:04:40.000000000","message":"+2, the grenade job will probably be green now, changes from patch#6 to latest reviewed previously.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f5bc9aafcc9d9214f64595adb17a092fe5cbcf04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a23bb95b_7b31cb43","updated":"2023-05-24 21:29:12.000000000","message":"+W since the nits can be in a follow-up, thanks Julia","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b274247d2e252ace8f6c5f4f48560fdb563f1375","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6ac81125_c4476b57","updated":"2023-05-24 20:23:06.000000000","message":"Please ensure the api-ref is updated in a follow-up.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ca4c8296771809bc354605fd665fa156e6d16ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"344a9d03_7406b670","updated":"2023-05-24 01:52:41.000000000","message":"recheck cirros version fix merged","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b274247d2e252ace8f6c5f4f48560fdb563f1375","unresolved":true,"context_lines":[{"line_number":209,"context_line":"  type: array"},{"line_number":210,"context_line":"include_children:"},{"line_number":211,"context_line":"  description: |"},{"line_number":212,"context_line":"    Wheter to show child nodes in the node list, which are normally hidden."},{"line_number":213,"context_line":"  in: query"},{"line_number":214,"context_line":"  required: false"},{"line_number":215,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4801e543_426ec2a2","line":212,"updated":"2023-05-24 20:23:06.000000000","message":"s/Wheter/Whether/","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a5daa538a7136a564469b9b714720cb63f7dce","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  type: array"},{"line_number":210,"context_line":"include_children:"},{"line_number":211,"context_line":"  description: |"},{"line_number":212,"context_line":"    Wheter to show child nodes in the node list, which are normally hidden."},{"line_number":213,"context_line":"  in: query"},{"line_number":214,"context_line":"  required: false"},{"line_number":215,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f48582a_71289a7a","line":212,"in_reply_to":"4801e543_426ec2a2","updated":"2023-05-25 13:49:15.000000000","message":"Done","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b274247d2e252ace8f6c5f4f48560fdb563f1375","unresolved":true,"context_lines":[{"line_number":1330,"context_line":"parent_node:"},{"line_number":1331,"context_line":"  description: |"},{"line_number":1332,"context_line":"    A UUID representing a node which is a parent_node to the present"},{"line_number":1333,"context_line":"    node. If populated, the node will disappear from the normal node"},{"line_number":1334,"context_line":"    list, as it is *not* intended for *normal* usage directly."},{"line_number":1335,"context_line":"  in: body"},{"line_number":1336,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5b7bc05d_c1c56c72","line":1333,"updated":"2023-05-24 20:23:06.000000000","message":"I\u0027m confused by this description.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a5daa538a7136a564469b9b714720cb63f7dce","unresolved":true,"context_lines":[{"line_number":1330,"context_line":"parent_node:"},{"line_number":1331,"context_line":"  description: |"},{"line_number":1332,"context_line":"    A UUID representing a node which is a parent_node to the present"},{"line_number":1333,"context_line":"    node. If populated, the node will disappear from the normal node"},{"line_number":1334,"context_line":"    list, as it is *not* intended for *normal* usage directly."},{"line_number":1335,"context_line":"  in: body"},{"line_number":1336,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"2fa2482e_d420abb3","line":1333,"in_reply_to":"5b7bc05d_c1c56c72","updated":"2023-05-25 13:49:15.000000000","message":"Simplified it. Hopefully that helps.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"}],"doc/source/contributor/webapi-version-history.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15c05df78069c0a42ed49ec36dc4d9686d8d0262","unresolved":true,"context_lines":[{"line_number":6,"context_line":"----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"This version adds a concept of child nodes through the use of a"},{"line_number":9,"context_line":"``parent_node`` filed which can be set on a node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Under normal conditions, child nodes are not visible in the normal node"},{"line_number":12,"context_line":"list, as they are more for nested resources and not machines which can be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"2bb6c64b_4e7e281b","line":9,"updated":"2023-05-09 22:40:29.000000000","message":"field","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e358ce454b9355eb84a87f311ccb533392b4c84","unresolved":false,"context_lines":[{"line_number":6,"context_line":"----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"This version adds a concept of child nodes through the use of a"},{"line_number":9,"context_line":"``parent_node`` filed which can be set on a node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Under normal conditions, child nodes are not visible in the normal node"},{"line_number":12,"context_line":"list, as they are more for nested resources and not machines which can be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f2c195ea_3ec5ab55","line":9,"in_reply_to":"2bb6c64b_4e7e281b","updated":"2023-05-18 16:20:26.000000000","message":"Done","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b274247d2e252ace8f6c5f4f48560fdb563f1375","unresolved":true,"context_lines":[{"line_number":2724,"context_line":"        policy_checks \u003d []"},{"line_number":2725,"context_line":"        generic_update \u003d False"},{"line_number":2726,"context_line":""},{"line_number":2727,"context_line":"        paths_to_policy \u003d ("},{"line_number":2728,"context_line":"            (\u0027/instance_info\u0027, \u0027baremetal:node:update_instance_info\u0027),"},{"line_number":2729,"context_line":"            (\u0027/extra\u0027, \u0027baremetal:node:update_extra\u0027),"},{"line_number":2730,"context_line":"            (\u0027/driver_info\u0027, \u0027baremetal:node:update:driver_info\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"c059f9b9_c82ae43e","line":2727,"updated":"2023-05-24 20:23:06.000000000","message":"My favorite part of this whole patch series :D Thanks for making this better.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a5daa538a7136a564469b9b714720cb63f7dce","unresolved":true,"context_lines":[{"line_number":2724,"context_line":"        policy_checks \u003d []"},{"line_number":2725,"context_line":"        generic_update \u003d False"},{"line_number":2726,"context_line":""},{"line_number":2727,"context_line":"        paths_to_policy \u003d ("},{"line_number":2728,"context_line":"            (\u0027/instance_info\u0027, \u0027baremetal:node:update_instance_info\u0027),"},{"line_number":2729,"context_line":"            (\u0027/extra\u0027, \u0027baremetal:node:update_extra\u0027),"},{"line_number":2730,"context_line":"            (\u0027/driver_info\u0027, \u0027baremetal:node:update:driver_info\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5cdc5fd8_2c129068","line":2727,"in_reply_to":"c059f9b9_c82ae43e","updated":"2023-05-25 13:49:15.000000000","message":"My pleasure!","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"}],"ironic/common/policy.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15c05df78069c0a42ed49ec36dc4d9686d8d0262","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    ),"},{"line_number":1004,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":1005,"context_line":"        name\u003d\u0027baremetal:node:update:parent_node\u0027,"},{"line_number":1006,"context_line":"        check_str\u003dSYSTEM_MEMBER,"},{"line_number":1007,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":1008,"context_line":"        description\u003d\u0027Governs if node parent_node field can be updated via \u0027"},{"line_number":1009,"context_line":"                    \u0027the API clients.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cc12f699_94229c37","line":1006,"updated":"2023-05-09 22:40:29.000000000","message":"Generally curious what the use case would be for this being a separate policy from any node update.","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e358ce454b9355eb84a87f311ccb533392b4c84","unresolved":true,"context_lines":[{"line_number":1003,"context_line":"    ),"},{"line_number":1004,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":1005,"context_line":"        name\u003d\u0027baremetal:node:update:parent_node\u0027,"},{"line_number":1006,"context_line":"        check_str\u003dSYSTEM_MEMBER,"},{"line_number":1007,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":1008,"context_line":"        description\u003d\u0027Governs if node parent_node field can be updated via \u0027"},{"line_number":1009,"context_line":"                    \u0027the API clients.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d0586cc1_305cdfd6","line":1006,"in_reply_to":"cc12f699_94229c37","updated":"2023-05-18 16:20:26.000000000","message":"The \u0027baremetal:node:update\u0027 policy is assigned to SYSTEM_OR_PROJECT_MEMBER alias, which is why sensitive fields have tighter controls. So basically, only those in charge of the system should be permitted here.","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b274247d2e252ace8f6c5f4f48560fdb563f1375","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"    ),"},{"line_number":1004,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":1005,"context_line":"        name\u003d\u0027baremetal:node:update:parent_node\u0027,"},{"line_number":1006,"context_line":"        check_str\u003dSYSTEM_MEMBER,"},{"line_number":1007,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":1008,"context_line":"        description\u003d\u0027Governs if node parent_node field can be updated via \u0027"},{"line_number":1009,"context_line":"                    \u0027the API clients.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e8ccc37e_12245a2a","line":1006,"in_reply_to":"d0586cc1_305cdfd6","updated":"2023-05-24 20:23:06.000000000","message":"Ack","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15c05df78069c0a42ed49ec36dc4d9686d8d0262","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def node_post_data(**kw):"},{"line_number":104,"context_line":"    node \u003d db_utils.get_test_node(**kw)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # NOTE(jroll): pop out fields that were introduced in later API versions,"},{"line_number":107,"context_line":"    # unless explicitly requested. Otherwise, these will cause tests using"},{"line_number":108,"context_line":"    # older API versions to fail."}],"source_content_type":"text/x-python","patch_set":6,"id":"959038f5_e00b3424","side":"PARENT","line":105,"updated":"2023-05-09 22:40:29.000000000","message":"accidental?","commit_id":"75b881bd31952b8f858b4708fb83f7d2ca7c42cc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e358ce454b9355eb84a87f311ccb533392b4c84","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def node_post_data(**kw):"},{"line_number":104,"context_line":"    node \u003d db_utils.get_test_node(**kw)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # NOTE(jroll): pop out fields that were introduced in later API versions,"},{"line_number":107,"context_line":"    # unless explicitly requested. Otherwise, these will cause tests using"},{"line_number":108,"context_line":"    # older API versions to fail."}],"source_content_type":"text/x-python","patch_set":6,"id":"0550da4e_fa78dfbd","side":"PARENT","line":105,"in_reply_to":"959038f5_e00b3424","updated":"2023-05-18 16:20:26.000000000","message":"Done","commit_id":"75b881bd31952b8f858b4708fb83f7d2ca7c42cc"}],"releasenotes/notes/add-parent-node-support-10bd42abd008db6f.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15c05df78069c0a42ed49ec36dc4d9686d8d0262","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    Adds a ``/v1/nodes/?include_children\u003dTrue`` parameter to get a list of"},{"line_number":14,"context_line":"    all nodes and their children."},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Adds a ``/v1/nodes/?parent_node\u003d\u003cnode_ident\u003e`` query parameter to "},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    This upgrade contains an additional field for the ``nodes`` table, named"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"36e31ece_2da8e0b3","line":16,"updated":"2023-05-09 22:40:29.000000000","message":"this trails off, I think you need to complete the bulletpoint","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0e358ce454b9355eb84a87f311ccb533392b4c84","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    Adds a ``/v1/nodes/?include_children\u003dTrue`` parameter to get a list of"},{"line_number":14,"context_line":"    all nodes and their children."},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Adds a ``/v1/nodes/?parent_node\u003d\u003cnode_ident\u003e`` query parameter to "},{"line_number":17,"context_line":"upgrade:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    This upgrade contains an additional field for the ``nodes`` table, named"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f26284f_3d980de8","line":16,"in_reply_to":"36e31ece_2da8e0b3","updated":"2023-05-18 16:20:26.000000000","message":"Done","commit_id":"96f127f598b19663cae46ac04eb28588d459fa26"}]}