)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9c5e4a9a0329076f3d20b5cd2c833bb3e7d772a7","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                        thread \u003d self._spawn_worker("},{"line_number":627,"context_line":"                                            utils.cleanup_after_timeout, task)"},{"line_number":628,"context_line":"                        thread.link(lambda t: task.release_resources())"},{"line_number":629,"context_line":"                    except Exception:"},{"line_number":630,"context_line":"                        task.release_resources()"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def rebalance_node_ring(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F0A8%3D","line":629,"updated":"2014-04-17 08:43:51.000000000","message":"I think better if unexpected exception logged\n\n except exception.NoFreeConductorWorker:\n     task.release_resources()\n     break\n except Exception as e:\n    ...log exception...\n    task.release_resources()","commit_id":"6a48a8ffa02a2d8ea7799da1b6d94e80a51cea88"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"84ba14776f46f61cfaa1c398081f574259ff211b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                             \u0027node %s\u0027) % node_uuid)"},{"line_number":621,"context_line":"                    node.last_error \u003d msg"},{"line_number":622,"context_line":"                    LOG.error(msg)"},{"line_number":623,"context_line":"                    node.save(task.context)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"                    try:"},{"line_number":626,"context_line":"                        thread \u003d self._spawn_worker("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FiGk%3D","side":"PARENT","line":623,"updated":"2014-04-20 06:46:55.000000000","message":"I see you abandoned this... but I think you may be right. This method really needs some additional love, though.\n\n1) Not a fan of all of the indenting when you can \u0027continue\u0027\n2) We could actually add a DB filter on \u0027provision_state\u0027. The\n   DB API method doesn\u0027t support filtering on it right now, but\n   that\u0027s trivial to add\n3) There\u0027s a bug in here because we check the provision_state BEFORE the lock... it\u0027s possible it finished between the time we pull get_nodeinfo_list and the time we lock. Probably rare, but should be fixed.\n4) There\u0027s this bug you found","commit_id":"36041ad97ecf4056b96fce1c805daa29e736636a"}]}