)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89f4a2d96779fcc174b538b8638d1dac6d91c3ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3bae878a_c7b7d639","updated":"2023-05-24 20:38:10.000000000","message":"Please fix operator-visible formatting/spelling issues in a follow-up.","commit_id":"d55154ba205f904391fadffb42610399da234922"}],"doc/source/admin/cleaning.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89f4a2d96779fcc174b538b8638d1dac6d91c3ae","unresolved":true,"context_lines":[{"line_number":426,"context_line":"      \"step\": \"power_off\","},{"line_number":427,"context_line":"      \"execute_on_child_nodes\": True"},{"line_number":428,"context_line":"      \"limit_child_node_execution\": [\u0027f96c8601-0a62-4e99-97d6-1e0d8daf6dce\u0027]"},{"line_number":429,"context_line":"    }    {"},{"line_number":430,"context_line":"      \"interface\": \"deploy\","},{"line_number":431,"context_line":"      \"step\": \"erase_devices\""},{"line_number":432,"context_line":"    }]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"967e51df_835394af","line":429,"updated":"2023-05-24 20:38:10.000000000","message":"formatting is a bit off here","commit_id":"d55154ba205f904391fadffb42610399da234922"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9a75f6c7842478dad658b2640bb2300b74ed001d","unresolved":false,"context_lines":[{"line_number":426,"context_line":"      \"step\": \"power_off\","},{"line_number":427,"context_line":"      \"execute_on_child_nodes\": True"},{"line_number":428,"context_line":"      \"limit_child_node_execution\": [\u0027f96c8601-0a62-4e99-97d6-1e0d8daf6dce\u0027]"},{"line_number":429,"context_line":"    }    {"},{"line_number":430,"context_line":"      \"interface\": \"deploy\","},{"line_number":431,"context_line":"      \"step\": \"erase_devices\""},{"line_number":432,"context_line":"    }]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"aea444da_19e812f8","line":429,"in_reply_to":"967e51df_835394af","updated":"2023-05-24 22:35:26.000000000","message":"Done","commit_id":"d55154ba205f904391fadffb42610399da234922"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89f4a2d96779fcc174b538b8638d1dac6d91c3ae","unresolved":true,"context_lines":[{"line_number":439,"context_line":".. NOTE::"},{"line_number":440,"context_line":"   While the deployment step framework also supports the"},{"line_number":441,"context_line":"   ``execute_on_child_nodes`` and ``limit_child_node_execution`` parameters,"},{"line_number":442,"context_line":"   all of the step frameworks have a fundimental limitation in that child node"},{"line_number":443,"context_line":"   step execution is indended for syncronous actions which do not rely upon"},{"line_number":444,"context_line":"   the ``ironic-python-agent`` running on any child nodes. This constraint may"},{"line_number":445,"context_line":"   be changed in the future."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ea42909_f430ec8d","line":442,"updated":"2023-05-24 20:38:10.000000000","message":"spelling: fundamental","commit_id":"d55154ba205f904391fadffb42610399da234922"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9a75f6c7842478dad658b2640bb2300b74ed001d","unresolved":false,"context_lines":[{"line_number":439,"context_line":".. NOTE::"},{"line_number":440,"context_line":"   While the deployment step framework also supports the"},{"line_number":441,"context_line":"   ``execute_on_child_nodes`` and ``limit_child_node_execution`` parameters,"},{"line_number":442,"context_line":"   all of the step frameworks have a fundimental limitation in that child node"},{"line_number":443,"context_line":"   step execution is indended for syncronous actions which do not rely upon"},{"line_number":444,"context_line":"   the ``ironic-python-agent`` running on any child nodes. This constraint may"},{"line_number":445,"context_line":"   be changed in the future."}],"source_content_type":"text/x-rst","patch_set":6,"id":"2fa5eb8c_3b399ac0","line":442,"in_reply_to":"3ea42909_f430ec8d","updated":"2023-05-24 22:35:26.000000000","message":"Done","commit_id":"d55154ba205f904391fadffb42610399da234922"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c812f67369ab6e6897165c1f585ae48deb79534b","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                \"type\": \"object\","},{"line_number":81,"context_line":"                \"properties\": {}"},{"line_number":82,"context_line":"            },"},{"line_number":83,"context_line":"            \"execute_on_child_nodes\": {"},{"line_number":84,"context_line":"                \"description\": \"Boolean if the step should be executed \""},{"line_number":85,"context_line":"                               \"on child nodes.\","},{"line_number":86,"context_line":"                \"type\": \"boolean\","},{"line_number":87,"context_line":"            },"},{"line_number":88,"context_line":"            \"limit_child_node_execution\": {"},{"line_number":89,"context_line":"                \"description\": \"List of nodes upon which to execute child \""},{"line_number":90,"context_line":"                               \"node steps on.\","},{"line_number":91,"context_line":"                \"type\": \"array\","},{"line_number":92,"context_line":"            }"},{"line_number":93,"context_line":"        },"},{"line_number":94,"context_line":"        # interface, step and args are the only expected keys"},{"line_number":95,"context_line":"        \"additionalProperties\": False"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"0a7f3721_29096942","line":93,"range":{"start_line":83,"start_character":10,"end_line":93,"end_character":0},"updated":"2023-05-05 00:28:29.000000000","message":"If we\u0027re good with doing this, we need to update the DeployTemplateStep and related  schema to hold the additional fields.\n\nReason for not args:\n\nThese are not args *for* the step backend to use.\nThey are for ironic to use to figure out what is desired.","commit_id":"34ceeafc8a3f24240d7c956cd60b9e7925f03164"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"209869e2a891ebf871248a2cb6f277e00905459b","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                \"type\": \"object\","},{"line_number":81,"context_line":"                \"properties\": {}"},{"line_number":82,"context_line":"            },"},{"line_number":83,"context_line":"            \"execute_on_child_nodes\": {"},{"line_number":84,"context_line":"                \"description\": \"Boolean if the step should be executed \""},{"line_number":85,"context_line":"                               \"on child nodes.\","},{"line_number":86,"context_line":"                \"type\": \"boolean\","},{"line_number":87,"context_line":"            },"},{"line_number":88,"context_line":"            \"limit_child_node_execution\": {"},{"line_number":89,"context_line":"                \"description\": \"List of nodes upon which to execute child \""},{"line_number":90,"context_line":"                               \"node steps on.\","},{"line_number":91,"context_line":"                \"type\": \"array\","},{"line_number":92,"context_line":"            }"},{"line_number":93,"context_line":"        },"},{"line_number":94,"context_line":"        # interface, step and args are the only expected keys"},{"line_number":95,"context_line":"        \"additionalProperties\": False"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"e100e198_22a38db4","line":93,"range":{"start_line":83,"start_character":10,"end_line":93,"end_character":0},"in_reply_to":"0a7f3721_29096942","updated":"2023-05-09 21:45:45.000000000","message":"Updating spec..","commit_id":"34ceeafc8a3f24240d7c956cd60b9e7925f03164"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6bb76b69bc62ff96176369af37912ad95f0782da","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \"type\": \"object\","},{"line_number":81,"context_line":"                \"properties\": {}"},{"line_number":82,"context_line":"            },"},{"line_number":83,"context_line":"            \"execute_on_child_nodes\": {"},{"line_number":84,"context_line":"                \"description\": \"Boolean if the step should be executed \""},{"line_number":85,"context_line":"                               \"on child nodes.\","},{"line_number":86,"context_line":"                \"type\": \"boolean\","},{"line_number":87,"context_line":"            },"},{"line_number":88,"context_line":"            \"limit_child_node_execution\": {"},{"line_number":89,"context_line":"                \"description\": \"List of nodes upon which to execute child \""},{"line_number":90,"context_line":"                               \"node steps on.\","},{"line_number":91,"context_line":"                \"type\": \"array\","},{"line_number":92,"context_line":"            }"},{"line_number":93,"context_line":"        },"},{"line_number":94,"context_line":"        # interface, step and args are the only expected keys"},{"line_number":95,"context_line":"        \"additionalProperties\": False"},{"line_number":96,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c1134e6_a9eab7e7","line":93,"range":{"start_line":83,"start_character":10,"end_line":93,"end_character":0},"in_reply_to":"e100e198_22a38db4","updated":"2023-05-19 16:46:04.000000000","message":"Done","commit_id":"34ceeafc8a3f24240d7c956cd60b9e7925f03164"}],"ironic/conductor/deployments.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89f4a2d96779fcc174b538b8638d1dac6d91c3ae","unresolved":true,"context_lines":[{"line_number":281,"context_line":"                if not conductor_steps.use_reserved_step_handler(task, step):"},{"line_number":282,"context_line":"                    result \u003d interface.execute_deploy_step(task, step)"},{"line_number":283,"context_line":"            else:"},{"line_number":284,"context_line":"                LOG.info(\u0027Exeucting %(step)s on child nodes for node \u0027"},{"line_number":285,"context_line":"                         \u0027%(node)s\u0027,"},{"line_number":286,"context_line":"                         {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":287,"context_line":"                result \u003d execute_step_on_child_nodes(task, step)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ecb486be_3659220a","line":284,"updated":"2023-05-24 20:38:10.000000000","message":"spelling: Executing","commit_id":"d55154ba205f904391fadffb42610399da234922"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9a75f6c7842478dad658b2640bb2300b74ed001d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                if not conductor_steps.use_reserved_step_handler(task, step):"},{"line_number":282,"context_line":"                    result \u003d interface.execute_deploy_step(task, step)"},{"line_number":283,"context_line":"            else:"},{"line_number":284,"context_line":"                LOG.info(\u0027Exeucting %(step)s on child nodes for node \u0027"},{"line_number":285,"context_line":"                         \u0027%(node)s\u0027,"},{"line_number":286,"context_line":"                         {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":287,"context_line":"                result \u003d execute_step_on_child_nodes(task, step)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fd26e410_f0a0df2b","line":284,"in_reply_to":"ecb486be_3659220a","updated":"2023-05-24 22:35:26.000000000","message":"Done","commit_id":"d55154ba205f904391fadffb42610399da234922"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89f4a2d96779fcc174b538b8638d1dac6d91c3ae","unresolved":true,"context_lines":[{"line_number":295,"context_line":"        task, fields.NotificationLevel.INFO, fields.NotificationStatus.START,"},{"line_number":296,"context_line":"        new_state)"},{"line_number":297,"context_line":"    node \u003d task.node"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if _can_skip_state_change(task, new_state):"},{"line_number":300,"context_line":"        # NOTE(TheJulia): Even if we are not changing the power state,"},{"line_number":301,"context_line":"        # we need to wipe the token out, just in case for some reason"}],"source_content_type":"text/x-python","patch_set":6,"id":"2b5e3e0a_e350c1cc","side":"PARENT","line":298,"updated":"2023-05-24 20:38:10.000000000","message":"unintentional change?","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9a75f6c7842478dad658b2640bb2300b74ed001d","unresolved":true,"context_lines":[{"line_number":295,"context_line":"        task, fields.NotificationLevel.INFO, fields.NotificationStatus.START,"},{"line_number":296,"context_line":"        new_state)"},{"line_number":297,"context_line":"    node \u003d task.node"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if _can_skip_state_change(task, new_state):"},{"line_number":300,"context_line":"        # NOTE(TheJulia): Even if we are not changing the power state,"},{"line_number":301,"context_line":"        # we need to wipe the token out, just in case for some reason"}],"source_content_type":"text/x-python","patch_set":6,"id":"4455725b_f892eae3","side":"PARENT","line":298,"in_reply_to":"2b5e3e0a_e350c1cc","updated":"2023-05-24 22:35:26.000000000","message":"Eh, There was an intentional change, but I did the needful elsewhere.","commit_id":"3f5e25e182c0b369b7491c39a6fb1c72e38ac728"}]}