)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"28ca767d42cb6136b8669414ab62c3bfffa760e3","unresolved":true,"context_lines":[{"line_number":2477,"context_line":"    def get_node_history_by_id(self, history_id):"},{"line_number":2478,"context_line":"        query \u003d model_query(models.NodeHistory).filter_by(id\u003dhistory_id)"},{"line_number":2479,"context_line":"        try:"},{"line_number":2480,"context_line":"            return query.one()"},{"line_number":2481,"context_line":"        except NoResultFound:"},{"line_number":2482,"context_line":"            raise exception.NodeHistoryNotFound(history\u003dhistory_id)"},{"line_number":2483,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":4,"id":"e1e8d475_0c4c506b","line":2480,"range":{"start_line":2480,"start_character":12,"end_line":2480,"end_character":30},"updated":"2023-04-28 18:57:20.000000000","message":"should be res \u003d query.one()","commit_id":"0c813718e50dfee3e03e7061d3a8600f61a677b2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee15d5be636e82cd32165cde168b277e1ad000b0","unresolved":false,"context_lines":[{"line_number":2477,"context_line":"    def get_node_history_by_id(self, history_id):"},{"line_number":2478,"context_line":"        query \u003d model_query(models.NodeHistory).filter_by(id\u003dhistory_id)"},{"line_number":2479,"context_line":"        try:"},{"line_number":2480,"context_line":"            return query.one()"},{"line_number":2481,"context_line":"        except NoResultFound:"},{"line_number":2482,"context_line":"            raise exception.NodeHistoryNotFound(history\u003dhistory_id)"},{"line_number":2483,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":4,"id":"915a9761_15a56d6b","line":2480,"range":{"start_line":2480,"start_character":12,"end_line":2480,"end_character":30},"in_reply_to":"e1e8d475_0c4c506b","updated":"2023-05-01 19:22:04.000000000","message":"Done","commit_id":"0c813718e50dfee3e03e7061d3a8600f61a677b2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"049ea4d7f2b2ff6c18bdb10c3df1856fd974dfe4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from osprofiler import sqlalchemy as osp_sqlalchemy"},{"line_number":34,"context_line":"import sqlalchemy as sa"},{"line_number":35,"context_line":"from sqlalchemy import or_"},{"line_number":36,"context_line":"from sqlalchemy.exc import NoResultFound, MultipleResultsFound, OperationalError  # noqa"},{"line_number":37,"context_line":"from sqlalchemy.orm import Load"},{"line_number":38,"context_line":"from sqlalchemy.orm import selectinload"},{"line_number":39,"context_line":"from sqlalchemy import sql"}],"source_content_type":"text/x-python","patch_set":8,"id":"67e6e44e_715daa3d","line":36,"updated":"2023-05-01 19:56:53.000000000","message":"Undo this.","commit_id":"1cef453e8cfa3202426306657549d776d41dde9f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"049ea4d7f2b2ff6c18bdb10c3df1856fd974dfe4","unresolved":false,"context_lines":[{"line_number":1303,"context_line":"            ).execution_options(synchronize_session\u003dFalse)"},{"line_number":1304,"context_line":"            res \u003d session.execute(query)"},{"line_number":1305,"context_line":"            count \u003d res.rowcount"},{"line_number":1306,"context_line":"            session.commit()"},{"line_number":1307,"context_line":"        if count \u003d\u003d 0:"},{"line_number":1308,"context_line":"            raise exception.ConductorNotFound(conductor\u003dhostname)"},{"line_number":1309,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"74c1b475_5cbbed0a","line":1306,"updated":"2023-05-01 19:56:53.000000000","message":"wow, yeah, this needs to go....","commit_id":"1cef453e8cfa3202426306657549d776d41dde9f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e2a530bc1c60cd982f1beb7d7ae6e059460bace7","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        else:"},{"line_number":331,"context_line":"            # In this case, we have a sqlalchemy.sql.selectable.Select"},{"line_number":332,"context_line":"            # (most likely) which utilizes the unified select interface."},{"line_number":333,"context_line":"            res \u003d session.execute(query).fetchall()"},{"line_number":334,"context_line":"            if len(res) \u003d\u003d 0:"},{"line_number":335,"context_line":"                # Return an empty list instead of a class with no objects."},{"line_number":336,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":10,"id":"159d255c_8e4f1d07","line":333,"updated":"2023-05-01 21:04:51.000000000","message":"It\u0027s really weird to see ref used above, and res used in the else with an early return.\n\nIs there a reason we don\u0027t assign to ref on line 343 so it\u0027s easier to follow the method flow?","commit_id":"a73a3409daa330eebf6e489091ebbdcc20578176"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c525f1181fb4d2693a47755719f2d10850bff98","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        else:"},{"line_number":331,"context_line":"            # In this case, we have a sqlalchemy.sql.selectable.Select"},{"line_number":332,"context_line":"            # (most likely) which utilizes the unified select interface."},{"line_number":333,"context_line":"            res \u003d session.execute(query).fetchall()"},{"line_number":334,"context_line":"            if len(res) \u003d\u003d 0:"},{"line_number":335,"context_line":"                # Return an empty list instead of a class with no objects."},{"line_number":336,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f260019_1ddc8664","line":333,"in_reply_to":"159d255c_8e4f1d07","updated":"2023-05-01 22:23:43.000000000","message":"I guess we could and just exit out of the task. If we have an ORM object, that lives as long as the task is open and returning in a task means the task is not fully released out until the ORM until the entire result sets gets handed back out.\n\nWhere as if it is not an orm object, we\u0027re just dealing with tuples that are disconnected from the session so it is totally okay to return from within the session.","commit_id":"a73a3409daa330eebf6e489091ebbdcc20578176"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e16c75f383540769ff28311bc62ebe7540e19fe2","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        else:"},{"line_number":331,"context_line":"            # In this case, we have a sqlalchemy.sql.selectable.Select"},{"line_number":332,"context_line":"            # (most likely) which utilizes the unified select interface."},{"line_number":333,"context_line":"            res \u003d session.execute(query).fetchall()"},{"line_number":334,"context_line":"            if len(res) \u003d\u003d 0:"},{"line_number":335,"context_line":"                # Return an empty list instead of a class with no objects."},{"line_number":336,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":10,"id":"031157fc_b1bd9841","line":333,"in_reply_to":"7f260019_1ddc8664","updated":"2023-05-03 13:36:50.000000000","message":"Done","commit_id":"a73a3409daa330eebf6e489091ebbdcc20578176"}]}