)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e846c20e1dca1dacb620adc2f539d436e96f2d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3cbf09f2_5ec479b3","updated":"2023-05-15 08:45:20.000000000","message":"Thank you, Iury. LGTM (pending CI pass, just ran a recheck, looks like continuation of problems from past weeks).","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"dd26f09f00e72356eb8f22dbe1d12f3c7623a706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ddf9cf1_7bd4e1f5","updated":"2023-05-15 07:38:57.000000000","message":"recheck","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8c6f5bf4cb2a63c930c9783ac513c7450fe22973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"438df24b_41ade52a","updated":"2023-05-16 22:48:46.000000000","message":"recheck bfv job is non-voting","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ba86c5137873cfdb4d0a6650869894fe8e5a7064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ddca068b_8b3c900d","updated":"2023-05-21 21:48:34.000000000","message":"recheck we merged a few patches in CI, let\u0027s CI new results","commit_id":"5a6d1cb93bcc9c3c0e73ebb67ca759be6ad2f793"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a873b119c8067c450f54ca095e4b7b9147294844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2116d66c_fee57e3b","updated":"2023-05-24 01:51:00.000000000","message":"recheck cirros patch merged and already promoted","commit_id":"cc784d1520e6f7a53a95fa1fea32fc9852bc891d"}],"ironic/db/sqlalchemy/alembic/versions/163040c5513f_add_firmware_information.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d7eb495289163bd3af7d22dc5c06957c4396d29a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                  nullable\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027version\u0027, sa.String(length\u003d15), nullable\u003dTrue),"},{"line_number":43,"context_line":"        sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027node_id\u0027, \u0027component\u0027),"},{"line_number":45,"context_line":"        mysql_ENGINE\u003d\u0027InnoDB\u0027,"},{"line_number":46,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":47,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"fe957f48_8759c6b6","line":44,"updated":"2023-05-17 15:53:45.000000000","message":"I\u0027d double check this, I don\u0027t think you can have multiple fields be the primary key constraint.\n\nYou want a unique constraint and you want indexes on those fields for the unique constraint to be performant.\n\n\nhttps://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/versions/9ef41f07cb58_add_node_history_table.py\nhttps://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/versions/2581ebaf0cb2_initial_migration.py#L81-L99","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"55f6211fdd5ec2ab96c2dbe571ec640eabdeef7a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                  nullable\u003dTrue),"},{"line_number":42,"context_line":"        sa.Column(\u0027version\u0027, sa.String(length\u003d15), nullable\u003dTrue),"},{"line_number":43,"context_line":"        sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027node_id\u0027, \u0027component\u0027),"},{"line_number":45,"context_line":"        mysql_ENGINE\u003d\u0027InnoDB\u0027,"},{"line_number":46,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":47,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"e3286c5f_aff4a78d","line":44,"in_reply_to":"fe957f48_8759c6b6","updated":"2023-05-17 15:55:32.000000000","message":"Ack","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d7eb495289163bd3af7d22dc5c06957c4396d29a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027node_id\u0027, \u0027component\u0027),"},{"line_number":45,"context_line":"        mysql_ENGINE\u003d\u0027InnoDB\u0027,"},{"line_number":46,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027firmware_interface\u0027,"},{"line_number":49,"context_line":"                                     sa.String(length\u003d255), nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"a516c08b_36f6489b","line":46,"updated":"2023-05-17 15:53:45.000000000","message":"Please set this to UTF8MB3 instead of UTF8.","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"55f6211fdd5ec2ab96c2dbe571ec640eabdeef7a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"        sa.PrimaryKeyConstraint(\u0027node_id\u0027, \u0027component\u0027),"},{"line_number":45,"context_line":"        mysql_ENGINE\u003d\u0027InnoDB\u0027,"},{"line_number":46,"context_line":"        mysql_DEFAULT_CHARSET\u003d\u0027UTF8\u0027"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027firmware_interface\u0027,"},{"line_number":49,"context_line":"                                     sa.String(length\u003d255), nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"e799a007_6e74097b","line":46,"in_reply_to":"a516c08b_36f6489b","updated":"2023-05-17 15:55:32.000000000","message":"Done","commit_id":"906fd680f66e123465a64f59a213bbbbfc40ddc3"}]}