)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"af7443490fd9cb75bb39f8fda6254010d0c2d3a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4d25a0c_61b1dfed","updated":"2023-07-11 06:43:47.000000000","message":"recheck","commit_id":"ff1be27e94c5833085df5c05ba507fb98d00016c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a60b74ce4dc0bf5d11b65d1278c571c5c713f9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8572412b_39563615","updated":"2023-07-31 17:28:40.000000000","message":"Please please please follow-up with those docstrings w/types on args; they are so helpful when trying to write code later :).","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"}],"ironic/drivers/modules/inspector/agent.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"1840b651d7641763664045070e90623b285bca06","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        :param plugin_data: optional plugin-specific data."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        # TODO(dtantsur): migrate the whole pipeline from ironic-inspector"},{"line_number":82,"context_line":"        nics.process_interfaces(task, inventory, plugin_data)"},{"line_number":83,"context_line":"        common.clean_up(task, finish\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"12b50f12_7f4ac49b","line":82,"updated":"2023-06-27 14:13:38.000000000","message":"This is where the inspection hooks would now be called, right?","commit_id":"6da4ed354530ca27d38f708497e6359ea8367e60"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a60b74ce4dc0bf5d11b65d1278c571c5c713f9c","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        :param inventory: hardware inventory from the node."},{"line_number":79,"context_line":"        :param plugin_data: optional plugin-specific data."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        # TODO(dtantsur): migrate the whole pipeline from ironic-inspector"},{"line_number":82,"context_line":"        nics.process_interfaces(task, inventory, plugin_data)"},{"line_number":83,"context_line":"        common.clean_up(task, finish\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b1c554e8_0acb522c","line":81,"updated":"2023-07-31 17:28:40.000000000","message":"todo still valid?","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38e2026fccdd04433a0146a69ae04398d9bbbd71","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        :param inventory: hardware inventory from the node."},{"line_number":79,"context_line":"        :param plugin_data: optional plugin-specific data."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        # TODO(dtantsur): migrate the whole pipeline from ironic-inspector"},{"line_number":82,"context_line":"        nics.process_interfaces(task, inventory, plugin_data)"},{"line_number":83,"context_line":"        common.clean_up(task, finish\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c510be42_99fe5812","line":81,"in_reply_to":"b1c554e8_0acb522c","updated":"2023-07-31 17:36:26.000000000","message":"Yep, Mahnoor is working on it.","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"}],"ironic/drivers/modules/inspector/nics.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a60b74ce4dc0bf5d11b65d1278c571c5c713f9c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"\"\"Get MAC address of the PXE interface.\"\"\""},{"line_number":27,"context_line":"    pxe_mac \u003d inventory.get(\u0027boot\u0027, {}).get(\u0027pxe_interface\u0027)"},{"line_number":28,"context_line":"    if pxe_mac and \u0027-\u0027 in pxe_mac:"},{"line_number":29,"context_line":"        # pxelinux format: 01-aa-bb-cc-dd-ee-ff"},{"line_number":30,"context_line":"        pxe_mac \u003d pxe_mac.split(\u0027-\u0027, 1)[1]"},{"line_number":31,"context_line":"        pxe_mac \u003d pxe_mac.replace(\u0027-\u0027, \u0027:\u0027).lower()"},{"line_number":32,"context_line":"    return pxe_mac"}],"source_content_type":"text/x-python","patch_set":7,"id":"3dfcacc8_7d85fd04","line":29,"updated":"2023-07-31 17:28:40.000000000","message":"nit: this is not a valid mac; it\u0027s 7 hex pairs; MACs are 6 hex pairs 😊","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38e2026fccdd04433a0146a69ae04398d9bbbd71","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"\"\"Get MAC address of the PXE interface.\"\"\""},{"line_number":27,"context_line":"    pxe_mac \u003d inventory.get(\u0027boot\u0027, {}).get(\u0027pxe_interface\u0027)"},{"line_number":28,"context_line":"    if pxe_mac and \u0027-\u0027 in pxe_mac:"},{"line_number":29,"context_line":"        # pxelinux format: 01-aa-bb-cc-dd-ee-ff"},{"line_number":30,"context_line":"        pxe_mac \u003d pxe_mac.split(\u0027-\u0027, 1)[1]"},{"line_number":31,"context_line":"        pxe_mac \u003d pxe_mac.replace(\u0027-\u0027, \u0027:\u0027).lower()"},{"line_number":32,"context_line":"    return pxe_mac"}],"source_content_type":"text/x-python","patch_set":7,"id":"81783888_ad3b3a44","line":29,"in_reply_to":"3dfcacc8_7d85fd04","updated":"2023-07-31 17:36:26.000000000","message":"Correct. But that\u0027s what we sometimes get. Maybe it was only with the old bash-based ramdisk though? Will think about it.","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a60b74ce4dc0bf5d11b65d1278c571c5c713f9c","unresolved":true,"context_lines":[{"line_number":35,"context_line":"def get_interfaces(node, inventory):"},{"line_number":36,"context_line":"    \"\"\"Convert inventory to a dict with interfaces."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    :return: dict interface name -\u003e interface (for valid interfaces)."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    result \u003d {}"},{"line_number":41,"context_line":"    pxe_mac \u003d get_pxe_mac(inventory)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5db5fcd7_d513a5a4","line":38,"updated":"2023-07-31 17:28:40.000000000","message":"Can we ensure we get fully fleshed out pydocs, including types of arguments being passed in, either here or in a follow-up. (throughout)","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38e2026fccdd04433a0146a69ae04398d9bbbd71","unresolved":true,"context_lines":[{"line_number":35,"context_line":"def get_interfaces(node, inventory):"},{"line_number":36,"context_line":"    \"\"\"Convert inventory to a dict with interfaces."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    :return: dict interface name -\u003e interface (for valid interfaces)."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    result \u003d {}"},{"line_number":41,"context_line":"    pxe_mac \u003d get_pxe_mac(inventory)"}],"source_content_type":"text/x-python","patch_set":7,"id":"14320d3f_6b6b15a4","line":38,"in_reply_to":"5db5fcd7_d513a5a4","updated":"2023-07-31 17:36:26.000000000","message":"Ack. Doing so here would conflict with the Mahnoor\u0027s work, but will make a mental note.","commit_id":"afada321d80c2e053bd8156972f57dbd4b7b3687"}]}