)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6ac6533b07dc805e9eeac80c91fba9f10f5888e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d2b5bc9_aa0fee04","updated":"2023-07-31 22:54:17.000000000","message":"Closed wrong patch, apologies for confusion, this one is still needed for now","commit_id":"bc8099ae146abc260a05555376e1e3ff60a20c49"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b39d7c419afd938dc97b60317d1a976261796122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb278bdd_fd152243","updated":"2023-07-31 11:29:38.000000000","message":"This is obsoleted by https://review.opendev.org/c/openstack/ironic/+/863999 - this change was raised accidentally by skipping the necessary rebase step.","commit_id":"bc8099ae146abc260a05555376e1e3ff60a20c49"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d895e48d3d879f4ff569c369650d5a120cc5e762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd2fa2ff_79415eba","updated":"2023-08-08 03:23:42.000000000","message":"Thank you for your review, Julia. Fixed the problem you pointed out in this revision.","commit_id":"f93712d7a61100b72a0d7fc236b727a8655ca8c9"}],"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adac9b06df51cb371d722b17b2251bb9e426f432","unresolved":true,"context_lines":[{"line_number":232,"context_line":"                                       \u0027settings\u0027: settings})"},{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                supported_apply_times \u003d bios.supported_apply_times"},{"line_number":235,"context_line":"                if sushy.APPLY_TIME_ON_RESET in supported_apply_times:"},{"line_number":236,"context_line":"                    apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":237,"context_line":"                else:"},{"line_number":238,"context_line":"                    apply_time \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6901ec2_48f12d23","line":235,"updated":"2023-08-08 03:05:54.000000000","message":"As I can read the sushy code, supported_apply_times *could* be a None\n\nAnd I think the original guard is important here, because you can\u0027t use in on NoneType as it is not iterable.","commit_id":"d25c8e31a8432b46077176f6a0b39d5fdfd0c06e"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d895e48d3d879f4ff569c369650d5a120cc5e762","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                                       \u0027settings\u0027: settings})"},{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                supported_apply_times \u003d bios.supported_apply_times"},{"line_number":235,"context_line":"                if sushy.APPLY_TIME_ON_RESET in supported_apply_times:"},{"line_number":236,"context_line":"                    apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":237,"context_line":"                else:"},{"line_number":238,"context_line":"                    apply_time \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"416c6bf9_4c8422ca","line":235,"in_reply_to":"c6901ec2_48f12d23","updated":"2023-08-08 03:23:42.000000000","message":"Thank you Julia, great pickup. I somehow accidentally carried this regression over from the first revision of the patch (was fixed in the second iteration and then broken again). Should be all good now. \nAlso: moved \"apply_time \u003d None\" up to cater for both exception and no-exception cases and avoid repeats while at it.","commit_id":"d25c8e31a8432b46077176f6a0b39d5fdfd0c06e"}]}