)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"710c44fc8cdcec1434eecda3565e0b449b1e3ce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b7569536_868841ed","updated":"2023-09-06 08:47:26.000000000","message":"Hi Julia,\n\nWe are aware of this and the fix doesnt go in this file. It goes in some other file. But supporting ilo6 with ilo driver requires a bigger change, and we are working on it.\n\nSecondly, sushy workaround is a incomplete workaround and that incomplete fix also requires a fix.\nhttps://bugs.launchpad.net/sushy/+bug/2028214\n\nRegards\nNisha","commit_id":"b0bc092f51d42c1bb0b377c42a7e85ea98860938"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ac6c275b7d6cf40a7623ede78de76c5e9b016afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48d8f6c2_6cc64bfa","updated":"2023-07-12 16:16:32.000000000","message":"Nisha, adding you to see if you can provide input/clarity to this.\n\nI guess we\u0027re a little concerned by the automatic assumption anything that is an HPE server with a BMC is to use the ilo hardware type, which we know is not necessarilly correct, and now with OpenBMC on HPE Proliant hardware, we will need to provide more clarity to the operators of Ironic so they know what to do. In other words, any input you can provide would be helpful. Thanks!","commit_id":"b0bc092f51d42c1bb0b377c42a7e85ea98860938"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fbf8c87daba11381c7802c5bc1ce7de2e416fdc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c5ae121_1da4c9ed","in_reply_to":"b7569536_868841ed","updated":"2023-09-06 08:54:07.000000000","message":"Hi Julia,\n\n\u003e\u003eSecondly, sushy workaround is a incomplete workaround and that incomplete fix \u003e\u003ealso requires a fix.\n\u003e\u003e https://bugs.launchpad.net/sushy/+bug/2028214\n\nSorry the above comment was for the issue https://bugs.launchpad.net/proliantutils/+bug/2021995\n\nSorry to mix it with this patch.\n\nRegards\nNisha","commit_id":"b0bc092f51d42c1bb0b377c42a7e85ea98860938"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2c4a8cb07892a01d376b09e7e810c923219c8cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ee97eff_d7199e5c","updated":"2024-01-04 21:06:46.000000000","message":"doesn\u0027t work, couldn\u0027t get unit tests to run on my recently upgraded laptop. 😭","commit_id":"f8eccae93a41196cdb909fc7be8265ce59a7f14a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3fe46b8f54a71f35e03e41e0d8bcf65a31d5bd33","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fedbf7c1_1a185136","updated":"2024-01-24 21:17:37.000000000","message":"If there\u0027s a desire to backport this, has anyone seen if iLO6 machines work in older Ironics?","commit_id":"937ef691212b408f163102eacd5dcb58a2165226"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fd49ab06f0aeac387833c3e3c2306ad9e3341076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6c54fb5_36760e39","updated":"2024-01-22 10:15:45.000000000","message":"Sorry for somehow missing it earlier. But we want to backport this change, right? Then we need a release note maybe?","commit_id":"937ef691212b408f163102eacd5dcb58a2165226"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f737210a7d83188c67232ab679ed6615a8eea9d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fc36975c_bc7b704e","in_reply_to":"fedbf7c1_1a185136","updated":"2024-01-25 00:35:38.000000000","message":"Well, we sort of inherently know they just won\u0027t work.    I think we should go ahead and add a reno though.","commit_id":"937ef691212b408f163102eacd5dcb58a2165226"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3713d3cb3aecb9a42529f696d3ac25732b7cb4e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb5b311a_2bcf0917","updated":"2024-02-07 20:46:26.000000000","message":"It\u0027d be nice to fix the spelling issue so codespell doesn\u0027t get further behind... but I\u0027m waiting to workflow because it\u0027s unclear to me if Dmitry\u0027s comment on the same thread as me is resolved","commit_id":"47a67d12454848c394f2ef002e122f61af333369"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fa677a06b517a048214568c9cd615ee59b4c0217","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"382e7126_bc332413","updated":"2024-02-28 16:06:29.000000000","message":"Only change since previous approvals was a spelling fix, landing this.","commit_id":"e8cb96efc5c5528f360add4ecf15ad258f98f941"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"482d0a7417a1e9cbc5690c9e61dd1f8b01fe868a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0c31739_744f1ac8","updated":"2024-02-29 00:49:13.000000000","message":"recheck ironic-standalone is being moved to non-voting","commit_id":"e8cb96efc5c5528f360add4ecf15ad258f98f941"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0adfbaa0c2a30efae275a04f9f5af551be0287e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"766fbddc_82d0f15f","updated":"2024-03-07 23:29:07.000000000","message":"recheck multiple gate fixes have landed","commit_id":"e8cb96efc5c5528f360add4ecf15ad258f98f941"}],"ironic/drivers/modules/ilo/power.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d3dec3fe584b994c66a512704e57fc32ea593e61","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            warn_msg \u003d (\"Node %s appears to have a disabled API \""},{"line_number":89,"context_line":"                        \"required for the \\\u0027%s\\\u0027 hardware type to function. \""},{"line_number":90,"context_line":"                        \"Please consider using the \\\u0027redfish\\\u0027 hardware \""},{"line_number":91,"context_line":"                        \"type.\" % (node.uuid, node.driver))"},{"line_number":92,"context_line":"            manager_utils.node_history_record(node, event\u003dwarn_msg,"},{"line_number":93,"context_line":"                                              event_type\u003dnode.provision_state,"},{"line_number":94,"context_line":"                                              error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c609913_48e37677","line":91,"updated":"2024-01-05 08:51:46.000000000","message":"This won\u0027t be visible by users, maybe include in the error message too?","commit_id":"4e8ed74360333085d44fcbf3255b71caf3414a5a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c74d4af72fbf0dde5a46aa606338322786d6f294","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            warn_msg \u003d (\"Node %s appears to have a disabled API \""},{"line_number":89,"context_line":"                        \"required for the \\\u0027%s\\\u0027 hardware type to function. \""},{"line_number":90,"context_line":"                        \"Please consider using the \\\u0027redfish\\\u0027 hardware \""},{"line_number":91,"context_line":"                        \"type.\" % (node.uuid, node.driver))"},{"line_number":92,"context_line":"            manager_utils.node_history_record(node, event\u003dwarn_msg,"},{"line_number":93,"context_line":"                                              event_type\u003dnode.provision_state,"},{"line_number":94,"context_line":"                                              error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a23debaf_951f86b0","line":91,"in_reply_to":"20e889ed_38a21221","updated":"2024-01-16 18:43:08.000000000","message":"Wonder if there\u0027s value in maybe checking this in validate, and blowing up unless someone sets node.driver_info[\u0027ilo6_no_redfish\u0027] or similar? If we want to drive people in the direction... drive harder!\n\nI\u0027m +2\u0027ing this as it\u0027s better, and I\u0027d like it to land even if my idea is not preferred.","commit_id":"4e8ed74360333085d44fcbf3255b71caf3414a5a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fd2dadfd1ea4bdc1d65a8af31bdfbc212e0e7b89","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            warn_msg \u003d (\"Node %s appears to have a disabled API \""},{"line_number":89,"context_line":"                        \"required for the \\\u0027%s\\\u0027 hardware type to function. \""},{"line_number":90,"context_line":"                        \"Please consider using the \\\u0027redfish\\\u0027 hardware \""},{"line_number":91,"context_line":"                        \"type.\" % (node.uuid, node.driver))"},{"line_number":92,"context_line":"            manager_utils.node_history_record(node, event\u003dwarn_msg,"},{"line_number":93,"context_line":"                                              event_type\u003dnode.provision_state,"},{"line_number":94,"context_line":"                                              error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f54a61bc_8ab920eb","line":91,"in_reply_to":"3c609913_48e37677","updated":"2024-01-05 14:46:09.000000000","message":"It should get stored to last_error as part of the act of recording the history record.","commit_id":"4e8ed74360333085d44fcbf3255b71caf3414a5a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bd63bdcd8ec5db175634c1b05742607e95406403","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            warn_msg \u003d (\"Node %s appears to have a disabled API \""},{"line_number":89,"context_line":"                        \"required for the \\\u0027%s\\\u0027 hardware type to function. \""},{"line_number":90,"context_line":"                        \"Please consider using the \\\u0027redfish\\\u0027 hardware \""},{"line_number":91,"context_line":"                        \"type.\" % (node.uuid, node.driver))"},{"line_number":92,"context_line":"            manager_utils.node_history_record(node, event\u003dwarn_msg,"},{"line_number":93,"context_line":"                                              event_type\u003dnode.provision_state,"},{"line_number":94,"context_line":"                                              error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"52149399_36b2ab31","line":91,"in_reply_to":"a23debaf_951f86b0","updated":"2024-01-16 19:18:11.000000000","message":"Dunno, I suspect the explicit path is the most direct path, and and aligns with the semi-messaging we seem to be getting from HPE folk.\n\nI\u0027m also unsure how a knob would help, when the RIB interface just doesn\u0027t exist. Dunno.","commit_id":"4e8ed74360333085d44fcbf3255b71caf3414a5a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"079e768b448e298b0cb4ba89e5e1e3b2154d251c","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            warn_msg \u003d (\"Node %s appears to have a disabled API \""},{"line_number":89,"context_line":"                        \"required for the \\\u0027%s\\\u0027 hardware type to function. \""},{"line_number":90,"context_line":"                        \"Please consider using the \\\u0027redfish\\\u0027 hardware \""},{"line_number":91,"context_line":"                        \"type.\" % (node.uuid, node.driver))"},{"line_number":92,"context_line":"            manager_utils.node_history_record(node, event\u003dwarn_msg,"},{"line_number":93,"context_line":"                                              event_type\u003dnode.provision_state,"},{"line_number":94,"context_line":"                                              error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"20e889ed_38a21221","line":91,"in_reply_to":"f54a61bc_8ab920eb","updated":"2024-01-05 14:49:26.000000000","message":"Yeah, but the higher level code catching IloOperationError will probably overwrite last_error nearly instantly.","commit_id":"4e8ed74360333085d44fcbf3255b71caf3414a5a"}],"releasenotes/notes/add-warning-in-ilo-for-ilo6-c400b35f55b81f50.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9235d4917bbb07e67040ffb715e4e7dbadb3a142","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a vauge error when attempting to use the ``ilo`` hardware type with"},{"line_number":5,"context_line":"    iLO6 hardware, by returning a more specific error suggesting action to"},{"line_number":6,"context_line":"    take in order to remedy the issue. Specifically, one of the API\u0027s"},{"line_number":7,"context_line":"    used by the ``ilo`` hardware type is disabled in iLO6 BMCs in favor"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"241cfa4a_d5cf5cba","line":4,"updated":"2024-02-05 11:18:10.000000000","message":"nit: vague","commit_id":"47a67d12454848c394f2ef002e122f61af333369"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3713d3cb3aecb9a42529f696d3ac25732b7cb4e1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a vauge error when attempting to use the ``ilo`` hardware type with"},{"line_number":5,"context_line":"    iLO6 hardware, by returning a more specific error suggesting action to"},{"line_number":6,"context_line":"    take in order to remedy the issue. Specifically, one of the API\u0027s"},{"line_number":7,"context_line":"    used by the ``ilo`` hardware type is disabled in iLO6 BMCs in favor"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6c0d6b93_d46c4d84","line":4,"in_reply_to":"241cfa4a_d5cf5cba","updated":"2024-02-07 20:46:26.000000000","message":"++","commit_id":"47a67d12454848c394f2ef002e122f61af333369"}]}