)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"85c02d06f9caf6036d4dfc858567efc193058755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72508e93_63b2a21d","updated":"2023-07-13 09:29:24.000000000","message":"Thought inline.","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b797fc88ae608f229dceca4041bb0a15b7a5582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c3be524_70ba2471","updated":"2023-07-16 22:00:50.000000000","message":"I\u0027m just going to abandon this in favor of just not heartbeating on sqlite. If anyone disagrees, I won\u0027t abandon this patch in a few days.","commit_id":"d416b927b1ac63b0126bfd7766c353e85b322670"}],"ironic/conductor/base_manager.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"85c02d06f9caf6036d4dfc858567efc193058755","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            except Exception as e:"},{"line_number":455,"context_line":"                LOG.exception(\u0027Error while heartbeating. Error: %(err)s\u0027,"},{"line_number":456,"context_line":"                              {\u0027err\u0027: e})"},{"line_number":457,"context_line":"                if \"database is locked\" in str(e):"},{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"}],"source_content_type":"text/x-python","patch_set":1,"id":"d09b9742_95775698","line":457,"updated":"2023-07-13 09:29:24.000000000","message":"In this case; shouldn\u0027t we not print the exception in line 455? (it\u0027ll save a lot of disk space for people hitting this problem)","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b65acf33217617fb5362d0ab72257dda5df708f9","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            except Exception as e:"},{"line_number":455,"context_line":"                LOG.exception(\u0027Error while heartbeating. Error: %(err)s\u0027,"},{"line_number":456,"context_line":"                              {\u0027err\u0027: e})"},{"line_number":457,"context_line":"                if \"database is locked\" in str(e):"},{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"}],"source_content_type":"text/x-python","patch_set":1,"id":"89062f0f_a52047e9","line":457,"in_reply_to":"1988a1cf_5f56a8e3","updated":"2023-07-13 18:54:03.000000000","message":"So turns out, It seems we can still get lock colissions, although the new area of focus is not generalized periodic workers, but power state sync parallelism. The original first change was a result of looking at the workers spawning but power state not even triggering because there were no nodes yet. Sort of like a few thousand cuts 😊","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2bacde039e3e07fd0b42aa3ba1e975ef8addfa67","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            except Exception as e:"},{"line_number":455,"context_line":"                LOG.exception(\u0027Error while heartbeating. Error: %(err)s\u0027,"},{"line_number":456,"context_line":"                              {\u0027err\u0027: e})"},{"line_number":457,"context_line":"                if \"database is locked\" in str(e):"},{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"}],"source_content_type":"text/x-python","patch_set":1,"id":"1988a1cf_5f56a8e3","line":457,"in_reply_to":"ce852c71_2a528041","updated":"2023-07-13 13:38:54.000000000","message":"Ack","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6a7aa4be634788cab3412339ea61d1affb039f81","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            except Exception as e:"},{"line_number":455,"context_line":"                LOG.exception(\u0027Error while heartbeating. Error: %(err)s\u0027,"},{"line_number":456,"context_line":"                              {\u0027err\u0027: e})"},{"line_number":457,"context_line":"                if \"database is locked\" in str(e):"},{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce852c71_2a528041","line":457,"in_reply_to":"d09b9742_95775698","updated":"2023-07-13 10:54:40.000000000","message":"I\u0027d rather not have these errors go unnoticed. With the parent fix, it should no longer be a normal situation.","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6a7aa4be634788cab3412339ea61d1affb039f81","unresolved":true,"context_lines":[{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"},{"line_number":461,"context_line":"                    # a little further away by adding an extra second."},{"line_number":462,"context_line":"                    self._keepalive_evt.wait(1)"},{"line_number":463,"context_line":"            self._keepalive_evt.wait(CONF.conductor.heartbeat_interval)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b907bd83_51a222b5","line":461,"updated":"2023-07-13 10:54:40.000000000","message":"What if we just retry all database actions on this message? Or at least the ones that are safe to retry?","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b65acf33217617fb5362d0ab72257dda5df708f9","unresolved":true,"context_lines":[{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"},{"line_number":461,"context_line":"                    # a little further away by adding an extra second."},{"line_number":462,"context_line":"                    self._keepalive_evt.wait(1)"},{"line_number":463,"context_line":"            self._keepalive_evt.wait(CONF.conductor.heartbeat_interval)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"afd6f513_2cb1082a","line":461,"in_reply_to":"95868b38_8b2e6b1e","updated":"2023-07-13 18:54:03.000000000","message":"I think we\u0027re going to need to get there, but I don\u0027t think it is going to be an instantaneous jump. It is like a thousand cuts which can cause the train to derail at times. And that being said, I\u0027m sort of treating full blown retry logic as a last resort. We first have to reduce the odds as much as possible, because otherwise we\u0027ll thrash against ourselves.","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2bacde039e3e07fd0b42aa3ba1e975ef8addfa67","unresolved":true,"context_lines":[{"line_number":458,"context_line":"                    # A strong possibility exists lined up with a lot of other"},{"line_number":459,"context_line":"                    # concurrent database transactions in flight due to the"},{"line_number":460,"context_line":"                    # interval and initial process start. So shift us"},{"line_number":461,"context_line":"                    # a little further away by adding an extra second."},{"line_number":462,"context_line":"                    self._keepalive_evt.wait(1)"},{"line_number":463,"context_line":"            self._keepalive_evt.wait(CONF.conductor.heartbeat_interval)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"95868b38_8b2e6b1e","line":461,"in_reply_to":"b907bd83_51a222b5","updated":"2023-07-13 13:38:54.000000000","message":"+++++++++++++++++","commit_id":"8bf0f6f1192be60a16c5e1c1d2ab7b954ccc6b84"}]}