)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aeb7ab143e20e94a9c714ac0d7c2d6c4626731a4","unresolved":true,"context_lines":[{"line_number":1409,"context_line":"        for node_info in nodes:"},{"line_number":1410,"context_line":"            nodes_queue.put(node_info)"},{"line_number":1411,"context_line":"        if utils.is_ironic_using_sqlite():"},{"line_number":1412,"context_line":"            LOG.warning(\u0027Configuration issue with power state sync. \u0027"},{"line_number":1413,"context_line":"                        \u0027The [conductor]sync_power_state_workers \u0027"},{"line_number":1414,"context_line":"                        \u0027configuration is set to %s, but the database \u0027"},{"line_number":1415,"context_line":"                        \u0027backend is currently configured for sqlite. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2467d52f_a5a0439b","line":1412,"updated":"2023-07-14 08:04:48.000000000","message":"Let\u0027s make sure to log this only once, maybe in __init__","commit_id":"8478e17d3379580365ad26c73e24cec718282c12"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aeb7ab143e20e94a9c714ac0d7c2d6c4626731a4","unresolved":true,"context_lines":[{"line_number":1420,"context_line":"            # the high level of concurrency multiple workers sets up,"},{"line_number":1421,"context_line":"            # as the first worker may get a write lock, and may be"},{"line_number":1422,"context_line":"            # mid-flight with the work item, and that can then spiral"},{"line_number":1423,"context_line":"            # out of control."},{"line_number":1424,"context_line":"            number_of_workers \u003d 1"},{"line_number":1425,"context_line":"        else:"},{"line_number":1426,"context_line":"            number_of_workers \u003d min("}],"source_content_type":"text/x-python","patch_set":1,"id":"6a793d8c_3eabb80f","line":1423,"updated":"2023-07-14 08:04:48.000000000","message":"Is it something we cannot really solve with dbapi-level retries? My worry is: most of the time the power sync loop does not write to the database. We\u0027re severely reducing scalability for a pretty marginal case.","commit_id":"8478e17d3379580365ad26c73e24cec718282c12"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c431558f2684c7f5598a47a806b0741713ee33ee","unresolved":true,"context_lines":[{"line_number":1420,"context_line":"            # the high level of concurrency multiple workers sets up,"},{"line_number":1421,"context_line":"            # as the first worker may get a write lock, and may be"},{"line_number":1422,"context_line":"            # mid-flight with the work item, and that can then spiral"},{"line_number":1423,"context_line":"            # out of control."},{"line_number":1424,"context_line":"            number_of_workers \u003d 1"},{"line_number":1425,"context_line":"        else:"},{"line_number":1426,"context_line":"            number_of_workers \u003d min("}],"source_content_type":"text/x-python","patch_set":1,"id":"e6c3eaab_1e061353","line":1423,"in_reply_to":"6a793d8c_3eabb80f","updated":"2023-07-18 18:22:40.000000000","message":"Well, we shouldn\u0027t be putting ourselves in the situation to begin with if we can help it. Then again, I do agree with reducing scalability and I personally don\u0027t like it. The challenge here is we know from experience the ipmitool command execution can take a while, which worsens the condition/state overall. That being said, we likely only ever need to retry just once. With that in mind, I\u0027m going to abandon this patch, even though this is the most likely place for locking to impact us from the logs I\u0027ve looked at.","commit_id":"8478e17d3379580365ad26c73e24cec718282c12"}]}
