)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5e62c481b0bb0060e77882624832ef392ac275b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84bf0b1e_8b079671","updated":"2023-08-18 17:04:26.000000000","message":"I agree with Dmitry that I\u0027d rather keep the parallelism of being able to use name and uuid everywhere, unless there\u0027s a compelling technical or performance reason not to.","commit_id":"7d238bd6e5dbf8ce96bf944f85689bd19a3470b2"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"cdb72f51cfe178abb112088b02978d1629ea15c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69c938a4_38afc16c","updated":"2023-08-21 08:18:23.000000000","message":"ilorecheck","commit_id":"7d238bd6e5dbf8ce96bf944f85689bd19a3470b2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d4740d325667f245a3bec1931bfadf670e8182c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f8f4bd8_e448ae44","in_reply_to":"84bf0b1e_8b079671","updated":"2023-09-05 16:26:05.000000000","message":"How do y\u0027all feel if we lookup anything that is not ID\u0027s, and then convert the value saved on the post to UUIDs ?","commit_id":"7d238bd6e5dbf8ce96bf944f85689bd19a3470b2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"07a724a9548f50b3e7245414548b95aa7d43d64b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"755e7f02_99baaa52","in_reply_to":"9f8f4bd8_e448ae44","updated":"2023-09-05 16:28:46.000000000","message":"this is basically what I wanted anyway 😊 ... API support for names; keep UUIDs in the DB","commit_id":"7d238bd6e5dbf8ce96bf944f85689bd19a3470b2"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e7ad6f133a5cb64165461e6b2eba04ffdbe06b08","unresolved":true,"context_lines":[{"line_number":2770,"context_line":"                        \"Requested value was invalid.\")"},{"line_number":2771,"context_line":"                raise exception.Invalid(msg)"},{"line_number":2772,"context_line":"            if not uuidutils.is_uuid_like(parent_node):"},{"line_number":2773,"context_line":"                corrected_values[\u0027parent_node\u0027] \u003d parent_node.uuid"},{"line_number":2774,"context_line":"        return corrected_values"},{"line_number":2775,"context_line":""},{"line_number":2776,"context_line":"    def _authorize_patch_and_get_node(self, node_ident, patch):"}],"source_content_type":"text/x-python","patch_set":4,"id":"860e94f3_6386812a","line":2773,"updated":"2023-10-01 22:20:49.000000000","message":"parent_node might be a string or an object at this point, that doesn\u0027t seem right?","commit_id":"25ca89bd8dc73e4838ca8f8ccd1cf272b8b4b423"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14381c3a545b463c2a5e43eb164f6065ca074939","unresolved":false,"context_lines":[{"line_number":2770,"context_line":"                        \"Requested value was invalid.\")"},{"line_number":2771,"context_line":"                raise exception.Invalid(msg)"},{"line_number":2772,"context_line":"            if not uuidutils.is_uuid_like(parent_node):"},{"line_number":2773,"context_line":"                corrected_values[\u0027parent_node\u0027] \u003d parent_node.uuid"},{"line_number":2774,"context_line":"        return corrected_values"},{"line_number":2775,"context_line":""},{"line_number":2776,"context_line":"    def _authorize_patch_and_get_node(self, node_ident, patch):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa3ebe4c_77f1dace","line":2773,"in_reply_to":"5e8d948f_00e2f7c4","updated":"2023-10-10 13:06:24.000000000","message":"Done","commit_id":"25ca89bd8dc73e4838ca8f8ccd1cf272b8b4b423"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a686a0b5090621a0f863c18e06b4f659903e881","unresolved":true,"context_lines":[{"line_number":2770,"context_line":"                        \"Requested value was invalid.\")"},{"line_number":2771,"context_line":"                raise exception.Invalid(msg)"},{"line_number":2772,"context_line":"            if not uuidutils.is_uuid_like(parent_node):"},{"line_number":2773,"context_line":"                corrected_values[\u0027parent_node\u0027] \u003d parent_node.uuid"},{"line_number":2774,"context_line":"        return corrected_values"},{"line_number":2775,"context_line":""},{"line_number":2776,"context_line":"    def _authorize_patch_and_get_node(self, node_ident, patch):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5e8d948f_00e2f7c4","line":2773,"in_reply_to":"860e94f3_6386812a","updated":"2023-10-06 19:14:03.000000000","message":"Yeah, let me clean this up to be a bit more delineated.. and I\u0027ve realized this is redundant.","commit_id":"25ca89bd8dc73e4838ca8f8ccd1cf272b8b4b423"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b62e122d62e9355a6e241a7d188e6d639b8fd210","unresolved":true,"context_lines":[{"line_number":2761,"context_line":"            validate_network_data(network_data)"},{"line_number":2762,"context_line":"        parent_node \u003d api_utils.get_patch_values(patch, \u0027/parent_node\u0027)"},{"line_number":2763,"context_line":"        if parent_node:"},{"line_number":2764,"context_line":"            # At this point, if ther *is* a parent_node, there is a value"},{"line_number":2765,"context_line":"            # in the patch value list."},{"line_number":2766,"context_line":"            try:"},{"line_number":2767,"context_line":"                # Verify we can see the parent node"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f1466db_d89ba930","line":2764,"range":{"start_line":2764,"start_character":32,"end_line":2764,"end_character":36},"updated":"2023-10-10 07:28:09.000000000","message":"nit: there","commit_id":"7f9188a31dbbd8345ca307262c59bd36e2dee35d"}],"ironic/tests/unit/api/controllers/v1/test_node.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cbff642c9b617713bfeea96a147ffe9f135332b3","unresolved":true,"context_lines":[{"line_number":8419,"context_line":"            \u0027/nodes\u0027, ndict, expect_errors\u003dTrue, headers\u003dheaders)"},{"line_number":8420,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, response.status_int)"},{"line_number":8421,"context_line":""},{"line_number":8422,"context_line":"    def test_create_node_with_named_parent_node_succeds(self):"},{"line_number":8423,"context_line":"        ndict \u003d test_api_utils.post_get_test_node("},{"line_number":8424,"context_line":"            uuid\u003duuidutils.generate_uuid())"},{"line_number":8425,"context_line":"        ndict[\u0027parent_node\u0027] \u003d \u0027din\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3d5f987_d0509c36","line":8422,"updated":"2023-09-27 20:42:22.000000000","message":"nit: succeeds","commit_id":"4057c6afc6a8318d58c8a701ea5edb4f901e5506"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"89562db1e50642cd37e075bbfb9ebc0dd2e487fc","unresolved":false,"context_lines":[{"line_number":8419,"context_line":"            \u0027/nodes\u0027, ndict, expect_errors\u003dTrue, headers\u003dheaders)"},{"line_number":8420,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, response.status_int)"},{"line_number":8421,"context_line":""},{"line_number":8422,"context_line":"    def test_create_node_with_named_parent_node_succeds(self):"},{"line_number":8423,"context_line":"        ndict \u003d test_api_utils.post_get_test_node("},{"line_number":8424,"context_line":"            uuid\u003duuidutils.generate_uuid())"},{"line_number":8425,"context_line":"        ndict[\u0027parent_node\u0027] \u003d \u0027din\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"0bb13d63_4c39067e","line":8422,"in_reply_to":"c3d5f987_d0509c36","updated":"2023-09-28 16:22:24.000000000","message":"Done.","commit_id":"4057c6afc6a8318d58c8a701ea5edb4f901e5506"}]}