)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27418,"name":"Mallikarjuna Reddy Kolagatla","email":"mallikarjuna.reddy@hpe.com","username":"mallikarjuna.kolagatla"},"change_message_id":"022e0e57e309b5694f429bb67d74fe2c5838ec72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fc4e8d97_08a25399","updated":"2023-08-23 05:17:39.000000000","message":"ilorecheck","commit_id":"a81f7f2df63b9f8f0adddfeb490731041c8320b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d5e4c5b286eb42fa8fac22e190e5dc39bab0bb61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2cb31e38_0b76ac0e","updated":"2023-08-23 18:16:55.000000000","message":"Based on the existence of https://review.opendev.org/c/openstack/ironic/+/503744, I strongly suspect our existing BFV docs are wrong; but I\u0027d still rather handle that separately.","commit_id":"21f2ef6fd595abeb1f1f7098dfa9dcf4e7150fec"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"13420b5a4f4190cd2de2820fb7803037b6481b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b86f61fd_ba5c90bb","updated":"2023-08-23 21:54:09.000000000","message":"Incoming patchset has some improvements to the developer documentation section overall, since it needed a rework not just those comments answered.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5d320a5b_c0da2276","updated":"2023-08-23 20:58:30.000000000","message":"some first comments and questions, not all directly related to your patch","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64e050c009e2a930e59d17d40af4eb6922c4e757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0dbfdf56_03a86cd0","updated":"2023-08-23 22:15:20.000000000","message":"Missed a couple comments in my last update; fixing and responding.","commit_id":"0acfc87b808352fbf8d520f35b9a5d6fb32250e4"},{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"a0b740bb79fdceba3874f24eb88205d5a0a28ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a5eff61_d7727ef1","updated":"2023-08-24 11:09:26.000000000","message":"All looks great to me, I\u0027ve learn some stuff I didn\u0027t know while reviewing","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2f6681e99ccbc2f1a2801f29d29bc2ab55b5c915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"45b044c6_452a5981","updated":"2023-08-29 02:58:33.000000000","message":"Thank you for revamping this","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ebf0ce576639869071ebbc56251e92e14ff77568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6e0679ed_f74df761","updated":"2023-08-24 09:15:44.000000000","message":"thanks!\nThere\u0027s still huge margin for cleanup in follow ups but I think this is ok","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"}],"doc/source/contributor/bifrost-dev-guide.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Bifrost Dev Guide"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Bifrost is a project that deploys and operates Ironic using ansible. It is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4cb97c78_9789191c","line":2,"updated":"2023-08-23 20:58:30.000000000","message":"I would spell out \"Developer\" here for easy of reading","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64e050c009e2a930e59d17d40af4eb6922c4e757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Bifrost Dev Guide"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Bifrost is a project that deploys and operates Ironic using ansible. It is"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c8cb206b_a31d84af","line":2,"in_reply_to":"4cb97c78_9789191c","updated":"2023-08-23 22:15:20.000000000","message":"Done","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"}],"doc/source/contributor/dev-quickstart.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":15,"context_line":"team organizes work, please see `Ironic\u0027s contribution guide \u003chttps://docs.openstack.org/ironic/latest/contributor/contributing.html\u003e`_."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This document covers both :ref:`unit` and :ref:`integrated`. New contributors"},{"line_number":18,"context_line":"are recommended to start with unit tests."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":".. _integrated:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d5626770_db4c15ee","line":18,"updated":"2023-08-23 20:58:30.000000000","message":"Maybe then also have the unit tests first in what follows?","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"team organizes work, please see `Ironic\u0027s contribution guide \u003chttps://docs.openstack.org/ironic/latest/contributor/contributing.html\u003e`_."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This document covers both :ref:`unit` and :ref:`integrated`. New contributors"},{"line_number":18,"context_line":"are recommended to start with unit tests."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":".. _integrated:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"e464296f_3fb5b54f","line":18,"in_reply_to":"d5626770_db4c15ee","updated":"2023-08-23 21:48:29.000000000","message":"I rearranged it because the testing environments table was getting completely lost in the massive amount of detail about unit tests. I\u0027d rather keep it this way or move the detailed unit test information to a different page (like I did with integrated environment detail).","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Ubuntu/Debian::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    sudo apt-get install build-essential python3-dev libssl-dev python3-pip libmysqlclient-dev libxml2-dev libxslt-dev libpq-dev git git-review libffi-dev gettext ipmitool psmisc graphviz libjpeg-dev"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- RHEL/CentOS/Fedora::"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"82c0e38e_c8e8c562","line":77,"range":{"start_line":77,"start_character":76,"end_line":77,"end_character":94},"updated":"2023-08-23 20:58:30.000000000","message":"Debian bookworm no longer has this. See e.g. https://review.opendev.org/c/openstack/neutron/+/892142/1/bindep.txt","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Ubuntu/Debian::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    sudo apt-get install build-essential python3-dev libssl-dev python3-pip libmysqlclient-dev libxml2-dev libxslt-dev libpq-dev git git-review libffi-dev gettext ipmitool psmisc graphviz libjpeg-dev"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- RHEL/CentOS/Fedora::"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d66582d2_b1ebda54","line":77,"range":{"start_line":77,"start_character":76,"end_line":77,"end_character":94},"in_reply_to":"82c0e38e_c8e8c562","updated":"2023-08-23 21:48:29.000000000","message":"I\u0027ve intentionally not modified this section of the code, only moved it around. I will reserve fixing these issues for a future patch that is smaller in size. (The entire system/python prerequisites here I\u0027ve been tempted multiple times to just delete; but they exist so some folks must find them valuable)\n\nMoving forward, I suspect we\u0027ll be better off to direct users to bindep/bindep.txt instead of listing these deps in multiple places.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64e050c009e2a930e59d17d40af4eb6922c4e757","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Ubuntu/Debian::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    sudo apt-get install build-essential python3-dev libssl-dev python3-pip libmysqlclient-dev libxml2-dev libxslt-dev libpq-dev git git-review libffi-dev gettext ipmitool psmisc graphviz libjpeg-dev"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- RHEL/CentOS/Fedora::"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"0dcb7e82_a46a6d86","line":77,"range":{"start_line":77,"start_character":76,"end_line":77,"end_character":94},"in_reply_to":"d66582d2_b1ebda54","updated":"2023-08-23 22:15:20.000000000","message":"To make this more clear, I added to the commit message that the System / Python preqrequisites sections were mostly untouched and will be cleaned in a followup.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":87,"context_line":"To run the tests locally, it is a requirement that your terminal emulator"},{"line_number":88,"context_line":"supports unicode with the ``en_US.UTF8`` locale. If you use locale-gen to"},{"line_number":89,"context_line":"manage your locales, make sure you have enabled ``en_US.UTF8`` in"},{"line_number":90,"context_line":"``/etc/locale.gen`` and rerun ``locale-gen``."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Python Prerequisites"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dad4aea7_07e2931c","line":90,"updated":"2023-08-23 20:58:30.000000000","message":"Where exactly does the locale requirement come into play? Could it be replaced with a more generic C.UTF-8?\n\nAlso I think it is en_US.UTF-8?","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":87,"context_line":"To run the tests locally, it is a requirement that your terminal emulator"},{"line_number":88,"context_line":"supports unicode with the ``en_US.UTF8`` locale. If you use locale-gen to"},{"line_number":89,"context_line":"manage your locales, make sure you have enabled ``en_US.UTF8`` in"},{"line_number":90,"context_line":"``/etc/locale.gen`` and rerun ``locale-gen``."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Python Prerequisites"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"72f9239e_916f2c0a","line":90,"in_reply_to":"dad4aea7_07e2931c","updated":"2023-08-23 21:48:29.000000000","message":"I\u0027m pretty sure this was written before C.UTF-8 was in general use. Again, we should clean this area up (and probably simplify simplify simplify!) but I\u0027m mainly moving things around to allow fixing the devstack configs.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"If you haven\u0027t already, Ironic source code should be pulled directly from git::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # from your home or source directory"},{"line_number":116,"context_line":"    git clone https://opendev.org/openstack/ironic"},{"line_number":117,"context_line":"    cd ironic"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"577b66c8_3d595f4c","line":115,"updated":"2023-08-23 20:58:30.000000000","message":"actually the directory doesn\u0027t matter much, it just needs to be writeable by the user","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"13420b5a4f4190cd2de2820fb7803037b6481b7c","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"If you haven\u0027t already, Ironic source code should be pulled directly from git::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # from your home or source directory"},{"line_number":116,"context_line":"    git clone https://opendev.org/openstack/ironic"},{"line_number":117,"context_line":"    cd ironic"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"6a0607c8_0af47a77","line":115,"in_reply_to":"19dc9e5c_f8869d4a","updated":"2023-08-23 21:54:09.000000000","message":"I fixed it anyway :D","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"If you haven\u0027t already, Ironic source code should be pulled directly from git::"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    # from your home or source directory"},{"line_number":116,"context_line":"    git clone https://opendev.org/openstack/ironic"},{"line_number":117,"context_line":"    cd ironic"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"19dc9e5c_f8869d4a","line":115,"in_reply_to":"577b66c8_3d595f4c","updated":"2023-08-23 21:48:29.000000000","message":"Leaving this untouched for reasons mentioned before.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":132,"context_line":"  * - Environment"},{"line_number":133,"context_line":"    - Description"},{"line_number":134,"context_line":"  * - pep8"},{"line_number":135,"context_line":"    - Run style checks on code."},{"line_number":136,"context_line":"  * - py\u003cversion\u003e"},{"line_number":137,"context_line":"    - Run unit tests with the specified python version. For example, ``py310`` will run the unit tests with python 3.10."},{"line_number":138,"context_line":"  * - unit-with-driver-libs"}],"source_content_type":"text/x-rst","patch_set":6,"id":"615e3922_1e1ed49e","line":135,"updated":"2023-08-23 20:58:30.000000000","message":"Nit: also on docs and renos.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"64e050c009e2a930e59d17d40af4eb6922c4e757","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  * - Environment"},{"line_number":133,"context_line":"    - Description"},{"line_number":134,"context_line":"  * - pep8"},{"line_number":135,"context_line":"    - Run style checks on code."},{"line_number":136,"context_line":"  * - py\u003cversion\u003e"},{"line_number":137,"context_line":"    - Run unit tests with the specified python version. For example, ``py310`` will run the unit tests with python 3.10."},{"line_number":138,"context_line":"  * - unit-with-driver-libs"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0218fdb3_ea21289c","line":135,"in_reply_to":"615e3922_1e1ed49e","updated":"2023-08-23 22:15:20.000000000","message":"I\u0027m not sure I knew this before now :) I always just ran -edocs/-ereleasenotes when I was authoring/changing one :D","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":206,"context_line":"- On your local machine::"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # activate your development virtualenv"},{"line_number":209,"context_line":"    . .tox/venv/bin/activate"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    # build the docs"},{"line_number":212,"context_line":"    tox -edocs"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ce4b2d8d_233b8f6a","line":209,"updated":"2023-08-23 20:58:30.000000000","message":"You\u0027ve removed the venv setup above, so this is dangling","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"13420b5a4f4190cd2de2820fb7803037b6481b7c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"- On your local machine::"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # activate your development virtualenv"},{"line_number":209,"context_line":"    . .tox/venv/bin/activate"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    # build the docs"},{"line_number":212,"context_line":"    tox -edocs"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e44d9418_bd122b65","line":209,"in_reply_to":"9729d31a_f5cdf5e3","updated":"2023-08-23 21:54:09.000000000","message":"Done","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":206,"context_line":"- On your local machine::"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # activate your development virtualenv"},{"line_number":209,"context_line":"    . .tox/venv/bin/activate"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    # build the docs"},{"line_number":212,"context_line":"    tox -edocs"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9729d31a_f5cdf5e3","line":209,"in_reply_to":"ce4b2d8d_233b8f6a","updated":"2023-08-23 21:48:29.000000000","message":"I\u0027ll put a fix here since I broke it","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    #Now use your browser to open the top-level index.html located at:"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    ironic/doc/build/html/index.html"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- On a remote machine::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"47b786b8_6ce159a7","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":11},"updated":"2023-08-23 20:58:30.000000000","message":"you usually call tox from within the ironic dir, so the \"ironic\" here is too much","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    #Now use your browser to open the top-level index.html located at:"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    ironic/doc/build/html/index.html"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- On a remote machine::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e8353efe_c8d6f605","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":11},"in_reply_to":"47b786b8_6ce159a7","updated":"2023-08-23 21:48:29.000000000","message":"This is badly broken, so I\u0027ll fix it next patchset.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"13420b5a4f4190cd2de2820fb7803037b6481b7c","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    #Now use your browser to open the top-level index.html located at:"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    ironic/doc/build/html/index.html"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- On a remote machine::"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b4c25c56_619d1204","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":11},"in_reply_to":"e8353efe_c8d6f605","updated":"2023-08-23 21:54:09.000000000","message":"Done","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0412c647a8d25f92186968318bf241e450776c0f","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    cd ~/ironic/doc/source/"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # Build the docs"},{"line_number":225,"context_line":"    tox -edocs"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # Change directory to the newly built HTML files"},{"line_number":228,"context_line":"    cd ~/ironic/doc/build/html/"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a33215c0_299be14c","line":225,"updated":"2023-08-23 20:58:30.000000000","message":"this should run in ~/ironic only?","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"13420b5a4f4190cd2de2820fb7803037b6481b7c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    cd ~/ironic/doc/source/"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # Build the docs"},{"line_number":225,"context_line":"    tox -edocs"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # Change directory to the newly built HTML files"},{"line_number":228,"context_line":"    cd ~/ironic/doc/build/html/"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0b14afad_add31ce5","line":225,"in_reply_to":"52a9acfa_ed4f4be9","updated":"2023-08-23 21:54:09.000000000","message":"Done","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e65cfc3f14ef5592dcbb2e4a7de64a772a53a8a","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    cd ~/ironic/doc/source/"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # Build the docs"},{"line_number":225,"context_line":"    tox -edocs"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    # Change directory to the newly built HTML files"},{"line_number":228,"context_line":"    cd ~/ironic/doc/build/html/"}],"source_content_type":"text/x-rst","patch_set":6,"id":"52a9acfa_ed4f4be9","line":225,"in_reply_to":"a33215c0_299be14c","updated":"2023-08-23 21:48:29.000000000","message":"This is badly broken, so I\u0027ll fix it next patchset.","commit_id":"c36d0b4d41f9aeb65d9499ddac7ad5cfe042a8e5"}],"doc/source/contributor/devstack-guide.rst":[{"author":{"_account_id":35099,"name":"Jakub Jelinek","email":"jakub.jelinek@cern.ch","username":"kubajj"},"change_message_id":"a0b740bb79fdceba3874f24eb88205d5a0a28ead","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* :ref:`Ironic Boot from Volume \u003cBFVDevstack\u003e`"},{"line_number":268,"context_line":"* :ref:`Ironic w/Multitenant Networking \u003cDevstackMTNetwork\u003e`"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Deploying to Ironic node using Nova"},{"line_number":271,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"30531bea_27b4cfd2","line":269,"updated":"2023-08-24 11:09:26.000000000","message":"Should we include a configuration allowing DIB IPA? When I was working on IPA last summer, something like that would save me a lot of time.","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2f6681e99ccbc2f1a2801f29d29bc2ab55b5c915","unresolved":true,"context_lines":[{"line_number":467,"context_line":"\"Download\" button in Gerrit. You can also specify a different git repo, or"},{"line_number":468,"context_line":"a branch or tag::"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"      enable_plugin ironic https://github.com/openstack/ironic stable/kilo"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"For more details, see the"},{"line_number":473,"context_line":"`devstack plugin interface documentation"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b1756fe5_a38f2515","line":470,"range":{"start_line":470,"start_character":70,"end_line":470,"end_character":74},"updated":"2023-08-29 02:58:33.000000000","message":"ah kilo, haven\u0027t heard that name in a while","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"}],"doc/source/contributor/local-dev-guide.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ebf0ce576639869071ebbc56251e92e14ff77568","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Step 2: Install System Dependencies Locally"},{"line_number":55,"context_line":"--------------------------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This step will install MySQL on your local system. This may not be desirable"},{"line_number":58,"context_line":"in some situations (eg, you\u0027re developing from a laptop and do not want to run"},{"line_number":59,"context_line":"a MySQL server on it all the time). If you want to use SQLite, skip it and do"},{"line_number":60,"context_line":"not set the ``connection`` option."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#. Install mysql-server:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b728c3c5_23942343","line":59,"range":{"start_line":57,"start_character":51,"end_line":59,"end_character":36},"updated":"2023-08-24 09:15:44.000000000","message":"maybe suggest to explore mysql/mariadb containers instead ?","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4a13b8e68594105085ae013a955a4280181c0794","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Step 2: Install System Dependencies Locally"},{"line_number":55,"context_line":"--------------------------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This step will install MySQL on your local system. This may not be desirable"},{"line_number":58,"context_line":"in some situations (eg, you\u0027re developing from a laptop and do not want to run"},{"line_number":59,"context_line":"a MySQL server on it all the time). If you want to use SQLite, skip it and do"},{"line_number":60,"context_line":"not set the ``connection`` option."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"#. Install mysql-server:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9d0d5f6e_6404af46","line":59,"range":{"start_line":57,"start_character":51,"end_line":59,"end_character":36},"in_reply_to":"b728c3c5_23942343","updated":"2023-08-24 17:38:09.000000000","message":"This is in the system dependencies section that is explicitly outta scope for this change.","commit_id":"03b8f4dd119f19cd4e9b76616f52e8b370769350"}]}