)]}'
{"ironic/tests/db/test_nodes.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"85e2a683700de5e6f5c4d213619163f89ce5d6cd","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                 instance_uuid\u003dironic_utils.generate_uuid(),"},{"line_number":124,"context_line":"                                 reservation\u003d\u0027fake-host\u0027,"},{"line_number":125,"context_line":"                                 uuid\u003dironic_utils.generate_uuid(),"},{"line_number":126,"context_line":"                                 provision_state\u003dstates.POWER_ON)"},{"line_number":127,"context_line":"        n2 \u003d utils.get_test_node(id\u003d2, driver\u003d\u0027driver-two\u0027,"},{"line_number":128,"context_line":"                                 uuid\u003dironic_utils.generate_uuid(),"},{"line_number":129,"context_line":"                                 maintenance\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FX2c%3D","line":126,"updated":"2014-04-22 08:47:37.000000000","message":"states.POWER_ON is power state, not provision_state.","commit_id":"23111dff36b895896497dc27ea818143322463bf"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"85e2a683700de5e6f5c4d213619163f89ce5d6cd","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        n2 \u003d utils.get_test_node(id\u003d2, driver\u003d\u0027driver-two\u0027,"},{"line_number":128,"context_line":"                                 uuid\u003dironic_utils.generate_uuid(),"},{"line_number":129,"context_line":"                                 maintenance\u003dTrue,"},{"line_number":130,"context_line":"                                 provision_state\u003dstates.POWER_OFF)"},{"line_number":131,"context_line":"        self.dbapi.create_node(n1)"},{"line_number":132,"context_line":"        self.dbapi.create_node(n2)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FX2Y%3D","line":130,"updated":"2014-04-22 08:47:37.000000000","message":"ditto","commit_id":"23111dff36b895896497dc27ea818143322463bf"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"1e5ceab739c9c287aaae3c326e1b8fa7afb2cf82","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        n2 \u003d utils.get_test_node(id\u003d2, driver\u003d\u0027driver-two\u0027,"},{"line_number":128,"context_line":"                                 uuid\u003dironic_utils.generate_uuid(),"},{"line_number":129,"context_line":"                                 maintenance\u003dTrue,"},{"line_number":130,"context_line":"                                 provision_state\u003dstates.POWER_OFF)"},{"line_number":131,"context_line":"        self.dbapi.create_node(n1)"},{"line_number":132,"context_line":"        self.dbapi.create_node(n2)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FOR4%3D","line":130,"in_reply_to":"AAAAXH%2F%2FX2Y%3D","updated":"2014-04-23 08:23:04.000000000","message":"Ok, I can change them.  it actually doesn\u0027t matter what it is for the tests. I could reasonably just use \u0027fake\u0027 or any string.","commit_id":"23111dff36b895896497dc27ea818143322463bf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bdb35d5b22ff929adf0f4e103b808e633a6ff017","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        res \u003d self.dbapi.get_node_list(filters\u003d{\u0027maintenance\u0027: False})"},{"line_number":156,"context_line":"        self.assertEqual([1], [r.id for r in res])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        res \u003d self.dbapi.get_node_list("},{"line_number":159,"context_line":"                filters\u003d{\u0027provision_state\u0027: states.POWER_ON})"},{"line_number":160,"context_line":"        self.assertEqual([1], [r.id for r in res])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FXPc%3D","line":157,"updated":"2014-04-22 09:48:36.000000000","message":"Apart from the problem that Yuriy pointed out with the power states... I also think that this test method is super overwhelming, it would be better to have a test method for each filter so when things fail we will know which one actually failed instead of having all the filters being tested in one single method.\n\nI know that the tests above is not part of your patch (and if you prefer could be split in a following review) But at least could we start separating the provision_state filter here?","commit_id":"23111dff36b895896497dc27ea818143322463bf"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"1e5ceab739c9c287aaae3c326e1b8fa7afb2cf82","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        res \u003d self.dbapi.get_node_list(filters\u003d{\u0027maintenance\u0027: False})"},{"line_number":156,"context_line":"        self.assertEqual([1], [r.id for r in res])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        res \u003d self.dbapi.get_node_list("},{"line_number":159,"context_line":"                filters\u003d{\u0027provision_state\u0027: states.POWER_ON})"},{"line_number":160,"context_line":"        self.assertEqual([1], [r.id for r in res])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FORY%3D","line":157,"in_reply_to":"AAAAXH%2F%2FXPc%3D","updated":"2014-04-23 08:23:04.000000000","message":"It\u0027s easy to see what failed by the line number. :)  But sure, I can split these new ones out.","commit_id":"23111dff36b895896497dc27ea818143322463bf"}]}