)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b37d698a262738e75389024dca1c5f5517278bd5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"So Redfish driver\u0027s logic around disk should be provided"},{"line_number":16,"context_line":"through Storage resource with SimpleStorage compatibility."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This commit does 2 things"},{"line_number":19,"context_line":"* Use Storage resource instead of SimpleStorage, if possible"},{"line_number":20,"context_line":"* Fix wrong disk indicator LED logic (SimpleStorage doesn\u0027t"},{"line_number":21,"context_line":"  support indicator LED operation)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f995a007_d3c9599a","line":18,"updated":"2023-08-23 13:40:46.000000000","message":"nit: I\u0027d prefer 2 commits then","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"99b929c7dcc8d1c8a3b789dd93d2bb5a076a4bdb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"So Redfish driver\u0027s logic around disk should be provided"},{"line_number":16,"context_line":"through Storage resource with SimpleStorage compatibility."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This commit does 2 things"},{"line_number":19,"context_line":"* Use Storage resource instead of SimpleStorage, if possible"},{"line_number":20,"context_line":"* Fix wrong disk indicator LED logic (SimpleStorage doesn\u0027t"},{"line_number":21,"context_line":"  support indicator LED operation)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ac63b6c4_dd170949","line":18,"in_reply_to":"f995a007_d3c9599a","updated":"2023-08-24 11:41:55.000000000","message":"It\u0027s hard to separate to 2 commits. Because both things are connected and cannot be separated.","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b83bfd640dfc1c821a5dc53ce592e7301a3b10ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64440b50_f8f63b81","updated":"2023-10-06 19:37:32.000000000","message":"recheck grenade job fixed","commit_id":"ffde150aa7069b1e70540a2ab6f49a62a0853454"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b37d698a262738e75389024dca1c5f5517278bd5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vanou) Because of PEP8 C901, we need to put operation of both"},{"line_number":138,"context_line":"        # storage and simple_storage into one if branch"},{"line_number":139,"context_line":"        if storages :\u003d system.storage or system.simple_storage:"},{"line_number":140,"context_line":"            storage_list \u003d storages.get_members()"},{"line_number":141,"context_line":"            disks \u003d list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"95e3d250_d3132c95","line":138,"updated":"2023-08-23 13:40:46.000000000","message":"nit: I\u0027d avoid commenting on Python syntax, comments are for clarifying the design or implementation, not your syntax choice.","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"99b929c7dcc8d1c8a3b789dd93d2bb5a076a4bdb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vanou) Because of PEP8 C901, we need to put operation of both"},{"line_number":138,"context_line":"        # storage and simple_storage into one if branch"},{"line_number":139,"context_line":"        if storages :\u003d system.storage or system.simple_storage:"},{"line_number":140,"context_line":"            storage_list \u003d storages.get_members()"},{"line_number":141,"context_line":"            disks \u003d list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"74aa1c25_2c739ed9","line":138,"in_reply_to":"95e3d250_d3132c95","updated":"2023-08-24 11:41:55.000000000","message":"Thanks","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b37d698a262738e75389024dca1c5f5517278bd5","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vanou) Because of PEP8 C901, we need to put operation of both"},{"line_number":138,"context_line":"        # storage and simple_storage into one if branch"},{"line_number":139,"context_line":"        if storages :\u003d system.storage or system.simple_storage:"},{"line_number":140,"context_line":"            storage_list \u003d storages.get_members()"},{"line_number":141,"context_line":"            disks \u003d list()"},{"line_number":142,"context_line":"            for storage in storage_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a17f8d29_3167d625","line":139,"updated":"2023-08-23 13:40:46.000000000","message":"You have a repeated pattern here converting storage or simple_storage to boolean, probably expecting them to be None. I don\u0027t think it\u0027s possible: the properties always return a collection, it will never evaluate to False. It may raise an exception though.","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"99b929c7dcc8d1c8a3b789dd93d2bb5a076a4bdb","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vanou) Because of PEP8 C901, we need to put operation of both"},{"line_number":138,"context_line":"        # storage and simple_storage into one if branch"},{"line_number":139,"context_line":"        if storages :\u003d system.storage or system.simple_storage:"},{"line_number":140,"context_line":"            storage_list \u003d storages.get_members()"},{"line_number":141,"context_line":"            disks \u003d list()"},{"line_number":142,"context_line":"            for storage in storage_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"390cb47e_a6c910e1","line":139,"in_reply_to":"a17f8d29_3167d625","updated":"2023-08-24 11:41:55.000000000","message":"I don\u0027t expect it to become boolean. I expect them to be dict.\nWhen Redfish implementation doesn\u0027t support Storage or SimpleStorage, corresponding attribute becomes dict with no element.\nDict with content is treated like True and, without content, be treated like False.","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b37d698a262738e75389024dca1c5f5517278bd5","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        sensors \u003d {}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if system.storage:"},{"line_number":445,"context_line":"            for storage in system.storage.get_members():"},{"line_number":446,"context_line":"                for drive in storage.drives:"},{"line_number":447,"context_line":"                    sensor \u003d cls._sensor2dict("},{"line_number":448,"context_line":"                        drive, \u0027name\u0027, \u0027model\u0027, \u0027capacity_bytes\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2981d9a6_7d5d39cb","line":445,"updated":"2023-08-23 13:40:46.000000000","message":"nit: maybe use the same hasattr approach as in inspection?","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"99b929c7dcc8d1c8a3b789dd93d2bb5a076a4bdb","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        sensors \u003d {}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if system.storage:"},{"line_number":445,"context_line":"            for storage in system.storage.get_members():"},{"line_number":446,"context_line":"                for drive in storage.drives:"},{"line_number":447,"context_line":"                    sensor \u003d cls._sensor2dict("},{"line_number":448,"context_line":"                        drive, \u0027name\u0027, \u0027model\u0027, \u0027capacity_bytes\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"21a676db_0eb5e3be","line":445,"in_reply_to":"2981d9a6_7d5d39cb","updated":"2023-08-24 11:41:55.000000000","message":"Done","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"}],"releasenotes/notes/redfish-use-storage-over-simplestorage-ccb3e0e38bfe8712.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b37d698a262738e75389024dca1c5f5517278bd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Use Storage resource instead of SimpleStorage to provide Redfish driver"},{"line_number":5,"context_line":"    functionality, if Storage is available. If Storage resource is unavailable,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"97db6e8c_40a619be","line":2,"updated":"2023-08-23 13:40:46.000000000","message":"I\u0027d not call it a feature, it essentially makes the implementation more robust and does not add any new functionality.","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"99b929c7dcc8d1c8a3b789dd93d2bb5a076a4bdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Use Storage resource instead of SimpleStorage to provide Redfish driver"},{"line_number":5,"context_line":"    functionality, if Storage is available. If Storage resource is unavailable,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2948e3dd_ae096192","line":2,"in_reply_to":"97db6e8c_40a619be","updated":"2023-08-24 11:41:55.000000000","message":"Done","commit_id":"ab8babad1dfaa4b50e033ea79f9848e3025cc8ef"}]}