)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"550adb51f7631430d3635feefd8e39fc4c0badf9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"on the front end, and also sets the rpc object to None explicitly"},{"line_number":16,"context_line":"before returning the update_node result, since it appears a stream"},{"line_number":17,"context_line":"of them can cause issues for sqlite\u0027s release of the database from"},{"line_number":18,"context_line":"one thread to another."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8ef68ff62e8f93f7bc5bd9ee7c6ac8d96328f929"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"40d64ff9_cfc80f4a","line":18,"updated":"2023-08-23 06:44:28.000000000","message":"All local variables are purged before existing a function anyway.","commit_id":"78a00fdf174ca5471be35a82914b0cf5431688c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"550adb51f7631430d3635feefd8e39fc4c0badf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31d67aef_13f6ca59","updated":"2023-08-23 06:44:28.000000000","message":"I like the idea, two minor issues inline.","commit_id":"78a00fdf174ca5471be35a82914b0cf5431688c7"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"cb05a1901c2aa2ff9cd150930775010019b84b75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5a9d451_170a4b65","updated":"2024-11-18 19:36:54.000000000","message":"Julia \u0026 Dmitry: The original change seemed like a good one to add. I removed the two things that Dmitry took issue with in the prior patch and am re-submitting. Giving it a +1 since I touched stuff.","commit_id":"ad0ecea80c5b69ee6f2b485ca04a49fd9cd8f33b"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"550adb51f7631430d3635feefd8e39fc4c0badf9","unresolved":true,"context_lines":[{"line_number":2949,"context_line":"                                     chassis_uuid\u003dchassis_uuid)"},{"line_number":2950,"context_line":"        # Close out the RPC node since we\u0027ve already generated the"},{"line_number":2951,"context_line":"        # response."},{"line_number":2952,"context_line":"        rpc_node \u003d None"},{"line_number":2953,"context_line":"        return api_node"},{"line_number":2954,"context_line":""},{"line_number":2955,"context_line":"    @METRICS.timer(\u0027NodesController.delete\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"593dac26_7f93dfb9","line":2952,"updated":"2023-08-23 06:44:28.000000000","message":"This is pointless, and I\u0027d rather not mix it with the valid logging update.","commit_id":"78a00fdf174ca5471be35a82914b0cf5431688c7"}],"ironic/conductor/task_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"550adb51f7631430d3635feefd8e39fc4c0badf9","unresolved":true,"context_lines":[{"line_number":338,"context_line":"        else:"},{"line_number":339,"context_line":"            stop_after \u003d tenacity.stop_after_attempt(1)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        max_lock_time \u003d CONF.conductor.node_locked_retry_interval * CONF.conductor.node_locked_retry_attempts  # noqa"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        # NodeLocked exceptions can be annoying. Let\u0027s try to alleviate"},{"line_number":344,"context_line":"        # some of that pain by retrying our lock attempts."}],"source_content_type":"text/x-python","patch_set":2,"id":"3b1c0aeb_c8f54210","line":341,"updated":"2023-08-23 06:44:28.000000000","message":"No noqa please","commit_id":"78a00fdf174ca5471be35a82914b0cf5431688c7"}]}