)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6bd2ac715084d7b36ab4407bd105546771809bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f4289b90_d5890148","updated":"2023-11-09 15:19:56.000000000","message":"This needs to be added to api-ref, please -- I\u0027d prefer it be in this patch or the followup be posted before this lands (especially since gate is busted anyway). Lets also ensure this new capability makes its way to the clients.","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"015902972907b45e42cc1455e6ef04eada228537","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b140e82f_fb1f3fe6","updated":"2023-11-08 13:15:50.000000000","message":"lgtm","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4f5d35cac54140d24aa9f058b1d88e61e9951087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2e802ed0_a4829ebf","in_reply_to":"f4289b90_d5890148","updated":"2023-11-10 13:36:39.000000000","message":"I\u0027ll add to api-ref in this patch\nwe do have plans for the clients, both ironicclient and opensdk, but I doubt we\u0027ll \nhave time to show a patch before 2-3 weeks","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11be358569978250b0a4753e341314066fc80e92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"30723009_c78dda17","updated":"2023-11-22 20:44:57.000000000","message":"One issue, the explict set of node.last_error should go through node_history_record as it is a recordable error event.","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f9552ed5f4d818f857ad8e77add9eda8572b1068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"cd8152b3_605d2eeb","updated":"2023-11-16 11:42:20.000000000","message":"fix for metal3 job https://github.com/metal3-io/metal3-dev-env/pull/1314","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8d0a767e684014c28ceb1753f0069344eb220306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c4350419_4c446c8a","updated":"2023-11-16 08:20:25.000000000","message":"recheck I truly hope this is a glitch","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"89fc18cc28f0f32f0255b394efe56214b1f4d05f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6f0d432e_bb96d3f6","updated":"2023-11-16 14:01:46.000000000","message":"recheck fix merged","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e291e1c080b78aa9709f25e97d651c991e2b0c35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5480267e_438401a3","updated":"2023-11-30 12:24:00.000000000","message":"+W based on the discussion that happened yesterday on the irc \u003d)","commit_id":"090291221796c5631f367de093056cd2acc7841d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"72803618010aa2d50f9b1622a1bdb92088826188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"257f2a82_7583ab16","updated":"2023-11-28 10:56:58.000000000","message":"Didn\u0027t +W yet because I just want to make sure Julia is ok with the policy","commit_id":"090291221796c5631f367de093056cd2acc7841d"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"015902972907b45e42cc1455e6ef04eada228537","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        \u0027image_url\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":329,"context_line":"        \u0027image_download_source\u0027: {"},{"line_number":330,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":331,"context_line":"            \u0027enum\u0027: [\u0027http\u0027, \u0027local\u0027, \u0027swift\u0027],"},{"line_number":332,"context_line":"        },"},{"line_number":333,"context_line":"        # TODO(dtantsur): these are useful additions in the future, but the"},{"line_number":334,"context_line":"        # ISO image code does not support them."}],"source_content_type":"text/x-python","patch_set":12,"id":"60b4e406_9965a552","line":331,"range":{"start_line":331,"start_character":22,"end_line":331,"end_character":26},"updated":"2023-11-08 13:15:50.000000000","message":"don\u0027t we need https? (just wondering)","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2e205971e0c703c43607a941d28ea09c44e42e77","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        \u0027image_url\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":329,"context_line":"        \u0027image_download_source\u0027: {"},{"line_number":330,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":331,"context_line":"            \u0027enum\u0027: [\u0027http\u0027, \u0027local\u0027, \u0027swift\u0027],"},{"line_number":332,"context_line":"        },"},{"line_number":333,"context_line":"        # TODO(dtantsur): these are useful additions in the future, but the"},{"line_number":334,"context_line":"        # ISO image code does not support them."}],"source_content_type":"text/x-python","patch_set":12,"id":"6fae22d0_4dd82fa0","line":331,"range":{"start_line":331,"start_character":22,"end_line":331,"end_character":26},"in_reply_to":"60b4e406_9965a552","updated":"2023-11-08 14:19:08.000000000","message":"\u0027http\u0027 here means \u0027remote using an http server\u0027, it\u0027s not literally http://\ncheck the attach_virtual_media function in manager.py","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7dee98f5b3532e44ff66e0ef38cfe1cde217ed55","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        \u0027image_url\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":329,"context_line":"        \u0027image_download_source\u0027: {"},{"line_number":330,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":331,"context_line":"            \u0027enum\u0027: [\u0027http\u0027, \u0027local\u0027, \u0027swift\u0027],"},{"line_number":332,"context_line":"        },"},{"line_number":333,"context_line":"        # TODO(dtantsur): these are useful additions in the future, but the"},{"line_number":334,"context_line":"        # ISO image code does not support them."}],"source_content_type":"text/x-python","patch_set":12,"id":"ffb430cf_141019fe","line":331,"range":{"start_line":331,"start_character":22,"end_line":331,"end_character":26},"in_reply_to":"6fae22d0_4dd82fa0","updated":"2023-11-08 14:20:25.000000000","message":"yeah, I saw that and forgot to remove the comment, my bad","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e1f91cd67c53335dc85c11cc01f7047eca887bde","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"882a59d7_d67425ba","line":2153,"updated":"2023-11-09 21:38:31.000000000","message":"Can there be a get_all method which lists currently attached vmedia? It seems without that it would be a burden on the user to know what is attached","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9aaa9ec97f3ef1a194094827b09e1ad2536d777","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"e68f965f_6a72eae7","line":2153,"in_reply_to":"11082af1_0718571e","updated":"2023-11-15 12:26:20.000000000","message":"right, I\u0027ll dedicate the time to it today then since I\u0027m updating the api-ref","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e516f1b14d2fa5f709b01c43fd3c112728025e81","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a2e6a2a_bfe50a2a","line":2153,"in_reply_to":"1a285f0d_f62ea456","updated":"2023-11-10 20:35:35.000000000","message":"++ a follow-up would be enough","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b16dfbd8e3bbf01309e39f3c7780b8cf165e362b","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"0bd30862_c9163730","line":2153,"in_reply_to":"2d04afae_6d6ec0fe","updated":"2023-11-22 22:17:27.000000000","message":"Done","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fe0c8a39334b47cf9dee5437b0883fe72282ce40","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"2d04afae_6d6ec0fe","line":2153,"in_reply_to":"58f935cf_6c1a98dc","updated":"2023-11-15 15:52:15.000000000","message":"actually now that I think a bit more about it and looking at the proposal this is out of scope for the moment\nI\u0027d rather keep it for a future patch","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c8a5ff7854569920539720d632d0e1f2b06482e3","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"11082af1_0718571e","line":2153,"in_reply_to":"7a2e6a2a_bfe50a2a","updated":"2023-11-12 19:38:35.000000000","message":"A followup would be fine but that would mean another increment to the api version, getting it done now might be less effort overall","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4f5d35cac54140d24aa9f058b1d88e61e9951087","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a285f0d_f62ea456","line":2153,"in_reply_to":"882a59d7_d67425ba","updated":"2023-11-10 13:36:39.000000000","message":"I guess that would be useful indeed\nlet\u0027s add it in a follow up?","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"65104cb24d0210b33e885f7c2934e8fdfca966c7","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def __init__(self, node_ident):"},{"line_number":2152,"context_line":"        self.node_ident \u003d node_ident"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"    @METRICS.timer(\u0027NodeVmediaController.post\u0027)"},{"line_number":2155,"context_line":"    @method.expose(status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":2156,"context_line":"    @method.body(\u0027vmedia\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"58f935cf_6c1a98dc","line":2153,"in_reply_to":"e68f965f_6a72eae7","updated":"2023-11-15 15:13:09.000000000","message":"Done","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"}],"ironic/common/policy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11be358569978250b0a4753e341314066fc80e92","unresolved":true,"context_lines":[{"line_number":1020,"context_line":"    ),"},{"line_number":1021,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":1022,"context_line":"        name\u003d\u0027baremetal:node:vmedia:attach\u0027,"},{"line_number":1023,"context_line":"        check_str\u003dSYSTEM_OR_PROJECT_MEMBER,"},{"line_number":1024,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":1025,"context_line":"        description\u003d\u0027Attach a virtual media device to a node\u0027,"},{"line_number":1026,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":17,"id":"2f49129e_4d89bc61","line":1023,"updated":"2023-11-22 20:44:57.000000000","message":"So any OpenStack user should be able to attach, and detach?","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b3b0d5ae6c3d18d7ac2c7eefd5c006be05d3ac8c","unresolved":true,"context_lines":[{"line_number":1020,"context_line":"    ),"},{"line_number":1021,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":1022,"context_line":"        name\u003d\u0027baremetal:node:vmedia:attach\u0027,"},{"line_number":1023,"context_line":"        check_str\u003dSYSTEM_OR_PROJECT_MEMBER,"},{"line_number":1024,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":1025,"context_line":"        description\u003d\u0027Attach a virtual media device to a node\u0027,"},{"line_number":1026,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":17,"id":"7b58eea7_6700911c","line":1023,"in_reply_to":"2f49129e_4d89bc61","updated":"2023-11-23 08:55:33.000000000","message":"this is the same level of other commands, for example like \u0027set_secure_boot\u0027 or \u0027set_power_state\u0027 that are similar in scope, so I gave as assumed that it was ok\ndo you suggest to change it with something else?","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"}],"ironic/conductor/manager.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6bd2ac715084d7b36ab4407bd105546771809bac","unresolved":true,"context_lines":[{"line_number":3817,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse,"},{"line_number":3818,"context_line":"                                  purpose\u003d\u0027attaching virtual media\u0027) as task:"},{"line_number":3819,"context_line":"            task.driver.management.validate(task)"},{"line_number":3820,"context_line":"            # Starting new operation, so clear the previous error."},{"line_number":3821,"context_line":"            # We\u0027ll be putting an error here soon if we fail task."},{"line_number":3822,"context_line":"            task.node.last_error \u003d None"},{"line_number":3823,"context_line":"            task.node.save()"}],"source_content_type":"text/x-python","patch_set":12,"id":"a8568d74_d07a7037","line":3820,"updated":"2023-11-09 15:19:56.000000000","message":"nit: openstack style is to tag these with your nick","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4f5d35cac54140d24aa9f058b1d88e61e9951087","unresolved":false,"context_lines":[{"line_number":3817,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse,"},{"line_number":3818,"context_line":"                                  purpose\u003d\u0027attaching virtual media\u0027) as task:"},{"line_number":3819,"context_line":"            task.driver.management.validate(task)"},{"line_number":3820,"context_line":"            # Starting new operation, so clear the previous error."},{"line_number":3821,"context_line":"            # We\u0027ll be putting an error here soon if we fail task."},{"line_number":3822,"context_line":"            task.node.last_error \u003d None"},{"line_number":3823,"context_line":"            task.node.save()"}],"source_content_type":"text/x-python","patch_set":12,"id":"309b759c_9fca2d43","line":3820,"in_reply_to":"a8568d74_d07a7037","updated":"2023-11-10 13:36:39.000000000","message":"Ack","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"}],"ironic/conductor/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"11be358569978250b0a4753e341314066fc80e92","unresolved":true,"context_lines":[{"line_number":1861,"context_line":"        LOG.error("},{"line_number":1862,"context_line":"            error, exc_info\u003dnot isinstance(exc, exception.IronicException))"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    task.node.last_error \u003d error"},{"line_number":1865,"context_line":"    task.node.save()"},{"line_number":1866,"context_line":"    if not error and success_msg:"},{"line_number":1867,"context_line":"        LOG.info(success_msg, dict(kwargs, node\u003dtask.node.uuid))"}],"source_content_type":"text/x-python","patch_set":17,"id":"21acc01e_d6d9c348","line":1864,"updated":"2023-11-22 20:44:57.000000000","message":"We should be using node_history_record() here","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b3b0d5ae6c3d18d7ac2c7eefd5c006be05d3ac8c","unresolved":false,"context_lines":[{"line_number":1861,"context_line":"        LOG.error("},{"line_number":1862,"context_line":"            error, exc_info\u003dnot isinstance(exc, exception.IronicException))"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    task.node.last_error \u003d error"},{"line_number":1865,"context_line":"    task.node.save()"},{"line_number":1866,"context_line":"    if not error and success_msg:"},{"line_number":1867,"context_line":"        LOG.info(success_msg, dict(kwargs, node\u003dtask.node.uuid))"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a06a977_d07065cd","line":1864,"in_reply_to":"21acc01e_d6d9c348","updated":"2023-11-23 08:55:33.000000000","message":"Acknowledged","commit_id":"35fac8f85ffc8489cb48aaedd71f8102432f7bfd"}],"ironic/drivers/modules/redfish/vendor.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6bd2ac715084d7b36ab4407bd105546771809bac","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                                 \"Optional arguments: \""},{"line_number":93,"context_line":"                                 \"\u0027boot_device\u0027 - the boot device to eject, \""},{"line_number":94,"context_line":"                                 \"either \u0027cd\u0027, \u0027dvd\u0027, \u0027usb\u0027, or \u0027floppy\u0027\"))"},{"line_number":95,"context_line":"    # @task_manager.require_exclusive_lock"},{"line_number":96,"context_line":"    def eject_vmedia(self, task, **kwargs):"},{"line_number":97,"context_line":"        \"\"\"Eject a virtual media device."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"61c2aa1e_3d2eb954","line":95,"updated":"2023-11-09 15:19:56.000000000","message":"This is weird, but not added by this patch. Still weird.","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2b054516e7482242542eac16d99cddb1e3aab2e1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                 \"Optional arguments: \""},{"line_number":93,"context_line":"                                 \"\u0027boot_device\u0027 - the boot device to eject, \""},{"line_number":94,"context_line":"                                 \"either \u0027cd\u0027, \u0027dvd\u0027, \u0027usb\u0027, or \u0027floppy\u0027\"))"},{"line_number":95,"context_line":"    # @task_manager.require_exclusive_lock"},{"line_number":96,"context_line":"    def eject_vmedia(self, task, **kwargs):"},{"line_number":97,"context_line":"        \"\"\"Eject a virtual media device."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c2b4887c_254c2cfb","line":95,"in_reply_to":"04d620d2_50617a6a","updated":"2023-11-15 15:13:33.000000000","message":"Ack","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4f5d35cac54140d24aa9f058b1d88e61e9951087","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                                 \"Optional arguments: \""},{"line_number":93,"context_line":"                                 \"\u0027boot_device\u0027 - the boot device to eject, \""},{"line_number":94,"context_line":"                                 \"either \u0027cd\u0027, \u0027dvd\u0027, \u0027usb\u0027, or \u0027floppy\u0027\"))"},{"line_number":95,"context_line":"    # @task_manager.require_exclusive_lock"},{"line_number":96,"context_line":"    def eject_vmedia(self, task, **kwargs):"},{"line_number":97,"context_line":"        \"\"\"Eject a virtual media device."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"04d620d2_50617a6a","line":95,"in_reply_to":"61c2aa1e_3d2eb954","updated":"2023-11-10 13:36:39.000000000","message":"I honestly have no idea why this is commented out, I would just remove it, maybe not here though :)","commit_id":"12d1ad794258d46413aeeb8c6d62f69ae828c913"}]}