)]}'
{"ironic/drivers/modules/inspect_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2adafbbb66e15f2eb90b0eae79a023cfb27c9b11","unresolved":true,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if ((address.startswith(\u0027[\u0027) and address.endswith(\u0027]\u0027))"},{"line_number":346,"context_line":"                and netutils.is_valid_ipv6(address[:-1][1:])):"},{"line_number":347,"context_line":"            address \u003d address[:-1][1:]"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        try:"},{"line_number":350,"context_line":"            addrinfo \u003d socket.getaddrinfo(address, None, proto\u003dsocket.SOL_TCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"06d524cf_5915525d","line":347,"updated":"2023-09-19 11:29:41.000000000","message":"We cannot have valid hostnames with brackets, right? Then you can probably just use address.strip","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0ef772a38e121c8775713f45128e43d55ea3471","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if ((address.startswith(\u0027[\u0027) and address.endswith(\u0027]\u0027))"},{"line_number":346,"context_line":"                and netutils.is_valid_ipv6(address[:-1][1:])):"},{"line_number":347,"context_line":"            address \u003d address[:-1][1:]"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        try:"},{"line_number":350,"context_line":"            addrinfo \u003d socket.getaddrinfo(address, None, proto\u003dsocket.SOL_TCP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"395cc547_c9a4a081","line":347,"in_reply_to":"06d524cf_5915525d","updated":"2023-09-19 12:56:51.000000000","message":"yes, brackets are not allowed for hostname according to RFC952.\nI removed the entire condition and replaced it with:\n```\n  address \u003d address.strip(\u0027[\u0027).strip(\u0027]\u0027)\n```","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"}],"releasenotes/notes/bug-2036455-edd0e97335579684.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2adafbbb66e15f2eb90b0eae79a023cfb27c9b11","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue where inspection would fail if an IPv6 address wrapped in"},{"line_number":5,"context_line":"    brackets is used for the redfish bmc address. See bug:"},{"line_number":6,"context_line":"    `2036455 \u003chttps://bugs.launchpad.net/ironic/+bug/2036455\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"36aef7ce_9a1d02ef","line":4,"updated":"2023-09-19 11:29:41.000000000","message":"nit: Fixes","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0ef772a38e121c8775713f45128e43d55ea3471","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue where inspection would fail if an IPv6 address wrapped in"},{"line_number":5,"context_line":"    brackets is used for the redfish bmc address. See bug:"},{"line_number":6,"context_line":"    `2036455 \u003chttps://bugs.launchpad.net/ironic/+bug/2036455\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4dfd70c8_0a0c762e","line":4,"in_reply_to":"36aef7ce_9a1d02ef","updated":"2023-09-19 12:56:51.000000000","message":"Done","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2adafbbb66e15f2eb90b0eae79a023cfb27c9b11","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue where inspection would fail if an IPv6 address wrapped in"},{"line_number":5,"context_line":"    brackets is used for the redfish bmc address. See bug:"},{"line_number":6,"context_line":"    `2036455 \u003chttps://bugs.launchpad.net/ironic/+bug/2036455\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0cfb109c_f011678e","line":5,"updated":"2023-09-19 11:29:41.000000000","message":"nit: BMC","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e0ef772a38e121c8775713f45128e43d55ea3471","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue where inspection would fail if an IPv6 address wrapped in"},{"line_number":5,"context_line":"    brackets is used for the redfish bmc address. See bug:"},{"line_number":6,"context_line":"    `2036455 \u003chttps://bugs.launchpad.net/ironic/+bug/2036455\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e226d846_071ca55e","line":5,"in_reply_to":"0cfb109c_f011678e","updated":"2023-09-19 12:56:51.000000000","message":"Done","commit_id":"5e071eeea98ac2a274666c1640c7b5d1689d8eb4"}]}