)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"daff7414706ebea7e11ed4d4baacb2c14813bf5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ebc0755_11c9b8ba","updated":"2023-10-18 21:20:48.000000000","message":"LGTM but I\u0027m unfamiliar with the hardware. Can upgrade to a core review if you need just ask.","commit_id":"766d2804a1743e238a37762c946dec0984721167"}],"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2577434c99daed4237aba45b572751339626b02","unresolved":true,"context_lines":[{"line_number":283,"context_line":"                               \u0027available_device\u0027: sushy.VIRTUAL_MEDIA_DVD})"},{"line_number":284,"context_line":"                else:"},{"line_number":285,"context_line":"                    continue"},{"line_number":286,"context_line":"            inserted \u003d v_media.inserted"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if inserted:"},{"line_number":289,"context_line":"                v_media.eject_media()"}],"source_content_type":"text/x-python","patch_set":2,"id":"06bcd130_accc2959","line":286,"updated":"2023-10-12 14:42:01.000000000","message":"Wouldn\u0027t we have the same basic effect if just looked at the inserted state instead?","commit_id":"e6ab72dae62542570a86818b321830498e27f9e6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"eaa242b0ff886d62c6fdb268deeffdbcac9250dd","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                               \u0027available_device\u0027: sushy.VIRTUAL_MEDIA_DVD})"},{"line_number":284,"context_line":"                else:"},{"line_number":285,"context_line":"                    continue"},{"line_number":286,"context_line":"            inserted \u003d v_media.inserted"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if inserted:"},{"line_number":289,"context_line":"                v_media.eject_media()"}],"source_content_type":"text/x-python","patch_set":2,"id":"789f61ee_57b8749a","line":286,"in_reply_to":"06bcd130_accc2959","updated":"2023-10-13 12:48:15.000000000","message":"Not really, because normally ironic requests the boot_device as CD, in this case we would remove media only from the devices that had CD as MediaType.\nIn  the Cisco Hardware they don\u0027t have CD as supported MediaType so it would fail to insert the media (see  https://bugs.launchpad.net/ironic/+bug/2031595 )\nSo we need to take into consideration removing media attached to DVD devices in case CD was requested but is not listed as MediaType.","commit_id":"e6ab72dae62542570a86818b321830498e27f9e6"}],"releasenotes/notes/fix-eject-media-dvd-b1994446ea71be9c.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0f81ebe76e3136c8487d23775b3b9c46ba9bda5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We added a fallback to insert virtual media in DVD devices in case the"},{"line_number":5,"context_line":"    hardware doesn\u0027t have support for CD, but we didn\u0027t took in consideration"},{"line_number":6,"context_line":"    the eject workflow."},{"line_number":7,"context_line":"    See `bug 2039042 \u003chttps://bugs.launchpad.net/ironic/+bug/2039042\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"35aa6d95_513fca94","line":4,"updated":"2023-10-12 08:04:27.000000000","message":"Could you rephrase it to say what this change does, not what we did not do in the past?","commit_id":"e6ab72dae62542570a86818b321830498e27f9e6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a8caa1877beeec6af0c6330b8dadb9d1a36ac30d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We added a fallback to insert virtual media in DVD devices in case the"},{"line_number":5,"context_line":"    hardware doesn\u0027t have support for CD, but we didn\u0027t took in consideration"},{"line_number":6,"context_line":"    the eject workflow."},{"line_number":7,"context_line":"    See `bug 2039042 \u003chttps://bugs.launchpad.net/ironic/+bug/2039042\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b134812e_37a8913b","line":4,"in_reply_to":"35aa6d95_513fca94","updated":"2023-10-12 14:42:21.000000000","message":"++","commit_id":"e6ab72dae62542570a86818b321830498e27f9e6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"83e8c4c865a4f128809eefbe58cc349ab97c24f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We added a fallback to insert virtual media in DVD devices in case the"},{"line_number":5,"context_line":"    hardware doesn\u0027t have support for CD, but we didn\u0027t took in consideration"},{"line_number":6,"context_line":"    the eject workflow."},{"line_number":7,"context_line":"    See `bug 2039042 \u003chttps://bugs.launchpad.net/ironic/+bug/2039042\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6811490e_f8dc3744","line":4,"in_reply_to":"b134812e_37a8913b","updated":"2023-10-13 12:38:05.000000000","message":"Done","commit_id":"e6ab72dae62542570a86818b321830498e27f9e6"}]}