)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"970e84146adb24fb0ef4889be1d7da02478b765e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a7a4222_c953051b","updated":"2023-12-07 08:20:34.000000000","message":"Needs a release note.","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"00eda4a883ea301aca57d08d1185167fb25e387a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00b321dd_a2a451e3","updated":"2023-12-11 07:42:57.000000000","message":"Thanks Dmitry for comments, all resolved","commit_id":"43f206927a21e4083256f42d37384870a085e63c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"347cc442140995b44e830d2190d7fbd0803a67bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3d8e1c91_ddc33b0c","updated":"2023-12-15 19:49:26.000000000","message":"If this doesn\u0027t break anything that works now, and fixes support for iLO 6 hardware in redfish driver, should we backport it?","commit_id":"6956b0619e26a9fc6bd482f4eed1901cfd4e3dd5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"77535dfe062327ca2a94297d1cbd26d7897b6404","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29da69bb_4299f87e","updated":"2023-12-14 09:56:07.000000000","message":"Just a heads-up: I\u0027m aware of this patch, and it looks good to me. I\u0027m just checking with a few parties that we don\u0027t break things that work now.","commit_id":"6956b0619e26a9fc6bd482f4eed1901cfd4e3dd5"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"364e04c988326121cede78007e49111d44d8b47d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fdda244_2da5a57d","updated":"2023-12-18 05:40:11.000000000","message":"Thanks JayF for comments. I will raise backport as possible.","commit_id":"6956b0619e26a9fc6bd482f4eed1901cfd4e3dd5"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"fa3122cd745146d6a146e008e92abe34c5859071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10d1eedb_4b6cd0f5","updated":"2023-12-13 05:05:42.000000000","message":"recheck","commit_id":"6956b0619e26a9fc6bd482f4eed1901cfd4e3dd5"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"364e04c988326121cede78007e49111d44d8b47d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a3f6c0c_8743151b","in_reply_to":"3d8e1c91_ddc33b0c","updated":"2023-12-18 05:40:11.000000000","message":"Thanks. I will raise patches for backport as possible.","commit_id":"6956b0619e26a9fc6bd482f4eed1901cfd4e3dd5"}],"ironic/drivers/modules/redfish/raid.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"970e84146adb24fb0ef4889be1d7da02478b765e","unresolved":true,"context_lines":[{"line_number":618,"context_line":"def _construct_volume_payload("},{"line_number":619,"context_line":"        node, storage, raid_controller, physical_disks, raid_level, size_bytes,"},{"line_number":620,"context_line":"        disk_name\u003dNone, span_length\u003dNone, span_depth\u003dNone):"},{"line_number":621,"context_line":"    system \u003d redfish_utils.get_system(node)"},{"line_number":622,"context_line":"    manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":623,"context_line":"    fw_version \u003d manager.firmware_version"},{"line_number":624,"context_line":"    if \"iLO\" in fw_version and int(fw_version.split()[1]) \u003e\u003d 6:"}],"source_content_type":"text/x-python","patch_set":2,"id":"77ca6ea0_6a68857d","line":621,"updated":"2023-12-07 08:20:34.000000000","message":"The system argument can be passed by the caller (it has a system already), let\u0027s not load it again.","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"00eda4a883ea301aca57d08d1185167fb25e387a","unresolved":false,"context_lines":[{"line_number":618,"context_line":"def _construct_volume_payload("},{"line_number":619,"context_line":"        node, storage, raid_controller, physical_disks, raid_level, size_bytes,"},{"line_number":620,"context_line":"        disk_name\u003dNone, span_length\u003dNone, span_depth\u003dNone):"},{"line_number":621,"context_line":"    system \u003d redfish_utils.get_system(node)"},{"line_number":622,"context_line":"    manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":623,"context_line":"    fw_version \u003d manager.firmware_version"},{"line_number":624,"context_line":"    if \"iLO\" in fw_version and int(fw_version.split()[1]) \u003e\u003d 6:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e996c84c_1c4c9df8","line":621,"in_reply_to":"77ca6ea0_6a68857d","updated":"2023-12-11 07:42:57.000000000","message":"Done","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"970e84146adb24fb0ef4889be1d7da02478b765e","unresolved":true,"context_lines":[{"line_number":621,"context_line":"    system \u003d redfish_utils.get_system(node)"},{"line_number":622,"context_line":"    manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":623,"context_line":"    fw_version \u003d manager.firmware_version"},{"line_number":624,"context_line":"    if \"iLO\" in fw_version and int(fw_version.split()[1]) \u003e\u003d 6:"},{"line_number":625,"context_line":"        payload \u003d {\u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":626,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"},{"line_number":627,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ae7d791_8a001093","line":624,"updated":"2023-12-07 08:20:34.000000000","message":"This situation is not iLO6-specific as far as I understand. See just below.","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"00eda4a883ea301aca57d08d1185167fb25e387a","unresolved":false,"context_lines":[{"line_number":621,"context_line":"    system \u003d redfish_utils.get_system(node)"},{"line_number":622,"context_line":"    manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":623,"context_line":"    fw_version \u003d manager.firmware_version"},{"line_number":624,"context_line":"    if \"iLO\" in fw_version and int(fw_version.split()[1]) \u003e\u003d 6:"},{"line_number":625,"context_line":"        payload \u003d {\u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":626,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"},{"line_number":627,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea2af72b_0a90e2bc","line":624,"in_reply_to":"0ae7d791_8a001093","updated":"2023-12-11 07:42:57.000000000","message":"Done","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"970e84146adb24fb0ef4889be1d7da02478b765e","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        payload \u003d {\u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":626,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"},{"line_number":627,"context_line":"    else:"},{"line_number":628,"context_line":"        payload \u003d {\u0027Encrypted\u0027: False,"},{"line_number":629,"context_line":"                   \u0027VolumeType\u0027: RAID_LEVELS[raid_level][\u0027volume_type\u0027],"},{"line_number":630,"context_line":"                   \u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":631,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1d5438c_c08bbd3c","line":628,"updated":"2023-12-07 08:20:34.000000000","message":"Is there any reason to keep these fields for anyone?\n\nIf you want compatibility with older firmware, better check the redfish version. I\u0027d avoid sending Encrypted in any case.","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"00eda4a883ea301aca57d08d1185167fb25e387a","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        payload \u003d {\u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":626,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"},{"line_number":627,"context_line":"    else:"},{"line_number":628,"context_line":"        payload \u003d {\u0027Encrypted\u0027: False,"},{"line_number":629,"context_line":"                   \u0027VolumeType\u0027: RAID_LEVELS[raid_level][\u0027volume_type\u0027],"},{"line_number":630,"context_line":"                   \u0027RAIDType\u0027: RAID_LEVELS[raid_level][\u0027raid_type\u0027],"},{"line_number":631,"context_line":"                   \u0027CapacityBytes\u0027: size_bytes}"}],"source_content_type":"text/x-python","patch_set":2,"id":"c5b31f8d_d2820645","line":628,"in_reply_to":"d1d5438c_c08bbd3c","updated":"2023-12-11 07:42:57.000000000","message":"Done","commit_id":"089f54fee8ccc4e8f7eb31d56f274186b2d76853"}]}