)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a38b9ba0e1f5bf9c19e7f6a2a58f5269ba9adb0d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-12-08 16:56:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding community images to always available ones prevents from"},{"line_number":8,"context_line":"not being able to retrieve rootfs_uuid from community images."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I8801d5fb167990dd875bb8f4ef1e6fd17f19eab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"db70ecd6_72087d0d","line":8,"updated":"2023-12-13 21:50:55.000000000","message":"Commit messages should be:\n\nFirst line max 50 characters.\n\nFollowed by a newline, and a longer paragraph with\nlines up to 70 characters each describing the change.\n\n\nThe commit message here has too long of a first line. Please revise it.","commit_id":"1fe8a0ac8b8e235a11805dcb38eda1e4097f1551"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a38b9ba0e1f5bf9c19e7f6a2a58f5269ba9adb0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f45e06a_edb913bd","updated":"2023-12-13 21:50:55.000000000","message":"Please document this change with a release note: https://docs.openstack.org/ironic/newton/dev/faq.html#create-a-new-release-note\n\nChange itself looks good. Needs to be documented and commit message needs to be corrected.","commit_id":"1fe8a0ac8b8e235a11805dcb38eda1e4097f1551"},{"author":{"_account_id":34320,"name":"Maryna Savchenko","email":"maryna.savchenko@cern.ch","username":"msavchen"},"change_message_id":"a77a530b485915ad2de38927951413122fa104a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9576a59f_f9da5fa9","updated":"2023-12-13 10:49:33.000000000","message":"recheck","commit_id":"1fe8a0ac8b8e235a11805dcb38eda1e4097f1551"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"48efbc3d2f06aa4f258acc1a4eeeb29b1f179ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbe2a287_b640995b","updated":"2025-03-05 14:07:34.000000000","message":"Needs a rebase.","commit_id":"0139792c43abaa8d9bdcf2be2239929a7fd7a553"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"679cb752d9d8139d73dad570a0317854ac943d91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36347c03_b23dc2a6","updated":"2024-08-16 21:22:04.000000000","message":"The release note is not going to be clear enough for operators.","commit_id":"0139792c43abaa8d9bdcf2be2239929a7fd7a553"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3a6b3c0baef01f2097138293e1c51a3746996c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0bd13aa0_8be835c8","updated":"2024-08-06 12:55:51.000000000","message":"lgtm thanks!","commit_id":"0139792c43abaa8d9bdcf2be2239929a7fd7a553"}],"ironic/common/glance_service/service_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"897dd1c227a2a6b893d3b36c80e674b7cdc8af4d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        # be able to be used."},{"line_number":115,"context_line":"        return True"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if getattr(image, \u0027visibility\u0027, None) in (\u0027public\u0027, \u0027community\u0027):"},{"line_number":118,"context_line":"        return True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return (context.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4e74c24_d64af15e","line":117,"updated":"2024-01-12 23:38:34.000000000","message":"Any chance we could get a quick unit test for this?","commit_id":"f8215e5dbc6a679f4d74de0907289a45fa072906"},{"author":{"_account_id":34320,"name":"Maryna Savchenko","email":"maryna.savchenko@cern.ch","username":"msavchen"},"change_message_id":"dfd3e7db6dfca81d8a36f424bb1bb9ad5ef124a8","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        # be able to be used."},{"line_number":115,"context_line":"        return True"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if getattr(image, \u0027visibility\u0027, None) in (\u0027public\u0027, \u0027community\u0027):"},{"line_number":118,"context_line":"        return True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return (context.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"da72039c_adee14f1","line":117,"in_reply_to":"a4e74c24_d64af15e","updated":"2024-08-06 12:49:09.000000000","message":"sorry, it took so long!\nDoes it seem good?","commit_id":"f8215e5dbc6a679f4d74de0907289a45fa072906"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"48efbc3d2f06aa4f258acc1a4eeeb29b1f179ee8","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        # be able to be used."},{"line_number":115,"context_line":"        return True"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if getattr(image, \u0027visibility\u0027, None) in (\u0027public\u0027, \u0027community\u0027):"},{"line_number":118,"context_line":"        return True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return (context.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"a581ed4f_0dff1607","line":117,"in_reply_to":"da72039c_adee14f1","updated":"2025-03-05 14:07:34.000000000","message":"The tests seem reasonable at a glance. I hate to do this, but based upon other and recent discussion, we likely want to lock this behavior behind an option because some operators need to highly restrict what images are deployed to hosts for compatibility/support reasons. So, adding a configuration knob while re-basing would be advisable.","commit_id":"f8215e5dbc6a679f4d74de0907289a45fa072906"}],"releasenotes/notes/make_community_image_visible-c7133a436b851c37.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"679cb752d9d8139d73dad570a0317854ac943d91","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When checking if image is available,"},{"line_number":5,"context_line":"    always return available for community images."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b74156d2_3cd0dbeb","line":5,"updated":"2024-08-16 21:22:04.000000000","message":"Can we add some context around what a \u0027community\u0027 image is? Remember we have non-openstack users of Ironic.\n\nI assume something like this would be accurate:\n\n\"Glance images with visibility set to community are now considered usable by Ironic.\"","commit_id":"0139792c43abaa8d9bdcf2be2239929a7fd7a553"}]}
