)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a14a3d1a23227f5b970b78adcb06bc3e0056eba2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-25 14:54:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set_console_mode to not overwrite node.last_error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last_error field of nodes is meant to be used by async tasks running"},{"line_number":10,"context_line":"in the background, sync methods should just return the error to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXX%2F%2F2XI%3D","line":7,"updated":"2014-04-25 19:39:56.000000000","message":"I find the commit message heading to be misleading because _set_console_mode() still sets last_error (and it should).\n\nPerhaps the following would be better wording:\n\n  Return error immediately if set_console_mode is not supported by driver\n\n  Currently, if set_console_mode is not supported by the driver, the error\n  is recorded on the node.last_error field, but the user is not otherwise notified.\n  This field should only be used for asynchronous feedback; the determination\n  as to whether set_console_mode is supported is synchronous. Therefor, it\n  should return an error to the user immediately and not alter node.last_error.","commit_id":"336db222763cb9e1187802898c33ec3199099239"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"51f736a0bb06185b481c9e22fefe28a260baba48","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-25 14:54:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set_console_mode to not overwrite node.last_error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The last_error field of nodes is meant to be used by async tasks running"},{"line_number":10,"context_line":"in the background, sync methods should just return the error to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXX%2F%2FvYo%3D","line":7,"in_reply_to":"AAAAXX%2F%2F2XI%3D","updated":"2014-04-28 10:40:52.000000000","message":"Oh thanks for the suggestion, I will update the commit message","commit_id":"336db222763cb9e1187802898c33ec3199099239"}],"ironic/conductor/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"71e2ce38ec6e72f80e73c79a5963a281b1fee2a5","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                           \"console is already %s\") % op)"},{"line_number":866,"context_line":"                task.release_resources()"},{"line_number":867,"context_line":"            else:"},{"line_number":868,"context_line":"                node.last_error \u003d None"},{"line_number":869,"context_line":"                node.save(context)"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"                # Start the requested action in the background."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4%2Fw%3D","side":"PARENT","line":868,"updated":"2014-04-25 14:10:09.000000000","message":"Should this clear the last error then, or not?  I dunno what the rules are on when we should clear last_error.","commit_id":"87a1eced235fb787e5e6f22347c9e85841a06f23"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f334c36e545b6549216b22b05d809f2179f4771","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                           \"console is already %s\") % op)"},{"line_number":866,"context_line":"                task.release_resources()"},{"line_number":867,"context_line":"            else:"},{"line_number":868,"context_line":"                node.last_error \u003d None"},{"line_number":869,"context_line":"                node.save(context)"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"                # Start the requested action in the background."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F4fU%3D","side":"PARENT","line":868,"in_reply_to":"AAAAXX%2F%2F4%2Fw%3D","updated":"2014-04-25 15:17:59.000000000","message":"I think it\u0027s fine to clean the error here before starting the async work, other methods that spawn workers does the same, e.g L356","commit_id":"87a1eced235fb787e5e6f22347c9e85841a06f23"}]}