)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e413241e463ffa4e8c687b558d325d945ebb992c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"it due to caching of master images. In this change ImageCache"},{"line_number":11,"context_line":"will ask Glance for image checksum and include it into the file name"},{"line_number":12,"context_line":"of master image in local cache, thus image will be taken from"},{"line_number":13,"context_line":"cache only if checksum is the same as when caching."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id626c5f7ef26c83667e263aafc892116cf045eb8"},{"line_number":16,"context_line":"Implements: blueprint pxe-master-images-caching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bad4c104_46ee0624","line":13,"updated":"2014-04-29 02:36:58.000000000","message":"I\u0027d like this to land before the cache refactoring, since its a current bug, no ? (Though I didn\u0027t realise glance *permitted* changing the content of an image without changing the uuid - have we validated that it does? Or is this entirely unneeded?)","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b9836766c101f861e6322eb08e5b9f2a3a3d0f9c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"it due to caching of master images. In this change ImageCache"},{"line_number":11,"context_line":"will ask Glance for image checksum and include it into the file name"},{"line_number":12,"context_line":"of master image in local cache, thus image will be taken from"},{"line_number":13,"context_line":"cache only if checksum is the same as when caching."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id626c5f7ef26c83667e263aafc892116cf045eb8"},{"line_number":16,"context_line":"Implements: blueprint pxe-master-images-caching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bad4c104_f5ac1a8f","line":13,"in_reply_to":"bad4c104_46ee0624","updated":"2014-04-29 08:37:36.000000000","message":"1. This is _much_ harder to land without refactoring, actually refactoring was done so that it\u0027s easier to fix; also refactoring does fix another bug\n2. I\u0027ll double-check, but seems like yes","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0bc9644a75bec1afbbc65d7817047fda1bbb9205","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param ctx: context"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        image_service \u003d (self._image_service if self._image_service is not None"},{"line_number":68,"context_line":"                         else service.Service(context\u003dctx))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if self._master_dir is None:"},{"line_number":71,"context_line":"            #NOTE(ghe): We don\u0027t share images between instances/hosts"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2FtJY%3D","line":68,"updated":"2014-04-28 15:14:10.000000000","message":"Maybe makes sense set self._image_service for further use?","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b4da409933646dd11566bb8aa53d9d09deccf44","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param ctx: context"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        image_service \u003d (self._image_service if self._image_service is not None"},{"line_number":68,"context_line":"                         else service.Service(context\u003dctx))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if self._master_dir is None:"},{"line_number":71,"context_line":"            #NOTE(ghe): We don\u0027t share images between instances/hosts"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2Fs8w%3D","line":68,"in_reply_to":"AAAAXX%2F%2FtJY%3D","updated":"2014-04-28 15:26:10.000000000","message":"Done","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0bc9644a75bec1afbbc65d7817047fda1bbb9205","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        #TODO(ghe): have hard links and counts the same behaviour in all fs"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        image_details \u003d image_service.show(uuid)"},{"line_number":79,"context_line":"        master_file_name \u003d \"%s-%s\" % ("},{"line_number":80,"context_line":"            service_utils.parse_image_ref(uuid)[0],"},{"line_number":81,"context_line":"            image_details[\u0027checksum\u0027]"},{"line_number":82,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2FtKQ%3D","line":79,"updated":"2014-04-28 15:14:10.000000000","message":"AFAIK we should use named formatting here.","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b4da409933646dd11566bb8aa53d9d09deccf44","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        #TODO(ghe): have hard links and counts the same behaviour in all fs"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        image_details \u003d image_service.show(uuid)"},{"line_number":79,"context_line":"        master_file_name \u003d \"%s-%s\" % ("},{"line_number":80,"context_line":"            service_utils.parse_image_ref(uuid)[0],"},{"line_number":81,"context_line":"            image_details[\u0027checksum\u0027]"},{"line_number":82,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXX%2F%2Fs8o%3D","line":79,"in_reply_to":"AAAAXX%2F%2FtKQ%3D","updated":"2014-04-28 15:26:10.000000000","message":"Done","commit_id":"369c6fcb8ee701e49f0d1e2fd938c580a760a82b"}]}