)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6a0a71eb64d0d973dbf3849f5099234d39923195","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t create a hardlink to a symlink when handling file:// URLs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While os.link is supposed to follow symlinks, it\u0027s actually broken [1]"},{"line_number":10,"context_line":"on Linux. As a result, Ironic may end up creating a hard link to"},{"line_number":11,"context_line":"a symlink. If the symlink is relative, chances are high accessing the"},{"line_number":12,"context_line":"resulting file will cause a FileNotFoundError."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c8a514f5_26ac8b3d","line":9,"updated":"2024-01-15 20:52:47.000000000","message":"I think you intended to add a reference here","commit_id":"9a3b2056262512b4c6ee4a9eb72f3bb9432b699d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7f9bb41428dc0580a03b356322022a5620a64d88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e416d28_19598e48","updated":"2024-01-16 08:05:29.000000000","message":"whoops wrong patch","commit_id":"9a3b2056262512b4c6ee4a9eb72f3bb9432b699d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3fb6957e7b8fd2e3be9e5710937a4da07b5225d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"07459f13_e29a7191","updated":"2024-01-19 15:03:28.000000000","message":"recheck","commit_id":"0b3ed093eafdf439dbeb092e72bea03747d314f7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d8cda93160134fd757feca5496d49863e2442f67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"532ed538_9aaf74a4","updated":"2024-01-19 08:01:44.000000000","message":"recheck network issues","commit_id":"0b3ed093eafdf439dbeb092e72bea03747d314f7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0585d46152d7a05536be2d2d8ab6b9aa6f89854c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e7593c6_aa2fd415","updated":"2024-01-19 21:14:54.000000000","message":"recheck strange error\n\n\u003e public endpoint for network service in RegionOne region not found","commit_id":"0b3ed093eafdf439dbeb092e72bea03747d314f7"}],"ironic/common/image_service.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6a0a71eb64d0d973dbf3849f5099234d39923195","unresolved":true,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"            # NOTE(dtantsur): os.link is supposed to follow symlinks, but it"},{"line_number":326,"context_line":"            # does not: https://github.com/python/cpython/issues/81793"},{"line_number":327,"context_line":"            if not os.path.islink(source_image_path):"},{"line_number":328,"context_line":"                try:"},{"line_number":329,"context_line":"                    os.link(source_image_path, dest_image_path)"},{"line_number":330,"context_line":"                except OSError as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d897d19_9bbc87f4","line":327,"updated":"2024-01-15 20:52:47.000000000","message":"Alternatively, I think you could do:\n\n    source_image_path \u003d os.path.realpath(source_image_path)\n\nand still get the efficiency benefits of the hard link.","commit_id":"9a3b2056262512b4c6ee4a9eb72f3bb9432b699d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c49064155aaacb44af173c73f0348dfe0d00c904","unresolved":true,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"            # NOTE(dtantsur): os.link is supposed to follow symlinks, but it"},{"line_number":326,"context_line":"            # does not: https://github.com/python/cpython/issues/81793"},{"line_number":327,"context_line":"            if not os.path.islink(source_image_path):"},{"line_number":328,"context_line":"                try:"},{"line_number":329,"context_line":"                    os.link(source_image_path, dest_image_path)"},{"line_number":330,"context_line":"                except OSError as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1475338c_f6829f10","line":327,"in_reply_to":"4d897d19_9bbc87f4","updated":"2024-01-18 15:37:45.000000000","message":"Nice idea!","commit_id":"9a3b2056262512b4c6ee4a9eb72f3bb9432b699d"}]}