)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df581a569c156c14b0fa4997ff145a916b7aad70","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Makes the partitioning layout moree consistent by having the root"},{"line_number":10,"context_line":"partition to always be the last partition (or first if no ephemeral"},{"line_number":11,"context_line":"or swap is specified), that also would enable tools like cloud-init to"},{"line_number":12,"context_line":"use the growroot utility to expand the root partition until the end of"},{"line_number":13,"context_line":"the disk."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXX%2F%2Ftn8%3D","line":11,"updated":"2014-04-28 14:23:48.000000000","message":"maybe it\u0027s my understanding of English, but I\u0027d rephrase it as \"if neither ephemeral nor swap is available\".","commit_id":"750068834f1737288ae200a04bee9a82877808db"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"17e455c12e2b30a174c6f5401ffee3b4786fe589","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Makes the partitioning layout moree consistent by having the root"},{"line_number":10,"context_line":"partition to always be the last partition (or first if no ephemeral"},{"line_number":11,"context_line":"or swap is specified), that also would enable tools like cloud-init to"},{"line_number":12,"context_line":"use the growroot utility to expand the root partition until the end of"},{"line_number":13,"context_line":"the disk."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_306f5f94","line":11,"in_reply_to":"AAAAXX%2F%2Ftn8%3D","updated":"2014-04-30 16:52:05.000000000","message":"This stood out to me as well: saying \"or first\" is slightly confusing because it contradicts \"be the last\". I think you mean it is the only partition in this case (which, of course, makes it both first and last). I would like to suggest the wording be clarified a bit:\n\n  Place root partition last so that it can always be expanded\n\n  Make the partitioning layout consistent by having the root partition always be the last partition. This enables tools like cloud-init\u0027s growroot utility to expand the root partition until the end of the disk, regardless of the presence of a swap or ephemeral partition. In the case where there is neither a swap nor ephemeral partition, the root partition is the only partition created.","commit_id":"750068834f1737288ae200a04bee9a82877808db"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"98007fe69ace72eba4db772ec00c5d8ab72c9744","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if swap_mb:"},{"line_number":99,"context_line":"        part_num \u003d dp.add_partition(swap_mb, fs_type\u003d\u0027linux-swap\u0027)"},{"line_number":100,"context_line":"        swap_part \u003d part_template % part_num"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    part_num \u003d dp.add_partition(root_mb)"},{"line_number":103,"context_line":"    root_part \u003d part_template % part_num"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_2402b73e","line":101,"updated":"2014-05-01 07:05:41.000000000","message":"Could we comment here to say that the root partition is deliberately last?  Or perhaps in the method docstring?  I think if the order is important, we should specify that here.","commit_id":"a3656bb286c2f1059aee0dc5ddfd75fd4b1fb5ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3b3f39c16981040eab1aca74757d807ece6ddb23","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if swap_mb:"},{"line_number":99,"context_line":"        part_num \u003d dp.add_partition(swap_mb, fs_type\u003d\u0027linux-swap\u0027)"},{"line_number":100,"context_line":"        swap_part \u003d part_template % part_num"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    part_num \u003d dp.add_partition(root_mb)"},{"line_number":103,"context_line":"    root_part \u003d part_template % part_num"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_7a5294de","line":101,"in_reply_to":"9ad9bd40_2402b73e","updated":"2014-05-01 09:08:22.000000000","message":"done","commit_id":"a3656bb286c2f1059aee0dc5ddfd75fd4b1fb5ba"}]}
