)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5f3a1c7ca1a0939940044b02798b342603e40dee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c64ce6ee_86cd8d42","updated":"2024-01-26 22:53:16.000000000","message":"Please fix pep8 issues then I\u0027ll give you a review :). I\u0027d also check locally (`tox -epy3`) to see if unit tests pass; I suspect we have some functional breaks here.","commit_id":"1536ad21316c7235055d410511f9534f64f8ad03"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"04302b830782fdaf7f6376cb1c17358ac27cff37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32f62bbf_5e339eed","updated":"2024-01-30 08:27:55.000000000","message":"thank you!","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"83093b6e212660fcfa72c3aee908ef4a49ea29e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16bd3d27_1f433180","updated":"2024-02-14 01:29:32.000000000","message":"recheck unrelated failure","commit_id":"949387bd80228a5923bf34ecc11d5a4a02b82716"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    Filter the list of returned nodes, and only return those containing"},{"line_number":293,"context_line":"    substring specified by ``description_contains``."},{"line_number":294,"context_line":"  in: query"},{"line_number":295,"context_line":"  required: false"},{"line_number":296,"context_line":"  type: string"},{"line_number":297,"context_line":"r_driver:"},{"line_number":298,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfe10c2a_d67525cd","line":295,"updated":"2024-01-30 17:25:54.000000000","message":"Fun...","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"doc/source/admin/drivers/irmc.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"  The format of a physical port ID is: ``\u003cCard Type\u003e\u003cSlot No\u003e-\u003cPort No\u003e`` where:"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"  - ``\u003cCard Type\u003e``: could be ``LAN``, ``FC`` or ``CAN``"},{"line_number":392,"context_line":"  - ``\u003cSlot No\u003e``: 0 indicates onboard slot. Use 1 to 9 for add-on slots."},{"line_number":393,"context_line":"  - ``\u003cPort No\u003e``: A port number starting from 1."},{"line_number":394,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bb3e6f0d_9b2cafc3","line":391,"updated":"2024-01-30 17:25:54.000000000","message":"From a quick grepping in the iRMC code, this change seems invalid to me.","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"doc/source/admin/troubleshooting.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":683,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"What is likely occurring"},{"line_number":686,"context_line":"----------------------------------------"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"The image attempting to be deployed likely is a partition image where"},{"line_number":689,"context_line":"the file system that the user wishes to boot from lacks the required"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fd4c30c3_113d051c","line":686,"updated":"2024-01-30 17:25:54.000000000","message":"Please match the length of the title","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"doc/source/contributor/deploy-steps.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    from ironic.drivers import base"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    class myriad(base.RAIDInterface):"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":297,"context_line":"            \u0027create_root_volume\u0027: {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a6e5b32_3d953cbe","line":294,"updated":"2024-01-30 17:25:54.000000000","message":"This is not right (feel free to change to something less ambiguous).","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"doc/source/install/configure-pxe.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":501,"context_line":"logging, ``ipa-inspection-collectors`` to customize the inspection process,"},{"line_number":502,"context_line":"or ``ipa-api-url`` to enable :doc:`/admin/fast-track`)."},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"Second, you need to configure DHCP for unknowns hosts since the OpenStack"},{"line_number":505,"context_line":"Networking service won\u0027t be able to handle them. For instance, you can install"},{"line_number":506,"context_line":"**dnsmasq** and use the following ``/etc/dnsmasq.conf``:"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8e5291f9_d122f1a1","line":504,"updated":"2024-01-30 17:25:54.000000000","message":"Weird replacement, should be \"unknown\"","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"ironic/api/controllers/v1/allocation.py":[{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"b2959709e501784e64b3f5f7a5bde995ee21df38","unresolved":true,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        self._check_allowed_allocation_fields(fields)"},{"line_number":277,"context_line":"        if owner is not None and not api_utils.allow_allocation_owner():"},{"line_number":278,"context_line":"            # Requestor has asked for an owner field/column match, but"},{"line_number":279,"context_line":"            # their client version does not support it."},{"line_number":280,"context_line":"            raise exception.NotAcceptable()"},{"line_number":281,"context_line":"        if (owner is not None"}],"source_content_type":"text/x-python","patch_set":1,"id":"0269e5de_9f53eb8e","side":"PARENT","line":278,"updated":"2024-01-29 21:40:43.000000000","message":"Changing from British to American English. Since it is a local var change it should be fine.","commit_id":"54a82d2b6dac45cec9cbd9cd980c8fbe6be056c4"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"7d69f4155702f6ea779f62b0c3966eecd18d9439","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        self._check_allowed_allocation_fields(fields)"},{"line_number":277,"context_line":"        if owner is not None and not api_utils.allow_allocation_owner():"},{"line_number":278,"context_line":"            # Requestor has asked for an owner field/column match, but"},{"line_number":279,"context_line":"            # their client version does not support it."},{"line_number":280,"context_line":"            raise exception.NotAcceptable()"},{"line_number":281,"context_line":"        if (owner is not None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1677e842_4365bbc8","side":"PARENT","line":278,"in_reply_to":"0269e5de_9f53eb8e","updated":"2024-02-05 05:04:13.000000000","message":"Done","commit_id":"54a82d2b6dac45cec9cbd9cd980c8fbe6be056c4"}],"ironic/common/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \"\"\"Determine if a logical name is valid."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    The logical name may only consist of RFC3986 unreserved"},{"line_number":118,"context_line":"    characters, to with:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        ALPHA / DIGIT / \"-\" / \".\" / \"_\" / \"~\""},{"line_number":121,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"38d480a7_359771c1","line":118,"updated":"2024-01-30 17:25:54.000000000","message":"I was also unfamiliar with the expression \"to wit\", but the correct replacement would be \"namely\"","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9755f03bfffe86d591fe22bdf1288a43db8d0f7d","unresolved":true,"context_lines":[{"line_number":115,"context_line":"    \"\"\"Determine if a logical name is valid."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    The logical name may only consist of RFC3986 unreserved"},{"line_number":118,"context_line":"    characters, to with:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        ALPHA / DIGIT / \"-\" / \".\" / \"_\" / \"~\""},{"line_number":121,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"57da6e02_2d26e75b","line":118,"in_reply_to":"38d480a7_359771c1","updated":"2024-01-30 17:35:13.000000000","message":"Even better: just s/, to wit/ altogether.\n\n\"The logical name may only consist of RFC 3986 unreserved characters:\n   [list of characters]\"\n   \n is more terse and probably easier to understand IMO","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"7d69f4155702f6ea779f62b0c3966eecd18d9439","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \"\"\"Determine if a logical name is valid."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    The logical name may only consist of RFC3986 unreserved"},{"line_number":118,"context_line":"    characters, to with:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        ALPHA / DIGIT / \"-\" / \".\" / \"_\" / \"~\""},{"line_number":121,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"e9e709d3_d3ff9aef","line":118,"in_reply_to":"57da6e02_2d26e75b","updated":"2024-02-05 05:04:13.000000000","message":"Done","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          \"and its physical ID like \u0027\u003cUUID\u003e:\u003cPhysical ID\u003e,...\u0027. The resources \""},{"line_number":74,"context_line":"          \"are Ports and Volume connectors. The Physical ID consists of card \""},{"line_number":75,"context_line":"          \"type, slot No, and port No. The format is \""},{"line_number":76,"context_line":"          \"{LAN|FC|CAN}\u003cslot-No\u003e-\u003cPort-No\u003e. This parameter is necessary for \""},{"line_number":77,"context_line":"          \"booting a node from a remote volume. Optional.\"),"},{"line_number":78,"context_line":"    \u0027irmc_storage_network_size\u0027:"},{"line_number":79,"context_line":"        _(\"Size of the network for iSCSI storage network. This is the size of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"fe47ebbf_63d88915","line":76,"updated":"2024-01-30 17:25:54.000000000","message":"Wrong here too","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"ironic/tests/unit/api/test_rbac_project_scoped.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# they can determine that something is special, something is different,"},{"line_number":25,"context_line":"# and from there try to determine *what* it is. The key in their case"},{"line_number":26,"context_line":"# is the ID values, but they don\u0027t know that from the outside."},{"line_number":27,"context_line":"# This is also why this party admins should get 200s and empty lists,"},{"line_number":28,"context_line":"# again the database query should be filtered. Third party admin,"},{"line_number":29,"context_line":"# in essence serves as the primary negative test."},{"line_number":30,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1c0d2c9f_d713c64e","line":27,"updated":"2024-01-30 17:25:54.000000000","message":"Has to be \"third\"","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}],"ironic/tests/unit/common/test_kickstart_utils.py":[{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"4f6c7efe6138a523365f59c60d86e579a1aa9855","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    \u0027vxan0R84Yxpx+2nngvf7ptPWTx15eHbmjF741QLXPScU4aVsKVuFXC9bAR1mJ\u0027"},{"line_number":44,"context_line":"    \u0027eGr/n8b2WxfS1+NWLqUbMrYVOTFXj61ZMpeFizHk77pdiDSvhckxlYTGe0Yrv\u0027"},{"line_number":45,"context_line":"    # cs_ign: Codespell Ignore"},{"line_number":46,"context_line":"    \u00270GZsYzWWrZctTd8eXSHxH/GfZ8j/duM/AAAA8MxKymfsxfj/THi5TO09zg6nw\u0027 # cs_ign"},{"line_number":47,"context_line":"    \u00276sxZybc2NkeDraH4cXwSvn6y/5wcGfo2gEAAMDTM/4Pxf+vT4rxf/RySA6O/6\u0027"},{"line_number":48,"context_line":"    \u0027NXw8z++D96JcwY/wMAAMDTNv5Px38FOBdeG6WOzGSbC2+E4rn/eA7gsDw6PBt\u0027"},{"line_number":49,"context_line":"    \u0027eH+V+Wc6BG5TlAQAAgBM5/g/F2idJMf6PXismABwd/0dvFBMBDo//Q7FEz4zx\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"801432c1_6d2fdd8c","line":46,"updated":"2024-02-05 05:25:12.000000000","message":"This is not my favourite hack in the world, but it works. \n\nSee https://review.opendev.org/c/openstack/ironic/+/906807/4/setup.cfg for where it is implemented in the next commit in the chain.","commit_id":"6d84c07e0b1739cfa9bcc4e77551b7e9d776d824"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"78503ffa3067051de49cb793d3150e06ec413187","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \u0027vxan0R84Yxpx+2nngvf7ptPWTx15eHbmjF741QLXPScU4aVsKVuFXC9bAR1mJ\u0027"},{"line_number":44,"context_line":"    \u0027eGr/n8b2WxfS1+NWLqUbMrYVOTFXj61ZMpeFizHk77pdiDSvhckxlYTGe0Yrv\u0027"},{"line_number":45,"context_line":"    # cs_ign: Codespell Ignore"},{"line_number":46,"context_line":"    \u00270GZsYzWWrZctTd8eXSHxH/GfZ8j/duM/AAAA8MxKymfsxfj/THi5TO09zg6nw\u0027 # cs_ign"},{"line_number":47,"context_line":"    \u00276sxZybc2NkeDraH4cXwSvn6y/5wcGfo2gEAAMDTM/4Pxf+vT4rxf/RySA6O/6\u0027"},{"line_number":48,"context_line":"    \u0027NXw8z++D96JcwY/wMAAMDTNv5Px38FOBdeG6WOzGSbC2+E4rn/eA7gsDw6PBt\u0027"},{"line_number":49,"context_line":"    \u0027eH+V+Wc6BG5TlAQAAgBM5/g/F2idJMf6PXismABwd/0dvFBMBDo//Q7FEz4zx\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"269a730a_dccf9c6a","line":46,"in_reply_to":"801432c1_6d2fdd8c","updated":"2024-02-10 00:16:14.000000000","message":"Done","commit_id":"6d84c07e0b1739cfa9bcc4e77551b7e9d776d824"}],"tools/test-setup.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ca9f671f2ce173733e0d46638cc59664c697b411","unresolved":false,"context_lines":[{"line_number":63,"context_line":"sudo cat $PG_HBA"},{"line_number":64,"context_line":"sudo cat $PG_CONF"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# restart postgres when new HBA file is loaded"},{"line_number":67,"context_line":"sudo systemctl stop postgresql || true"},{"line_number":68,"context_line":"sudo systemctl start postgresql || true"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"e8e9bcd9_382a96de","line":66,"updated":"2024-01-30 17:25:54.000000000","message":"Hard to tell what that used to mean..","commit_id":"e4de9008122d24d78670df39f32f02a886cb1b66"}]}