)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6105c3ad032a3d4dd5707483574de6c66b84837e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cfe4e38a_565a5cdf","updated":"2024-02-07 15:50:52.000000000","message":"Given the intent to remove the legacy inspector support, we likely also need to have a status check which can just signal a warning \"this option is going away!\" but most likely cannot exactly do that until there is parity though.\n\n-1 to signal a need to enhance the reno so we hopefully semi-avoid people getting stuck mid-upgrade.","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c889f30f1889042ca64b637e478cdc90f6eba7a6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe64bc10_1456ef2a","updated":"2024-02-07 20:37:56.000000000","message":"Might be wise to link to any post-separate-service inspector docs in the release note, too?","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71bc0b7da47fcf51dbf70c72733c9ab21e979c48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"492ab30d_f93c2c61","updated":"2024-02-21 11:13:04.000000000","message":"Forgot to post some drafts.","commit_id":"8dd09d396281d4990abe56a1be6f4f20cefcd4bf"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6105c3ad032a3d4dd5707483574de6c66b84837e","unresolved":true,"context_lines":[{"line_number":2003,"context_line":"                  migrated (at the beginning of this call) and 2. the number"},{"line_number":2004,"context_line":"                  of migrated objects."},{"line_number":2005,"context_line":"        \"\"\""},{"line_number":2006,"context_line":"        if (\u0027agent\u0027 not in CONF.enabled_inspect_interfaces"},{"line_number":2007,"context_line":"                or \u0027inspector\u0027 in CONF.enabled_inspect_interfaces):"},{"line_number":2008,"context_line":"            return 0, 0"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"        model \u003d models.Node"},{"line_number":2011,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f3369042_14bc6d80","line":2008,"range":{"start_line":2006,"start_character":0,"end_line":2008,"end_character":23},"updated":"2024-02-07 15:50:52.000000000","message":"It occurs to me, later on, and it might make sense to put a note in now... that we might want to change this up once \u0027inspector\u0027 disappears, to return a total number to migrate as well as a signal there is a need to migrate, we just can\u0027t do so. Also, obviously, we would need an upgrade status check to signal in advance with a warning, and switch to an error result the interface is gone.","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71bc0b7da47fcf51dbf70c72733c9ab21e979c48","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"                  migrated (at the beginning of this call) and 2. the number"},{"line_number":2004,"context_line":"                  of migrated objects."},{"line_number":2005,"context_line":"        \"\"\""},{"line_number":2006,"context_line":"        if (\u0027agent\u0027 not in CONF.enabled_inspect_interfaces"},{"line_number":2007,"context_line":"                or \u0027inspector\u0027 in CONF.enabled_inspect_interfaces):"},{"line_number":2008,"context_line":"            return 0, 0"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"        model \u003d models.Node"},{"line_number":2011,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6e63bb7d_04ad4e2e","line":2008,"range":{"start_line":2006,"start_character":0,"end_line":2008,"end_character":23},"in_reply_to":"f3369042_14bc6d80","updated":"2024-02-21 11:13:04.000000000","message":"Once inspector disappears, \u0027inspector\u0027 in CONF.enabled_inspect_interfaces will no longer be true, right? I mean, you won\u0027t pass the (to be created) upgrade check with that.","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6105c3ad032a3d4dd5707483574de6c66b84837e","unresolved":true,"context_lines":[{"line_number":2021,"context_line":"        no_states \u003d [states.INSPECTING, states.INSPECTWAIT, states.INSPECTFAIL]"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        with _session_for_write() as session:"},{"line_number":2024,"context_line":"            query \u003d session.query(model).filter("},{"line_number":2025,"context_line":"                sql.and_(model.inspect_interface \u003d\u003d \u0027inspector\u0027,"},{"line_number":2026,"context_line":"                         model.provision_state.not_in(no_states)))"},{"line_number":2027,"context_line":"            # NOTE(rloo) Caution here; after doing query.count(), it is"},{"line_number":2028,"context_line":"            #            possible that the value is different in the"},{"line_number":2029,"context_line":"            #            next invocation of the query."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fa809de_c4830da4","line":2026,"range":{"start_line":2024,"start_character":0,"end_line":2026,"end_character":66},"updated":"2024-02-07 15:50:52.000000000","message":"Just an aside: it makes sense to exclude in flight items, but we likely need to ensure in any upgrade note that ideally inspections should not be in flight and any nodes in inspectfail need to be resolved (removed) from that state prior to upgrading.\n\nOtherwise, the risk is someone loops the online upgrade job and actually freezes their upgrade on it...","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71bc0b7da47fcf51dbf70c72733c9ab21e979c48","unresolved":false,"context_lines":[{"line_number":2021,"context_line":"        no_states \u003d [states.INSPECTING, states.INSPECTWAIT, states.INSPECTFAIL]"},{"line_number":2022,"context_line":""},{"line_number":2023,"context_line":"        with _session_for_write() as session:"},{"line_number":2024,"context_line":"            query \u003d session.query(model).filter("},{"line_number":2025,"context_line":"                sql.and_(model.inspect_interface \u003d\u003d \u0027inspector\u0027,"},{"line_number":2026,"context_line":"                         model.provision_state.not_in(no_states)))"},{"line_number":2027,"context_line":"            # NOTE(rloo) Caution here; after doing query.count(), it is"},{"line_number":2028,"context_line":"            #            possible that the value is different in the"},{"line_number":2029,"context_line":"            #            next invocation of the query."}],"source_content_type":"text/x-python","patch_set":1,"id":"6007e3b1_8c6bfbc4","line":2026,"range":{"start_line":2024,"start_character":0,"end_line":2026,"end_character":66},"in_reply_to":"9fa809de_c4830da4","updated":"2024-02-21 11:13:04.000000000","message":"Yep, will update.","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"}],"releasenotes/notes/migrate-inspector-48de1216ef81f43a.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6105c3ad032a3d4dd5707483574de6c66b84837e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds an online migration to the new inspection interface. If the ``agent``"},{"line_number":5,"context_line":"    inspection is enabled and the ``inspector`` inspection is disabled,"},{"line_number":6,"context_line":"    the ``inspect_interface`` field will be updated for all nodes that are"},{"line_number":7,"context_line":"    currently not on inspection."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6483c1db_c226cd46","line":7,"updated":"2024-02-07 15:50:52.000000000","message":"Lets add some further guidance here in regards to the anticipated states, so hopefully people don\u0027t attempt to upgrade with in/flight and failed inspections.","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71bc0b7da47fcf51dbf70c72733c9ab21e979c48","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds an online migration to the new inspection interface. If the ``agent``"},{"line_number":5,"context_line":"    inspection is enabled and the ``inspector`` inspection is disabled,"},{"line_number":6,"context_line":"    the ``inspect_interface`` field will be updated for all nodes that are"},{"line_number":7,"context_line":"    currently not on inspection."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"242ef8f9_31449bef","line":7,"in_reply_to":"6483c1db_c226cd46","updated":"2024-02-21 11:13:04.000000000","message":"Done","commit_id":"ad7903e1fd4c91944d7a2c9374346965d1b3cb9d"}]}