)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7ad2e6f63aeb9042c9fab813e3c7419bbc242ff0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab96737c_c016942d","updated":"2024-03-04 18:00:43.000000000","message":"This will need an alembic migration as well. https://opendev.org/openstack/ironic/src/branch/master/ironic/db/sqlalchemy/alembic","commit_id":"b2f7e504d76dccd3a991d68d9232122237cf4241"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a32a598d51c317179585156922e993ce865da83b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7ebb616_8a8cc14b","updated":"2024-03-06 17:26:01.000000000","message":"Please add a test for the added migration.","commit_id":"13240b11ec070d311146a80602e67e2657c89179"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"10459431264cca7cec5e6f62953d9e9581bc8768","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cc2bc8d3_93c120b5","updated":"2024-03-07 16:34:25.000000000","message":"Test failures appear unrelated. Not issuing a recheck because some of them look like potential CI config issues.","commit_id":"45b37f143f0815b6650dc6c20a74daee793b113e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"47540865ffbd0e0728dd824e015b46dd5bc8520d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"337cadc0_642934b2","updated":"2024-03-07 16:37:48.000000000","message":"recheck could not resolve mirror.dfw.rackspace.opendev.org","commit_id":"45b37f143f0815b6650dc6c20a74daee793b113e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2a64b1d26abc12883cd32e25c47b3cebc4131890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb59e572_002f9ae0","updated":"2024-03-07 19:14:06.000000000","message":"recheck infra fixed the mirror issue; my last recheck was a little early 😊","commit_id":"45b37f143f0815b6650dc6c20a74daee793b113e"}],"ironic/db/sqlalchemy/alembic/versions/01f21d5e5195_increase_length_of_user_column.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a32a598d51c317179585156922e993ce865da83b","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.alter_column(\u0027node_history\u0027, \u0027user\u0027,"},{"line_number":32,"context_line":"                    existing_type\u003dmysql.VARCHAR(length\u003d32),"},{"line_number":33,"context_line":"                    type_\u003dsa.String(length\u003d64),"},{"line_number":34,"context_line":"                    existing_nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f949ace3_ae45be54","line":32,"updated":"2024-03-06 17:26:01.000000000","message":"We also support postgres migrations in Ironic, that means we can\u0027t use mysql-specific types here. I think this is likely an `sa.String(length\u003d32)`.\n\n^^^ I wrote this, and then later looked at more code, where we *do* reference mysql types directly. I\u0027m not sure what the right path is here.","commit_id":"13240b11ec070d311146a80602e67e2657c89179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4d3cbde43d125a89ad37744cd87d16a9aa65062","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.alter_column(\u0027node_history\u0027, \u0027user\u0027,"},{"line_number":32,"context_line":"                    existing_type\u003dmysql.VARCHAR(length\u003d32),"},{"line_number":33,"context_line":"                    type_\u003dsa.String(length\u003d64),"},{"line_number":34,"context_line":"                    existing_nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0df5e718_51155ad1","line":32,"in_reply_to":"e74c3405_a67d3f55","updated":"2024-03-08 13:37:48.000000000","message":"I\u0027d also expect String(32). Does it fail?","commit_id":"13240b11ec070d311146a80602e67e2657c89179"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"668ca2e21bcd58fd3e9f6305910dfa05cb4558e4","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def upgrade():"},{"line_number":31,"context_line":"    op.alter_column(\u0027node_history\u0027, \u0027user\u0027,"},{"line_number":32,"context_line":"                    existing_type\u003dmysql.VARCHAR(length\u003d32),"},{"line_number":33,"context_line":"                    type_\u003dsa.String(length\u003d64),"},{"line_number":34,"context_line":"                    existing_nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e74c3405_a67d3f55","line":32,"in_reply_to":"f949ace3_ae45be54","updated":"2024-03-06 17:45:39.000000000","message":"I asked in IRC:\n\n\n09:27 \u003cTheJulia\u003e JayF: mysql has a nuance I\u0027m trying to remember\n09:28 \u003cTheJulia\u003e I think postgres doesn\u0027t actually enforce stringfield lengths\n09:28 \u003cTheJulia\u003e it does it by types if memory serves\n09:28 \u003cTheJulia\u003e easy enough to test in migration test code\n\nso I think this might be the right thing? Just do your unit test and it\u0027ll show quickly if not","commit_id":"13240b11ec070d311146a80602e67e2657c89179"}],"releasenotes/notes/increase_node_history_user_column_limit-8da6ae03288bff26.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a32a598d51c317179585156922e993ce865da83b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Increases the 32-character limit of the ``user`` column in the"},{"line_number":5,"context_line":"    ``NodeHistory`` model to support up to 64-character-long values."},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    For more information, see `https://bugs.launchpad.net/ironic/+bug/2054594`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"67d47838_06bed0ee","line":7,"updated":"2024-03-06 17:26:01.000000000","message":"This is invalid syntax.\n\n1) Please remove whitespace on line 6\n2) Please use correct RST syntax: \\`link description\n    \u003chttps://my.link/path/to/bug/1234\u003e\\`__","commit_id":"13240b11ec070d311146a80602e67e2657c89179"}]}