)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0c1b677a2987d02fbb8138d0f74563be370bb31b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":80,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":81,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027neutron_wait_time\u0027,"},{"line_number":83,"context_line":"               default\u003d15,"},{"line_number":84,"context_line":"               help\u003d\u0027Seconds to wait for Neutron agents to finish applying \u0027"},{"line_number":85,"context_line":"                    \u0027requested PXE configuration during provisioning with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_236ab71a","line":82,"updated":"2014-04-29 21:44:32.000000000","message":"I hesitate to add a config option that is merely for a temporary work-around -- I\u0027d rather introduce a module constant if there is a reasonable expectation that this can be addressed during Juno.","commit_id":"aad12bd00a8dd046b3eb5e72f2fb564891ad96b8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b155cb9a4180792c8952cf0ab5a2a7a6b4e1b26c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":81,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027neutron_wait_time\u0027,"},{"line_number":83,"context_line":"               default\u003d15,"},{"line_number":84,"context_line":"               help\u003d\u0027Seconds to wait for Neutron agents to finish applying \u0027"},{"line_number":85,"context_line":"                    \u0027requested PXE configuration during provisioning with \u0027"},{"line_number":86,"context_line":"                    \u0027SSHPower driver.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_7e9f0804","line":83,"updated":"2014-04-30 08:43:18.000000000","message":"I agree with @Devananda, I don\u0027t think we should add a config option to a workaround.\n\nAlso, I wonder how much time is enough, 15 seconds? I remember we had another review fixing this problem and that one the sleep time was 30 seconds[1]...15 seconds is enough for things get propagate within neutron? How is this number measured ?\n\n[1] https://review.openstack.org/#/c/84361/","commit_id":"aad12bd00a8dd046b3eb5e72f2fb564891ad96b8"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0c1b677a2987d02fbb8138d0f74563be370bb31b","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    # for synchronizing events with Neutron.  We need to sleep only if we are"},{"line_number":506,"context_line":"    # booting VMs, to ensure they do not boot before Neutron agents have setup"},{"line_number":507,"context_line":"    # sufficent DHCP config for netboot."},{"line_number":508,"context_line":"    driver \u003d driver_factory.get_driver(node.driver)"},{"line_number":509,"context_line":"    if isinstance(driver.power, ssh.SSHPower):"},{"line_number":510,"context_line":"        secs \u003d CONF.pxe.neutron_wait_time"},{"line_number":511,"context_line":"        LOG.debug(_(\"Waiting %(secs)d seconds for Neutron.\"), {\u0027secs\u0027: secs})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_a3cc0737","line":508,"updated":"2014-04-29 21:44:32.000000000","message":"this doesn\u0027t need to call driver_factor to load the driver -- it\u0027s already loaded by TaskManager. Access it like this:\n\n  if isinstance(task.driver.power, ssh.SSHPower):\n    ..","commit_id":"aad12bd00a8dd046b3eb5e72f2fb564891ad96b8"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0c1b677a2987d02fbb8138d0f74563be370bb31b","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        \"\"\""},{"line_number":608,"context_line":"        # TODO(yuriyz): more secure way needed for pass auth token"},{"line_number":609,"context_line":"        #               to deploy ramdisk"},{"line_number":610,"context_line":"        _create_token_file(task, node)"},{"line_number":611,"context_line":"        _update_neutron(task, node)"},{"line_number":612,"context_line":"        manager_utils.node_set_boot_device(task, node, \u0027pxe\u0027, persistent\u003dTrue)"},{"line_number":613,"context_line":"        manager_utils.node_power_action(task, node, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_c36d8b06","line":610,"updated":"2014-04-29 21:44:32.000000000","message":"I think I would prefer the wait-hook be added here, as a post-step, so that it is more visible and not buried inside the update.\n\nAlternately, I think factoring all the _update_neutron and _wait_for_neutron calls out into a utility would be good. The agent driver will have the same dependency when used with Neutron, so this will need to be split out anyway.","commit_id":"aad12bd00a8dd046b3eb5e72f2fb564891ad96b8"}]}
