)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03c93df7_445a6b4e","updated":"2024-03-11 10:06:53.000000000","message":"I like the direction here, just a few minor issues inline.","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"475993d227f649d0de104211be01185cc33cd20a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7036de57_02da151d","updated":"2024-03-14 01:18:02.000000000","message":"Lgtm","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d62cc202163127a2e0d6deb8e643b91a6aafe3df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63dc8560_f6831561","updated":"2024-03-14 11:47:53.000000000","message":"Metalsmith is broken, will wait to recheck after the patches moving to no voting merges","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7391e43bfa85dd7d878e3ff3b9c92acb5ee2330d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f9705ef_5fd1b96f","updated":"2024-03-14 19:44:14.000000000","message":"recheck ironic-tempest-uefi-redfish-vmedia failed with basic ops with partition image","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"25fa63657d2bd1a49384a059caddb3bab7bbd820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"603cc4c9_19e054fd","updated":"2024-03-14 16:13:52.000000000","message":"recheck metal3-integration (locally it\u0027s ok)","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"402eb138ef38415e1a731f28e02aff93e3180d12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66fffd36_32242f0a","updated":"2024-03-14 14:30:28.000000000","message":"recheck metalsmith is non-voting now","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"}],"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    try:"},{"line_number":177,"context_line":"        system.virtual_media"},{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3bc72da4_cb011dee","line":179,"updated":"2024-03-11 10:06:53.000000000","message":"Please also handle the normal AttributeError (in case of older sushy version in backports)","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a422331e80a06c2799015002c1b0b3daaf9677c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    try:"},{"line_number":177,"context_line":"        system.virtual_media"},{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7cb69293_b247b79c","line":179,"in_reply_to":"1820b503_3810fe34","updated":"2024-03-11 18:20:01.000000000","message":"Now I understood \"normal AttributeError\" you mean the Built-in Exception in Python \u003d), ack!","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5680b6a5f948abfb637d6126f3542ff82387de62","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    try:"},{"line_number":177,"context_line":"        system.virtual_media"},{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae9986d_267c48fb","line":179,"in_reply_to":"3bc72da4_cb011dee","updated":"2024-03-11 16:47:21.000000000","message":"So, I was checking sushy and couldn\u0027t find AttributeError, \nwe are already checking here for Missing https://opendev.org/openstack/sushy/src/branch/master/sushy/exceptions.py#L41 and this would be the case no?","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f17a00d36ff2e288fda350a8a673274c1cd58090","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    try:"},{"line_number":177,"context_line":"        system.virtual_media"},{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1820b503_3810fe34","line":179,"in_reply_to":"dae9986d_267c48fb","updated":"2024-03-11 17:23:38.000000000","message":"What happens with older sushy where System.virtual_media simply does not exist?","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":true,"context_lines":[{"line_number":310,"context_line":"        if ejected:"},{"line_number":311,"context_line":"            found \u003d True"},{"line_number":312,"context_line":"    else:"},{"line_number":313,"context_line":"        for manager in managers:"},{"line_number":314,"context_line":"            ejected \u003d _eject_vmedia_from_resource(task, resource\u003dmanager,"},{"line_number":315,"context_line":"                                                  boot_device\u003dboot_device)"},{"line_number":316,"context_line":"            if ejected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"627feda9_d10cf05d","line":313,"updated":"2024-03-11 10:06:53.000000000","message":"I\u0027d prefer we try ejecting from both System and Manager (only ejecting, not inserting). The reason is upgrades: imagine you deploy a Node with the ramdisk deploy (or start the ramdisk using fast-track). It will get a CD connected (via Managers) and stay in this state. If the operator upgrades Ironic, we may lose track of this connected CD (depending on how the BMC is implemented).","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5680b6a5f948abfb637d6126f3542ff82387de62","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        if ejected:"},{"line_number":311,"context_line":"            found \u003d True"},{"line_number":312,"context_line":"    else:"},{"line_number":313,"context_line":"        for manager in managers:"},{"line_number":314,"context_line":"            ejected \u003d _eject_vmedia_from_resource(task, resource\u003dmanager,"},{"line_number":315,"context_line":"                                                  boot_device\u003dboot_device)"},{"line_number":316,"context_line":"            if ejected:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b470298_65c240d7","line":313,"in_reply_to":"627feda9_d10cf05d","updated":"2024-03-11 16:47:21.000000000","message":"Right, based on the discussion on the irc we will go with the path:\n check if VirtualMedia is available in System (if yes, eject), \n check if VirtualMedia is available in Managers (if yes, eject)","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cad796e4fb67dbd374be4b8a06c23c711398bdeb","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":"    except AttributeError:"},{"line_number":182,"context_line":"        # NOTE(wncslln): In case of older versions of sushy are"},{"line_number":183,"context_line":"        # used."},{"line_number":184,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"e649fa3b_de87c21d","line":181,"updated":"2024-03-14 18:25:34.000000000","message":"nit: you can list several exceptions in brackets\n\n except (sushy.exceptions.MissingAttributeError, AttributeError):","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"},{"author":{"_account_id":36630,"name":"Winicius Allan Bezerra da Silva","display_name":"Winicius Allan","email":"winiciusab12@gmail.com","username":"winiciusallan"},"change_message_id":"a1f8c54bf6a969247e438dbd05987e452e6b1a45","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        return True"},{"line_number":179,"context_line":"    except sushy.exceptions.MissingAttributeError:"},{"line_number":180,"context_line":"        return False"},{"line_number":181,"context_line":"    except AttributeError:"},{"line_number":182,"context_line":"        # NOTE(wncslln): In case of older versions of sushy are"},{"line_number":183,"context_line":"        # used."},{"line_number":184,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"d431d79a_e3bba30e","line":181,"in_reply_to":"e649fa3b_de87c21d","updated":"2024-03-14 20:59:56.000000000","message":"Acknowledged","commit_id":"6d046ad7b403f3ea9c6b0fcdde52968794d4cb3a"}],"releasenotes/notes/add-vmedia-system-support-5d81316d02b909b9.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows boot using virtual media via ``System`` resource. For more"},{"line_number":5,"context_line":"    informations, you can see `bug 2039458"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/sushy/+bug/2039458\u003e`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ea5fb673_2f527f2d","line":4,"updated":"2024-03-11 10:06:53.000000000","message":"This should mention Redfish, otherwise the context is not clear. Since it\u0027s a bug fix, I\u0027d reframe it is \"Fixes Redfish virtual media boot on BMCs that only expose the VirtualMedia resource on Systems instead of Managers\"","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7b7c79749a5ce951e14844a899bd496170863dfd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows boot using virtual media via ``System`` resource. For more"},{"line_number":5,"context_line":"    informations, you can see `bug 2039458"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/sushy/+bug/2039458\u003e`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"66827471_8670adeb","line":4,"in_reply_to":"38ca1378_dbd8eb93","updated":"2024-03-14 01:14:23.000000000","message":"Done","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5680b6a5f948abfb637d6126f3542ff82387de62","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows boot using virtual media via ``System`` resource. For more"},{"line_number":5,"context_line":"    informations, you can see `bug 2039458"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/sushy/+bug/2039458\u003e`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"38ca1378_dbd8eb93","line":4,"in_reply_to":"ea5fb673_2f527f2d","updated":"2024-03-11 16:47:21.000000000","message":"++ makes sense to me","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows boot using virtual media via ``System`` resource. For more"},{"line_number":5,"context_line":"    informations, you can see `bug 2039458"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/sushy/+bug/2039458\u003e`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0580e306_83512388","line":6,"updated":"2024-03-11 10:06:53.000000000","message":"Invalid link format, missing underscore after the closing tick (`text \u003curl\u003e`_)","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7b7c79749a5ce951e14844a899bd496170863dfd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows boot using virtual media via ``System`` resource. For more"},{"line_number":5,"context_line":"    informations, you can see `bug 2039458"},{"line_number":6,"context_line":"    \u003chttps://bugs.launchpad.net/sushy/+bug/2039458\u003e`"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a0016dd2_e73ba5e9","line":6,"in_reply_to":"0580e306_83512388","updated":"2024-03-14 01:14:23.000000000","message":"Done","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"}],"requirements.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7e601efa8d4f23dc301ca0a9c86380bc560741ef","unresolved":true,"context_lines":[{"line_number":46,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":47,"context_line":"tooz\u003e\u003d2.7.0 # Apache-2.0"},{"line_number":48,"context_line":"openstacksdk\u003e\u003d0.48.0 # Apache-2.0"},{"line_number":49,"context_line":"sushy\u003e\u003d4.8.0"},{"line_number":50,"context_line":"construct\u003e\u003d2.9.39 # MIT"},{"line_number":51,"context_line":"netaddr\u003e\u003d0.9.0 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"6f08da21_8546d7f3","line":49,"updated":"2024-03-11 10:06:53.000000000","message":"Just a note: this should not be a part of the backport.","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5680b6a5f948abfb637d6126f3542ff82387de62","unresolved":false,"context_lines":[{"line_number":46,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":47,"context_line":"tooz\u003e\u003d2.7.0 # Apache-2.0"},{"line_number":48,"context_line":"openstacksdk\u003e\u003d0.48.0 # Apache-2.0"},{"line_number":49,"context_line":"sushy\u003e\u003d4.8.0"},{"line_number":50,"context_line":"construct\u003e\u003d2.9.39 # MIT"},{"line_number":51,"context_line":"netaddr\u003e\u003d0.9.0 # BSD"}],"source_content_type":"text/plain","patch_set":1,"id":"61c7142d_dcecb4d4","line":49,"in_reply_to":"6f08da21_8546d7f3","updated":"2024-03-11 16:47:21.000000000","message":"I will take care of the backports and keep this in mind.","commit_id":"ef44ce2ec9353782ad32cc7f0a3de5b1c6ab8431"}]}