)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6144801ab8b67a9834b5edf23387ddd95d66716f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"It does not quite work today:"},{"line_number":10,"context_line":"1) Validation is not aware of reserved steps"},{"line_number":11,"context_line":"1.1) ... and does not return them as part of validated steps."},{"line_number":12,"context_line":"2) Unholding relies on heartbeats, but they won\u0027t happen if"},{"line_number":13,"context_line":"   requires_ramdisk is False."},{"line_number":14,"context_line":"3) Tear down is called twice causing an ugly traceback from automaton"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic66fa0fe9d32554f8e7cd23abeeb9c0ec5b9556d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bd8a82af_4f2e35b0","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":29},"updated":"2024-03-27 15:31:17.000000000","message":"err, ugh. Okay, this seems to be the last piece missing from the change set?","commit_id":"72935c5db013d23afa83003fce8ae51d62fe0f44"}],"ironic/conductor/manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6144801ab8b67a9834b5edf23387ddd95d66716f","unresolved":true,"context_lines":[{"line_number":1330,"context_line":"                    callback\u003dself._spawn_worker,"},{"line_number":1331,"context_line":"                    call_args\u003d(servicing.continue_node_service, task),"},{"line_number":1332,"context_line":"                    err_handler\u003dutils.servicing_error_handler)"},{"line_number":1333,"context_line":"                return"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"            try:"},{"line_number":1336,"context_line":"                task.process_event(action)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a434c631_4e31981c","line":1333,"updated":"2024-03-27 15:31:17.000000000","message":"good catch, likely just a unit test needed.","commit_id":"72935c5db013d23afa83003fce8ae51d62fe0f44"}],"ironic/conductor/servicing.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6144801ab8b67a9834b5edf23387ddd95d66716f","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    steps \u003d node.driver_internal_info.get(\u0027service_steps\u0027, [])"},{"line_number":89,"context_line":"    if not steps:"},{"line_number":90,"context_line":"        _tear_down_node_service(task, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":91,"context_line":"    step_index \u003d 0 if steps else None"},{"line_number":92,"context_line":"    do_next_service_step(task, step_index, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4c09768b_91472633","side":"PARENT","line":90,"updated":"2024-03-27 15:31:17.000000000","message":"Hmm I guess this makes sense to remove.","commit_id":"2f71e5d51262c45d47d045b1bf35cc3a750ce0da"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da785b5e8fb4740049c427c0d2b85abe2a15b6d3","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    steps \u003d node.driver_internal_info.get(\u0027service_steps\u0027, [])"},{"line_number":89,"context_line":"    if not steps:"},{"line_number":90,"context_line":"        _tear_down_node_service(task, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":91,"context_line":"    step_index \u003d 0 if steps else None"},{"line_number":92,"context_line":"    do_next_service_step(task, step_index, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"31ef2d43_abeb4643","side":"PARENT","line":90,"in_reply_to":"4c09768b_91472633","updated":"2024-04-08 13:08:59.000000000","message":"Otherwise, it happens again on line 207 (or we can probably return here).","commit_id":"2f71e5d51262c45d47d045b1bf35cc3a750ce0da"}]}