)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ff9cc47025d47f981468ee70ac47085926219df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cbbde883_69f4331b","updated":"2024-04-04 14:13:25.000000000","message":"Since we\u0027ve already released the API, could you add a release note?","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":28806,"name":"Shukun Song","display_name":"Shukun Song","email":"song.shukun@jp.fujitsu.com","username":"song"},"change_message_id":"404d7c27ef328c5727b74d557c584f9f77611bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b3895b0_127b3883","updated":"2024-04-04 13:05:20.000000000","message":"fujitsu-irmc-recheck","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c38706c0ab1007b8b28567dbab0efad28ecd51ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b112927c_848aca79","updated":"2024-04-04 08:10:53.000000000","message":"recheck unrelated","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbe1893b9efe10c84de3caf224ed923fd1e547fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2946b1b_096a6998","in_reply_to":"cbbde883_69f4331b","updated":"2024-04-04 15:20:41.000000000","message":"yep, forgot about that :P","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d24bcac60483ad9a83581e2580d4f71aacf0b571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"95a4edd1_d7812b81","updated":"2024-04-09 01:33:00.000000000","message":"Same nit as Dmitry, but also in the commit message. These are useful to search","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"46f5ae9ce6b8323b4a0002afe11efecd34367b6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e0422ac9_0817175d","updated":"2024-04-07 14:35:12.000000000","message":"recheck","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"92d1a166ea5b6d52761780463e88b4f66c4b350e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbf0dde5_12bc4474","updated":"2024-04-08 08:29:08.000000000","message":"recheck post failure","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ab3ad0bc2eeacc60b192c2c8cad6829a6a04b73b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"615532c5_2b256cdf","updated":"2024-04-05 12:57:20.000000000","message":"recheck unrelated","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ff9cc47025d47f981468ee70ac47085926219df","unresolved":true,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        \"\"\""},{"line_number":1361,"context_line":"        if device_types is None:"},{"line_number":1362,"context_line":"            redfish_boot.eject_vmedia(task, device_types)"},{"line_number":1363,"context_line":"        else:"},{"line_number":1364,"context_line":"            for device_type in device_types:"},{"line_number":1365,"context_line":"                redfish_boot.eject_vmedia(task, device_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"419ef3ec_88753b0a","line":1362,"updated":"2024-04-04 14:13:25.000000000","message":"nit: I\u0027d pass None for clarity (or omit the argument altogether)","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbe1893b9efe10c84de3caf224ed923fd1e547fd","unresolved":true,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        \"\"\""},{"line_number":1361,"context_line":"        if device_types is None:"},{"line_number":1362,"context_line":"            redfish_boot.eject_vmedia(task, device_types)"},{"line_number":1363,"context_line":"        else:"},{"line_number":1364,"context_line":"            for device_type in device_types:"},{"line_number":1365,"context_line":"                redfish_boot.eject_vmedia(task, device_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"846718b2_bd0b21be","line":1362,"in_reply_to":"419ef3ec_88753b0a","updated":"2024-04-04 15:20:41.000000000","message":"thanks, I was in doubt but definitely being explicit here is way better","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"616aafb8493c88e2570e34abeb3f5e30b699e00a","unresolved":false,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        \"\"\""},{"line_number":1361,"context_line":"        if device_types is None:"},{"line_number":1362,"context_line":"            redfish_boot.eject_vmedia(task, device_types)"},{"line_number":1363,"context_line":"        else:"},{"line_number":1364,"context_line":"            for device_type in device_types:"},{"line_number":1365,"context_line":"                redfish_boot.eject_vmedia(task, device_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a0088bf6_2124e416","line":1362,"in_reply_to":"846718b2_bd0b21be","updated":"2024-04-04 15:25:35.000000000","message":"Done","commit_id":"bed82040794c4e8e956ae50b658b5187f4184416"}],"releasenotes/notes/fix-detach-vmedia-redfish-c86b7d0f72217816.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf9dfa7f3ed3fabfcc99ddd4360fe97cb280e73d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix redifsh ``detach_virtual_media`` method since the precedent"},{"line_number":5,"context_line":"    implementation uses the parameter ``device_type`` while it should be"},{"line_number":6,"context_line":"    ``device_types`` to match the conductor manager implementation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"97428278_2588e652","line":4,"updated":"2024-04-08 13:12:23.000000000","message":"nit: redfish. And better talk about in terms of API resources since the consumers are not aware of method names.","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"076f8e28d61e90a25c5f4991bb38bc87fd072192","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix redifsh ``detach_virtual_media`` method since the precedent"},{"line_number":5,"context_line":"    implementation uses the parameter ``device_type`` while it should be"},{"line_number":6,"context_line":"    ``device_types`` to match the conductor manager implementation."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8eb65098_484909da","line":4,"in_reply_to":"97428278_2588e652","updated":"2024-04-09 13:38:17.000000000","message":"Done","commit_id":"7cb6798fbfd433104e40f623b023ab9d0c4a3a0c"}]}