)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"896ade16e4cb233f2cf7f2e2c9c40a5bb4df0fca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2a95ebc_0ff93072","updated":"2024-04-03 20:58:00.000000000","message":"Linux version 6.6.8-tinycore64 (tc@box) (gcc (GCC) 13.2.0, GNU ld (GNU Binutils) 2.41) #666 SMP Sat Dec 23 16:41:21 UTC 2023\nCommand line: BOOT_IMAGE\u003d/vmlinuz nofb console\u003dttyS0,115200 systemd.journald.forward_to_console\u003dyes ir_pub_id\u003d24a405f5-fd57-4835-a63c-ac589928138d ipa-api-url\u003dhttps://10.209.39.49/baremetal ipa-agent-token\u003djkV-Oh8Ex8GPiWFxbHLKJZ2sFxkzUxFsaxrCMMdtmnM BOOTIF\u003d52:54:00:08:eb:9f ipa-debug\u003d1 boot_method\u003dvmedia --\nBIOS-provided physical RAM map:\n\nIt works!","commit_id":"555ebb2d94fbfacc9834bf0e00386007dda049d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a7cdcd127a74241359c36d55f2ede406e99d5f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec02d4f1_9dc029fb","updated":"2024-04-28 00:17:32.000000000","message":"recheck post failure","commit_id":"767a71842befa8f8b4a10405fa6eaae7017ba94d"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e3e6c7f8a3b59f475ee4ab558919e49b1ed0761c","unresolved":true,"context_lines":[{"line_number":446,"context_line":"    img_handler \u003d ImageHandler(task.node.driver)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    publisher_id \u003d uuidutils.generate_uuid()"},{"line_number":449,"context_line":"    task.node.set_driver_internal_info(\u0027iso_publisher_id\u0027, publisher_id)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    with tempfile.TemporaryDirectory(dir\u003dCONF.tempdir) as boot_file_dir:"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"43405787_c20c8323","line":449,"updated":"2024-04-05 10:39:01.000000000","message":"Where is corresponding task.node.save? And do we really need to persist this value? It looks like you only use it inside of this function and never reuse again.","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"49c06f69d9133afeb52b37bff105eeb2d52606e1","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    img_handler \u003d ImageHandler(task.node.driver)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    publisher_id \u003d uuidutils.generate_uuid()"},{"line_number":449,"context_line":"    task.node.set_driver_internal_info(\u0027iso_publisher_id\u0027, publisher_id)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    with tempfile.TemporaryDirectory(dir\u003dCONF.tempdir) as boot_file_dir:"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a577012b_a0b3281e","line":449,"in_reply_to":"00c714f1_03c0993c","updated":"2024-04-05 16:37:02.000000000","message":"Done","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55518c6904f83495c7590240ce39e844522765b0","unresolved":true,"context_lines":[{"line_number":446,"context_line":"    img_handler \u003d ImageHandler(task.node.driver)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    publisher_id \u003d uuidutils.generate_uuid()"},{"line_number":449,"context_line":"    task.node.set_driver_internal_info(\u0027iso_publisher_id\u0027, publisher_id)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    with tempfile.TemporaryDirectory(dir\u003dCONF.tempdir) as boot_file_dir:"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"00c714f1_03c0993c","line":449,"in_reply_to":"43405787_c20c8323","updated":"2024-04-05 13:56:06.000000000","message":"No, we don\u0027t need to persist it, and good catch","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e3e6c7f8a3b59f475ee4ab558919e49b1ed0761c","unresolved":true,"context_lines":[{"line_number":458,"context_line":"            kernel_params \u003d driver_utils.get_kernel_append_params("},{"line_number":459,"context_line":"                task.node, default\u003dimg_handler.kernel_params)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        kernel_params +\u003d \" ir_pub_id\u003d%s\" % publisher_id"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        if params:"},{"line_number":464,"context_line":"            kernel_params \u003d \u0027 \u0027.join("}],"source_content_type":"text/x-python","patch_set":2,"id":"ddacb7e4_47b3fed1","line":461,"updated":"2024-04-05 10:39:01.000000000","message":"This all logic should probably not happen for ramdisk boot where we don\u0027t expect configdrives or IPA. WDYT?","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"49c06f69d9133afeb52b37bff105eeb2d52606e1","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            kernel_params \u003d driver_utils.get_kernel_append_params("},{"line_number":459,"context_line":"                task.node, default\u003dimg_handler.kernel_params)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        kernel_params +\u003d \" ir_pub_id\u003d%s\" % publisher_id"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        if params:"},{"line_number":464,"context_line":"            kernel_params \u003d \u0027 \u0027.join("}],"source_content_type":"text/x-python","patch_set":2,"id":"8b8f7028_6f211929","line":461,"in_reply_to":"d8b12fb0_73c7a599","updated":"2024-04-05 16:37:02.000000000","message":"Done","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55518c6904f83495c7590240ce39e844522765b0","unresolved":true,"context_lines":[{"line_number":458,"context_line":"            kernel_params \u003d driver_utils.get_kernel_append_params("},{"line_number":459,"context_line":"                task.node, default\u003dimg_handler.kernel_params)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        kernel_params +\u003d \" ir_pub_id\u003d%s\" % publisher_id"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        if params:"},{"line_number":464,"context_line":"            kernel_params \u003d \u0027 \u0027.join("}],"source_content_type":"text/x-python","patch_set":2,"id":"d8b12fb0_73c7a599","line":461,"in_reply_to":"ddacb7e4_47b3fed1","updated":"2024-04-05 13:56:06.000000000","message":"Likely, I can just predicate it on is_ramdisk_boot.","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"}],"ironic/tests/unit/common/test_images.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e3e6c7f8a3b59f475ee4ab558919e49b1ed0761c","unresolved":true,"context_lines":[{"line_number":624,"context_line":"        write_to_file_mock.assert_any_call(mountdir_grub_cfg_path, grubcfg)"},{"line_number":625,"context_line":"        execute_mock.assert_called_once_with("},{"line_number":626,"context_line":"            \u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \u0027VMEDIA_BOOT_ISO\u0027, \u0027-l\u0027,"},{"line_number":627,"context_line":"            \u0027-publisher\u0027, \u0027None\u0027, \u0027-e\u0027,"},{"line_number":628,"context_line":"            \u0027boot/grub/efiboot.img\u0027, \u0027-no-emul-boot\u0027, \u0027-o\u0027, \u0027tgt_file\u0027,"},{"line_number":629,"context_line":"            \u0027tmpdir\u0027)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ae7ff7bd_727fcf6f","line":627,"updated":"2024-04-05 10:39:01.000000000","message":"Maybe avoid None by skipping the argument (will also allow you to get rid of str() calls)","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"49c06f69d9133afeb52b37bff105eeb2d52606e1","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        write_to_file_mock.assert_any_call(mountdir_grub_cfg_path, grubcfg)"},{"line_number":625,"context_line":"        execute_mock.assert_called_once_with("},{"line_number":626,"context_line":"            \u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \u0027VMEDIA_BOOT_ISO\u0027, \u0027-l\u0027,"},{"line_number":627,"context_line":"            \u0027-publisher\u0027, \u0027None\u0027, \u0027-e\u0027,"},{"line_number":628,"context_line":"            \u0027boot/grub/efiboot.img\u0027, \u0027-no-emul-boot\u0027, \u0027-o\u0027, \u0027tgt_file\u0027,"},{"line_number":629,"context_line":"            \u0027tmpdir\u0027)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d6023d10_5bfe0b97","line":627,"in_reply_to":"663952b3_4e459d02","updated":"2024-04-05 16:37:02.000000000","message":"Done","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55518c6904f83495c7590240ce39e844522765b0","unresolved":true,"context_lines":[{"line_number":624,"context_line":"        write_to_file_mock.assert_any_call(mountdir_grub_cfg_path, grubcfg)"},{"line_number":625,"context_line":"        execute_mock.assert_called_once_with("},{"line_number":626,"context_line":"            \u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \u0027VMEDIA_BOOT_ISO\u0027, \u0027-l\u0027,"},{"line_number":627,"context_line":"            \u0027-publisher\u0027, \u0027None\u0027, \u0027-e\u0027,"},{"line_number":628,"context_line":"            \u0027boot/grub/efiboot.img\u0027, \u0027-no-emul-boot\u0027, \u0027-o\u0027, \u0027tgt_file\u0027,"},{"line_number":629,"context_line":"            \u0027tmpdir\u0027)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"663952b3_4e459d02","line":627,"in_reply_to":"ae7ff7bd_727fcf6f","updated":"2024-04-05 13:56:06.000000000","message":"I was sort of hoping to avoid that because of how much refactoring that would be, but fair.","commit_id":"0f4c18f99dde0877e94054e45a00a707de8014aa"}]}