)]}'
{"ironic/drivers/modules/agent_base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2daa76d1b05afda398789845b07b6d6711d373a9","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                      states.SERVICEWAIT, states.SERVICEHOLD)"},{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":102,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":103,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":104,"context_line":"                                states.DEPLOYING, states.CLEANHOLD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"61bb4b2c_f0e8bfa0","line":101,"updated":"2024-04-10 08:04:55.000000000","message":"Could you make it a superset of HEARTBEAT_ALLOWED instead of duplicating?","commit_id":"6b4fa1b519e24ba8928ed208dd6b0d7ae6005ff2"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8c51ba1fc273de62ec968e050f7aa20d0d46d9f5","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                      states.SERVICEWAIT, states.SERVICEHOLD)"},{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":102,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":103,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":104,"context_line":"                                states.DEPLOYING, states.CLEANHOLD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7920ef1e_ee653e65","line":101,"in_reply_to":"61bb4b2c_f0e8bfa0","updated":"2024-04-15 08:15:33.000000000","message":"Thank you for your review Dmitry.\nI started looking at details of making this change as suggested and _HEARTBEAT_ALLOWED contains states.CLEANING and states.RESCUING which weren\u0027t in _FASTTRACK_HEARTBEAT_ALLOWED. In this case, do we leave them separate?\n(I will push a new version of the patch fixing the missing comma below in the meantime)","commit_id":"6b4fa1b519e24ba8928ed208dd6b0d7ae6005ff2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3e3181803311ac44a705d0911d2bc81175051062","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                      states.SERVICEWAIT, states.SERVICEHOLD)"},{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":102,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":103,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":104,"context_line":"                                states.DEPLOYING, states.CLEANHOLD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dec39cc8_cd6b7b3d","line":101,"in_reply_to":"7920ef1e_ee653e65","updated":"2024-04-15 11:34:31.000000000","message":"This is another bug, yes. There is no reason for them not to be there.","commit_id":"6b4fa1b519e24ba8928ed208dd6b0d7ae6005ff2"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"c4c6460bb014f06c693b1ab8e4fe46dc0b59ef77","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                      states.SERVICEWAIT, states.SERVICEHOLD)"},{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":102,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":103,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":104,"context_line":"                                states.DEPLOYING, states.CLEANHOLD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"70c4b576_27d3cfc0","line":101,"in_reply_to":"dec39cc8_cd6b7b3d","updated":"2024-04-16 07:46:12.000000000","message":"Thank you Dmitry. Done.","commit_id":"6b4fa1b519e24ba8928ed208dd6b0d7ae6005ff2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"16170a2ea9152ccc91169c50ec80d770983bc0b7","unresolved":true,"context_lines":[{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (_HEARTBEAT_ALLOWED, states.MANAGEABLE,"},{"line_number":102,"context_line":"                                states.AVAILABLE, states.ENROLL)"},{"line_number":103,"context_line":"FASTTRACK_HEARTBEAT_ALLOWED \u003d frozenset(_FASTTRACK_HEARTBEAT_ALLOWED)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"31578383_4604107b","line":102,"updated":"2024-04-16 11:55:08.000000000","message":"It\u0027s pretty concerning that this change passed unit tests: you end up with nested tuples. You\u0027re looking for something like:\n\n _FASTTRACK_HEARTBEAT_ALLOWED \u003d _HEARTBEAT_ALLOWED + (...)\n \nCould you check why unit tests allowed the change?","commit_id":"2e2710ced6f1ab31cad94386b52a876edfa90a64"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf8c4da364061d3820f66d095355c3ced8683f0f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"HEARTBEAT_ALLOWED \u003d frozenset(_HEARTBEAT_ALLOWED)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (_HEARTBEAT_ALLOWED, states.MANAGEABLE,"},{"line_number":102,"context_line":"                                states.AVAILABLE, states.ENROLL)"},{"line_number":103,"context_line":"FASTTRACK_HEARTBEAT_ALLOWED \u003d frozenset(_FASTTRACK_HEARTBEAT_ALLOWED)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"db5a08ad_d2142ea3","line":102,"in_reply_to":"31578383_4604107b","updated":"2024-04-17 04:05:11.000000000","message":"Oops! Thank you for picking this up!\n\nPushed a new change, will look at the unit tests next.","commit_id":"2e2710ced6f1ab31cad94386b52a876edfa90a64"}],"releasenotes/notes/add-servicing-to-heartbeat-fasttrack-85863df34ece6401.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bfaf91467fa4a42757bf09bca47f48cbde13353e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes the issue of service steps not starting due to servicing states"},{"line_number":5,"context_line":"    (states.SERVICING and states.SERVICEWAIT) missing from"},{"line_number":6,"context_line":"    _FASTTRACK_HEARTBEAT_ALLOWED constant."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d2c66f87_971da463","line":6,"updated":"2024-04-17 09:23:26.000000000","message":"For the future: release notes are targeted at operators, they should not mention internal constants and function names.","commit_id":"619e1ac80ccc6f20e32a2a80d31637dd45d6d45b"}]}