)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f5541161051565a26521a28b5d16d03826d5db13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"oslo-incubator will introduce new integrity check in [1]."},{"line_number":10,"context_line":"That will help developer find inconsistent issue while copying"},{"line_number":11,"context_line":"from oslo-incubator. The check just outputs warnings. These are"},{"line_number":12,"context_line":"changes according to warning:"},{"line_number":13,"context_line":" * remove unused module sslutils"},{"line_number":14,"context_line":" * add missing module versionutils in openstack-common.conf"},{"line_number":15,"context_line":" * fix wrong module name with config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad9bd40_1b3a01e7","line":12,"updated":"2014-05-06 08:58:30.000000000","message":"I don\u0027t think this paragraph is related to the change and I would prefer to not having it here... It\u0027s also not merged in oslo yet which makes even less sense to add to this commit message.\n\nIMO, just keeping the bullet points below would be enough since they describe the actual changes that this patch is doing","commit_id":"06455fdaa6526d0ed13f7dce177e8903a1c5c238"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"cafaa33bafa21b2c28a2e9c21b122387a47ad242","unresolved":false,"context_lines":[{"line_number":9,"context_line":"oslo-incubator will introduce new integrity check in [1]."},{"line_number":10,"context_line":"That will help developer find inconsistent issue while copying"},{"line_number":11,"context_line":"from oslo-incubator. The check just outputs warnings. These are"},{"line_number":12,"context_line":"changes according to warning:"},{"line_number":13,"context_line":" * remove unused module sslutils"},{"line_number":14,"context_line":" * add missing module versionutils in openstack-common.conf"},{"line_number":15,"context_line":" * fix wrong module name with config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad9bd40_e0cd92b8","line":12,"in_reply_to":"9ad9bd40_1b3a01e7","updated":"2014-05-07 02:06:17.000000000","message":"agree, will update in next patchset ,when oslo-incubator patch is merged.","commit_id":"06455fdaa6526d0ed13f7dce177e8903a1c5c238"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a66fc1f40bc06c27dfd63445a36ee86946b7ec3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"oslo-incubator will introduce new integrity check in [1]."},{"line_number":10,"context_line":"That will help developer find inconsistent issue while copying"},{"line_number":11,"context_line":"from oslo-incubator. The check just outputs warnings. These are"},{"line_number":12,"context_line":"changes according to warning:"},{"line_number":13,"context_line":" * remove unused module sslutils"},{"line_number":14,"context_line":" * add missing module versionutils in openstack-common.conf"},{"line_number":15,"context_line":" * fix wrong module name with config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad9bd40_97bde6b9","line":12,"in_reply_to":"9ad9bd40_e0cd92b8","updated":"2014-05-07 09:04:24.000000000","message":"Right... Another thing, if you\u0027re going to reference a commit in another project I think it\u0027s important to use the git SHA1 instead of the gerrit link, the gerrit link might go away but the SHA1 won\u0027t, so I would suggest you to do like:\n\n\"As of commit 1abc2def3 to oslo-incubator introduced a new integrity check...\"","commit_id":"06455fdaa6526d0ed13f7dce177e8903a1c5c238"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7335b1994996df9fb1d6bb3cabd365cc8a8ff0fe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up openstack-common.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of commit I68c0108304be8a315bcefe to oslo-incubator introduced a new"},{"line_number":10,"context_line":"integrity check. This patch fixes the warnings of oslo-incubator commit"},{"line_number":11,"context_line":"but doesn\u0027t depend oslo-incubator commit."},{"line_number":12,"context_line":" * remove unused module sslutils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_17379900","line":9,"updated":"2014-05-09 09:36:06.000000000","message":"Not merged yet","commit_id":"d65e010b689a7eb1bbd9dfbc57c5d1b136ea0f90"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"1a26841347508aa1908dada0905d13a9910e7906","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of commit I68c0108304be8a315bcefe to oslo-incubator introduced a new"},{"line_number":10,"context_line":"integrity check. This patch fixes the warnings of oslo-incubator commit"},{"line_number":11,"context_line":"but doesn\u0027t depend oslo-incubator commit."},{"line_number":12,"context_line":" * remove unused module sslutils"},{"line_number":13,"context_line":" * add missing module versionutils in openstack-common.conf"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_5a15c8ef","line":11,"updated":"2014-05-09 10:09:03.000000000","message":"this  patch to fix the issues detected by that. it doesn\u0027t depend that commit. the oslo commit just add check in update.py , so I think it\u0027s ready for ironic.\nthanks, any thoughts.\nshould I adjust the commit message :) ?","commit_id":"d65e010b689a7eb1bbd9dfbc57c5d1b136ea0f90"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1c9837f4f8647e42f15d3c54ae650511a1a22181","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of commit I68c0108304be8a315bcefe to oslo-incubator introduced a new"},{"line_number":10,"context_line":"integrity check. This patch fixes the warnings of oslo-incubator commit"},{"line_number":11,"context_line":"but doesn\u0027t depend oslo-incubator commit."},{"line_number":12,"context_line":" * remove unused module sslutils"},{"line_number":13,"context_line":" * add missing module versionutils in openstack-common.conf"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_5ab6a8da","line":11,"in_reply_to":"7adec928_5a15c8ef","updated":"2014-05-09 10:21:02.000000000","message":"Hi ChangBo, yes I think you should change the commit message to contains only the changes that this patch is doing (the bullet points down there) without referencing a commit which is not merged yet.\n\nI\u0027m thinking about the case where ur patch to oslo-incubator never gets merged and then we would still have a reference to a commit that doesn\u0027t exist in the Ironic git log, that\u0027s misleading.","commit_id":"d65e010b689a7eb1bbd9dfbc57c5d1b136ea0f90"}]}