)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e7ad95bbd2f1c8099ec58a5babb0e91ff1692b5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"edacdf1f_bc5a8b96","updated":"2024-07-08 05:24:40.000000000","message":"Thank you for your review Iury. Uploading a revised version.","commit_id":"0a775aa39ee82aad7122f221b0213bbd7626db40"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6ade5303c5d419e46f45c63d6a9db09dd8a41c69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e39a68ae_dbf91b16","updated":"2024-07-16 13:12:09.000000000","message":"Thank you for your reviews Dmitry and Iury, pushing updated version","commit_id":"52d4e5ec9741c83df2986da02af6cb43d33f7794"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1edc357dbaa729bd0ba69a3a938d2222da7cc01b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"72798cf2_68525f07","updated":"2024-07-19 14:14:43.000000000","message":"Assuming that you have tested this both one single-system and multi-system redfishes :)","commit_id":"3a403475987a4afd7c0a684b9701619a97a4c6bf"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24511a28c9d7ceef80bdc0cdb7a3028582db0980","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            to be executed."},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":197,"context_line":"        systems_collection \u003d redfish_utils.get_system_collection(task.node)"},{"line_number":198,"context_line":"        listed_systems \u003d systems_collection.get_members()"},{"line_number":199,"context_line":"        count \u003d len(listed_systems)"},{"line_number":200,"context_line":"        # NOTE(janders) if we see more than one System on the BMC, assume that"}],"source_content_type":"text/x-python","patch_set":1,"id":"faf7fd72_ff7aede4","line":197,"range":{"start_line":197,"start_character":7,"end_line":197,"end_character":75},"updated":"2024-06-21 03:49:11.000000000","message":"since node is already (task.node) you wouldn\u0027t need the task here","commit_id":"d169889bd324be908387d60ac81fa80c917024b2"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e7ad95bbd2f1c8099ec58a5babb0e91ff1692b5a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            to be executed."},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":197,"context_line":"        systems_collection \u003d redfish_utils.get_system_collection(task.node)"},{"line_number":198,"context_line":"        listed_systems \u003d systems_collection.get_members()"},{"line_number":199,"context_line":"        count \u003d len(listed_systems)"},{"line_number":200,"context_line":"        # NOTE(janders) if we see more than one System on the BMC, assume that"}],"source_content_type":"text/x-python","patch_set":1,"id":"595a27cf_3d6a864e","line":197,"range":{"start_line":197,"start_character":7,"end_line":197,"end_character":75},"in_reply_to":"faf7fd72_ff7aede4","updated":"2024-07-08 05:24:40.000000000","message":"Done","commit_id":"d169889bd324be908387d60ac81fa80c917024b2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"24511a28c9d7ceef80bdc0cdb7a3028582db0980","unresolved":true,"context_lines":[{"line_number":205,"context_line":"            targets \u003d [target]"},{"line_number":206,"context_line":"        # janders debug"},{"line_number":207,"context_line":"            targets \u003d ["},{"line_number":208,"context_line":"                \"/redfish/v1/Systems/ea72b191-ef72-4504-9aac-90e936c9dfd9\"]"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            targets \u003d None"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"712d3d30_0dcfe243","line":208,"updated":"2024-06-21 03:49:11.000000000","message":"The tricky thing here is how to figure out the uuid mapping to the name of the virtual baremetal Manager.\n\nWith the information from redfish_system_id, you can access the manager of that node \n#### Some python code\n\u003e\u003e\u003e m2 \u003d sushy_vm.get_manager(\u0027/redfish/v1/Systems/testvm2\u0027)\n\u003e\u003e\u003e m2.identity\n\u0027a30c1a96-0c75-498d-b929-f6da8decb736\u0027\n\u003e\u003e\u003e m2.uuid\n\u0027a30c1a96-0c75-498d-b929-f6da8decb736\u0027\n\u003e\u003e\u003e m2.name\n\u0027testvm2\u0027\n\nSince you are able to find the uuid/identity and name you can just replace name for identity in redfish_system_id and set as a target","commit_id":"d169889bd324be908387d60ac81fa80c917024b2"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"481ef9ca3c28b201c041f417f1f12bf6c15a3dbd","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            targets \u003d [target]"},{"line_number":206,"context_line":"        # janders debug"},{"line_number":207,"context_line":"            targets \u003d ["},{"line_number":208,"context_line":"                \"/redfish/v1/Systems/ea72b191-ef72-4504-9aac-90e936c9dfd9\"]"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            targets \u003d None"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f8fa5e4_c5394163","line":208,"in_reply_to":"712d3d30_0dcfe243","updated":"2024-06-25 06:44:54.000000000","message":"Thank you for your review and pointers, Iury. pushing updated version, let\u0027s discuss further.","commit_id":"d169889bd324be908387d60ac81fa80c917024b2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fbc6a0acb589610bc63588026b36ac9f77ae4df6","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            system \u003d redfish_utils.get_system(node)"},{"line_number":211,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":212,"context_line":"            identity \u003d manager.identity"},{"line_number":213,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":214,"context_line":"            targets \u003d [target]"},{"line_number":215,"context_line":"        else:"},{"line_number":216,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"f6fcebbb_9a88798d","line":213,"updated":"2024-07-08 20:52:59.000000000","message":"Maybe we should relay on redfish_system_id in driver_info of the Node? we wouldn\u0027t need the calls to get_system and get_manager.","commit_id":"5dce8eee3c99cd7b4a99de798cda6df37a9cea74"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"23fcc4dd78a06cda9414fc9ff57c305ef85ac29d","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            system \u003d redfish_utils.get_system(node)"},{"line_number":211,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":212,"context_line":"            identity \u003d manager.identity"},{"line_number":213,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":214,"context_line":"            targets \u003d [target]"},{"line_number":215,"context_line":"        else:"},{"line_number":216,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"31f49d4e_c9be6625","line":213,"in_reply_to":"f6fcebbb_9a88798d","updated":"2024-07-08 23:08:17.000000000","message":"Due to how sushy-tools handle things we can\u0027t use the redfish_system_id","commit_id":"5dce8eee3c99cd7b4a99de798cda6df37a9cea74"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9244c4a055fb9b545b8c7c0744264dd06848e43a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            systems_collection \u003d redfish_utils.get_system_collection(node)"},{"line_number":198,"context_line":"        except exception.RedfishError as e:"},{"line_number":199,"context_line":"            LOG.error(\u0027The Redfish Systems Collection was not found\u0027"},{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a9fd7ac_ec745f82","line":199,"updated":"2024-07-09 12:45:16.000000000","message":"\"was not found\" is exactly the thing that cannot happen because we\u0027ve already loaded the system a few times by this point. If it happens, it\u0027s something else.","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d7b15314938726f147a587c0d6c57d1c05e588d","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            systems_collection \u003d redfish_utils.get_system_collection(node)"},{"line_number":198,"context_line":"        except exception.RedfishError as e:"},{"line_number":199,"context_line":"            LOG.error(\u0027The Redfish Systems Collection was not found\u0027"},{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"e079f5d9_b3453fc7","line":199,"in_reply_to":"1808741e_a0b09e1a","updated":"2024-07-09 20:58:42.000000000","message":"Noted, will adjust the message in the next revision","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"517a8d739e273b8523a325737568a646c2ab4b25","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            systems_collection \u003d redfish_utils.get_system_collection(node)"},{"line_number":198,"context_line":"        except exception.RedfishError as e:"},{"line_number":199,"context_line":"            LOG.error(\u0027The Redfish Systems Collection was not found\u0027"},{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1808741e_a0b09e1a","line":199,"in_reply_to":"9a9fd7ac_ec745f82","updated":"2024-07-09 12:57:14.000000000","message":"Right, this makes sense. ++","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd28c4452d0e5d6fe73f5b901a7ca6d05479f46a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            systems_collection \u003d redfish_utils.get_system_collection(node)"},{"line_number":198,"context_line":"        except exception.RedfishError as e:"},{"line_number":199,"context_line":"            LOG.error(\u0027The Redfish Systems Collection was not found\u0027"},{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"38a7defe_64e1b764","line":199,"in_reply_to":"e079f5d9_b3453fc7","updated":"2024-07-10 00:37:45.000000000","message":"Done","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9244c4a055fb9b545b8c7c0744264dd06848e43a","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":203,"context_line":"        listed_systems \u003d systems_collection.get_members()"},{"line_number":204,"context_line":"        count \u003d len(listed_systems)"},{"line_number":205,"context_line":"        # NOTE(janders) if we see more than one System on the BMC, assume that"},{"line_number":206,"context_line":"        # we need to explicitly specify Target parameter when calling"}],"source_content_type":"text/x-python","patch_set":7,"id":"bc76d1dc_5548beae","line":203,"updated":"2024-07-09 12:45:16.000000000","message":"Use members_identities instead of the more expensive get_members()","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d7b15314938726f147a587c0d6c57d1c05e588d","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":203,"context_line":"        listed_systems \u003d systems_collection.get_members()"},{"line_number":204,"context_line":"        count \u003d len(listed_systems)"},{"line_number":205,"context_line":"        # NOTE(janders) if we see more than one System on the BMC, assume that"},{"line_number":206,"context_line":"        # we need to explicitly specify Target parameter when calling"}],"source_content_type":"text/x-python","patch_set":7,"id":"e926d32a_0b9b35fd","line":203,"in_reply_to":"bc76d1dc_5548beae","updated":"2024-07-09 20:58:42.000000000","message":"Noted, will try this way.","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"bd28c4452d0e5d6fe73f5b901a7ca6d05479f46a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                      \u0027 for node %(node)s. Error %(error)s\u0027,"},{"line_number":201,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":202,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":203,"context_line":"        listed_systems \u003d systems_collection.get_members()"},{"line_number":204,"context_line":"        count \u003d len(listed_systems)"},{"line_number":205,"context_line":"        # NOTE(janders) if we see more than one System on the BMC, assume that"},{"line_number":206,"context_line":"        # we need to explicitly specify Target parameter when calling"}],"source_content_type":"text/x-python","patch_set":7,"id":"c064c193_ef683da4","line":203,"in_reply_to":"e926d32a_0b9b35fd","updated":"2024-07-10 00:37:45.000000000","message":"Done","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9244c4a055fb9b545b8c7c0744264dd06848e43a","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            # NOTE(janders) the below three lines are to avoid a problem with"},{"line_number":212,"context_line":"            # sushy-tools setup where the driver_info redfish_system_id looks"},{"line_number":213,"context_line":"            # like this: /redfish/v1/Systems/testvm1 but in fact is just"},{"line_number":214,"context_line":"            # a redirect link (which Ironic isn\u0027t able/happy to follow)"},{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"c9c67844_4c067f88","line":214,"updated":"2024-07-09 12:45:16.000000000","message":"I\u0027m quite sure Ironic did follow them in my testing (it\u0027s just python-requests).","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4571cbcc0715b2839fa248de177188c296a01b71","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            # NOTE(janders) the below three lines are to avoid a problem with"},{"line_number":212,"context_line":"            # sushy-tools setup where the driver_info redfish_system_id looks"},{"line_number":213,"context_line":"            # like this: /redfish/v1/Systems/testvm1 but in fact is just"},{"line_number":214,"context_line":"            # a redirect link (which Ironic isn\u0027t able/happy to follow)"},{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"c63ef43c_6c42142a","line":214,"in_reply_to":"57608f26_fd097495","updated":"2024-07-10 01:12:36.000000000","message":"ok, this makes things a bit complicated, I have no idea on how we can handle this, seems like a sushy-tools problem, but I\u0027m not sure how complicated it can be (and if is worth...)","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d7b15314938726f147a587c0d6c57d1c05e588d","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            # NOTE(janders) the below three lines are to avoid a problem with"},{"line_number":212,"context_line":"            # sushy-tools setup where the driver_info redfish_system_id looks"},{"line_number":213,"context_line":"            # like this: /redfish/v1/Systems/testvm1 but in fact is just"},{"line_number":214,"context_line":"            # a redirect link (which Ironic isn\u0027t able/happy to follow)"},{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"57608f26_fd097495","line":214,"in_reply_to":"7a2ec244_cf2a2e4a","updated":"2024-07-09 20:58:42.000000000","message":"This is the error I was getting that was the reason behind the workaround:\n\n| last_error             | Node 4e41df61-84b1-5856-bfb6-6b5f2cd3dd11 failed step {\u0027interface\u0027: \u0027firmware\u0027, \u0027step\u0027: \u0027update\u0027, \u0027args\u0027: {\u0027settings\u0027: [{\u0027component\u0027: \u0027bmc\u0027, \u0027url\u0027: \u0027http://10.6.48.48:8080/ilo5278.bin\u0027}]}, \u0027abortable\u0027: False,  |\n|                        | \u0027priority\u0027: 0}: Unable to connect to http://localhost:9132/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate. Error: Exceeded 30 redirects.      \n\nI\u0027d appreciate suggestions on how to use \n\ntarget \u003d node.driver_info.get(\u0027redfish_system_id\u0027)\n\nwhile not running into the above error.","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6ade5303c5d419e46f45c63d6a9db09dd8a41c69","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            # NOTE(janders) the below three lines are to avoid a problem with"},{"line_number":212,"context_line":"            # sushy-tools setup where the driver_info redfish_system_id looks"},{"line_number":213,"context_line":"            # like this: /redfish/v1/Systems/testvm1 but in fact is just"},{"line_number":214,"context_line":"            # a redirect link (which Ironic isn\u0027t able/happy to follow)"},{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"c2624088_6887c6d5","line":214,"in_reply_to":"c63ef43c_6c42142a","updated":"2024-07-16 13:12:09.000000000","message":"OK I will try to solve this in sushy-tools, will roll back to using node.driver_info.get(\u0027redfish_system_id\u0027)","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"517a8d739e273b8523a325737568a646c2ab4b25","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            # NOTE(janders) the below three lines are to avoid a problem with"},{"line_number":212,"context_line":"            # sushy-tools setup where the driver_info redfish_system_id looks"},{"line_number":213,"context_line":"            # like this: /redfish/v1/Systems/testvm1 but in fact is just"},{"line_number":214,"context_line":"            # a redirect link (which Ironic isn\u0027t able/happy to follow)"},{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2ec244_cf2a2e4a","line":214,"in_reply_to":"c9c67844_4c067f88","updated":"2024-07-09 12:57:14.000000000","message":"I think when Jacob was testing it didn\u0027t work the redirect..","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9244c4a055fb9b545b8c7c0744264dd06848e43a","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"},{"line_number":218,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":219,"context_line":"            targets \u003d [target]"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"2230c185_31878dd1","line":218,"updated":"2024-07-09 12:45:16.000000000","message":"We shouldn\u0027t assume any URL form with Redfish, you need to use the system\u0027s identity.\n\nAlso, a target is a system for the bios payload but most likely a manager for bmc? Needs checking with DMTF, I\u0027m afraid.","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"517a8d739e273b8523a325737568a646c2ab4b25","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"},{"line_number":218,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":219,"context_line":"            targets \u003d [target]"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"9792e2a3_4acb85db","line":218,"in_reply_to":"2230c185_31878dd1","updated":"2024-07-09 12:57:14.000000000","message":"You are correct, since sushy-tools is only supporting the bios we can either update this later or have some verification here about the component using the fw_upd","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4571cbcc0715b2839fa248de177188c296a01b71","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"},{"line_number":218,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":219,"context_line":"            targets \u003d [target]"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"88c72bcb_c8a19f1d","line":218,"in_reply_to":"2427e21e_7069b339","updated":"2024-07-10 01:12:36.000000000","message":"++, let\u0027s see what we can do with the redirect before jumping in this path","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6ade5303c5d419e46f45c63d6a9db09dd8a41c69","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"},{"line_number":218,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":219,"context_line":"            targets \u003d [target]"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"a74ea6d4_81d6032b","line":218,"in_reply_to":"88c72bcb_c8a19f1d","updated":"2024-07-16 13:12:09.000000000","message":"Done","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"4d7b15314938726f147a587c0d6c57d1c05e588d","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            # this way we craft a /redfish/v1/Systems/\u003cUUID\u003e system_id"},{"line_number":216,"context_line":"            manager \u003d redfish_utils.get_manager(node, system)"},{"line_number":217,"context_line":"            identity \u003d manager.identity"},{"line_number":218,"context_line":"            target \u003d \"/redfish/v1/Systems/\" + identity"},{"line_number":219,"context_line":"            targets \u003d [target]"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            targets \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"2427e21e_7069b339","line":218,"in_reply_to":"9792e2a3_4acb85db","updated":"2024-07-09 20:58:42.000000000","message":"Noted, once we sort out the redirect issue we\u0027ll revisit.","commit_id":"2caaf1c439e0354cab1cf21672c9ea07fdc85238"}]}