)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf992fc86fdb2f8362d973a95ec56f556747174a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ed51ba8e_485708fe","updated":"2024-06-27 23:47:39.000000000","message":"Thank you for your review Dmitry, good pickups, addressed all your comments, uploading revised version.","commit_id":"caef95f9ebb13d0cba40dde1e967ff76fbe79a25"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a83e3bfe748408ff688303e02cfe6ed53b0b002","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            if task.node.clean_step:"},{"line_number":259,"context_line":"                manager_utils.notify_conductor_resume_clean(task)"},{"line_number":260,"context_line":"            elif task.node.service_step:"},{"line_number":261,"context_line":"                manager_utils.notify_conductor_resume_service(task)"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            settings.pop(0)"},{"line_number":264,"context_line":"            self._execute_firmware_update(node,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c30fd030_4ea233b7","line":261,"updated":"2024-06-27 12:46:09.000000000","message":"We probably need to handle deploy too","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf992fc86fdb2f8362d973a95ec56f556747174a","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            if task.node.clean_step:"},{"line_number":259,"context_line":"                manager_utils.notify_conductor_resume_clean(task)"},{"line_number":260,"context_line":"            elif task.node.service_step:"},{"line_number":261,"context_line":"                manager_utils.notify_conductor_resume_service(task)"},{"line_number":262,"context_line":"        else:"},{"line_number":263,"context_line":"            settings.pop(0)"},{"line_number":264,"context_line":"            self._execute_firmware_update(node,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1db5dc9f_8355a8cc","line":261,"in_reply_to":"c30fd030_4ea233b7","updated":"2024-06-27 23:47:39.000000000","message":"Done","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a83e3bfe748408ff688303e02cfe6ed53b0b002","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        purpose\u003d\u0027checking if async update of firmware component failed\u0027,"},{"line_number":288,"context_line":"        spacing\u003dCONF.redfish.firmware_update_fail_interval,"},{"line_number":289,"context_line":"        filters\u003d{\u0027reserved\u0027: False, \u0027provision_state_in\u0027: [states.CLEANFAIL,"},{"line_number":290,"context_line":"                 states.SERVICEFAIL], \u0027maintenance\u0027: True},"},{"line_number":291,"context_line":"        predicate_extra_fields\u003d[\u0027driver_internal_info\u0027],"},{"line_number":292,"context_line":"        predicate\u003dlambda n: n.driver_internal_info.get(\u0027redfish_fw_updates\u0027),"},{"line_number":293,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"f4a887f6_a7c6b4b7","line":290,"updated":"2024-06-27 12:46:09.000000000","message":"And here and below","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf992fc86fdb2f8362d973a95ec56f556747174a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        purpose\u003d\u0027checking if async update of firmware component failed\u0027,"},{"line_number":288,"context_line":"        spacing\u003dCONF.redfish.firmware_update_fail_interval,"},{"line_number":289,"context_line":"        filters\u003d{\u0027reserved\u0027: False, \u0027provision_state_in\u0027: [states.CLEANFAIL,"},{"line_number":290,"context_line":"                 states.SERVICEFAIL], \u0027maintenance\u0027: True},"},{"line_number":291,"context_line":"        predicate_extra_fields\u003d[\u0027driver_internal_info\u0027],"},{"line_number":292,"context_line":"        predicate\u003dlambda n: n.driver_internal_info.get(\u0027redfish_fw_updates\u0027),"},{"line_number":293,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"36a8bc37_5e22f4fa","line":290,"in_reply_to":"f4a887f6_a7c6b4b7","updated":"2024-06-27 23:47:39.000000000","message":"Done","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"}],"ironic/tests/unit/drivers/modules/redfish/test_firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a83e3bfe748408ff688303e02cfe6ed53b0b002","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        mock_task_monitor.is_processing \u003d False"},{"line_number":626,"context_line":"        mock_task_monitor.get_task.return_value \u003d mock_sushy_task"},{"line_number":627,"context_line":"        tm_mock.return_value \u003d mock_task_monitor"},{"line_number":628,"context_line":"        self._generate_new_driver_internal_info([\u0027bmc\u0027])"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        task, interface \u003d self._test__check_node_redfish_firmware_update()"},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd072f_4a3e95e2","line":628,"updated":"2024-06-27 12:46:09.000000000","message":"DId you mean to use the _service variant of this helper?","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf992fc86fdb2f8362d973a95ec56f556747174a","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        mock_task_monitor.is_processing \u003d False"},{"line_number":626,"context_line":"        mock_task_monitor.get_task.return_value \u003d mock_sushy_task"},{"line_number":627,"context_line":"        tm_mock.return_value \u003d mock_task_monitor"},{"line_number":628,"context_line":"        self._generate_new_driver_internal_info([\u0027bmc\u0027])"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        task, interface \u003d self._test__check_node_redfish_firmware_update()"},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d690acd4_1750c3df","line":628,"in_reply_to":"3acd072f_4a3e95e2","updated":"2024-06-27 23:47:39.000000000","message":"Done","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1a83e3bfe748408ff688303e02cfe6ed53b0b002","unresolved":true,"context_lines":[{"line_number":777,"context_line":"                       autospec\u003dTrue)"},{"line_number":778,"context_line":"    def test_continue_updates_last_service(self, cond_resume_service_mock,"},{"line_number":779,"context_line":"                                           log_mock):"},{"line_number":780,"context_line":"        self._generate_new_driver_internal_info([\u0027bmc\u0027])"},{"line_number":781,"context_line":"        task \u003d self._test_continue_updates()"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        cond_resume_service_mock.assert_called_once_with(task)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ead4fc67_f041a4ff","line":780,"updated":"2024-06-27 12:46:09.000000000","message":"same question","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"cf992fc86fdb2f8362d973a95ec56f556747174a","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                       autospec\u003dTrue)"},{"line_number":778,"context_line":"    def test_continue_updates_last_service(self, cond_resume_service_mock,"},{"line_number":779,"context_line":"                                           log_mock):"},{"line_number":780,"context_line":"        self._generate_new_driver_internal_info([\u0027bmc\u0027])"},{"line_number":781,"context_line":"        task \u003d self._test_continue_updates()"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        cond_resume_service_mock.assert_called_once_with(task)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b863c9f7_c9e14787","line":780,"in_reply_to":"ead4fc67_f041a4ff","updated":"2024-06-27 23:47:39.000000000","message":"Done","commit_id":"c50f7795b346417f6bf018599c1ca19ef9f541a7"}]}