)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a1331993ea8b1e9c18c370915bd684963b77f96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6442e8e9_be2d5582","updated":"2024-07-03 22:11:24.000000000","message":"I have concerns over adding a specific hardware type just for one override, especially since we can\u0027t backport hardware types. I\u0027ve left a question leading to a comment on the power.py file change. Ultimately if we can get some further context, it will help us understand if this is the right path, or wrong path to take. Thanks!","commit_id":"59cd25a21eb138b044af225cc6ae582f3bf807d6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"26cc516078005753842c074de2f5aabfd4067dc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"33614c1c_db54be23","updated":"2024-07-03 13:35:39.000000000","message":"hi Peter, this looks really interesting, thanks\nas a new driver it would probably require some discussion with the community first and at least an RFE if not a spec, feel free to propose it during one of our weekly meetings on Monday","commit_id":"59cd25a21eb138b044af225cc6ae582f3bf807d6"}],"ironic/drivers/modules/bluefield_redfish/power.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a1331993ea8b1e9c18c370915bd684963b77f96","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        :raises: RedfishError on an error from the Sushy library"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        try:"},{"line_number":38,"context_line":"            system \u003d redfish_utils.get_system(task.node)"},{"line_number":39,"context_line":"            system.reset_system(sushy.RESET_FORCE_RESTART)"},{"line_number":40,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":41,"context_line":"            error_msg \u003d (_(\u0027Reboot failed for node %(node)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"36dd5025_4f27af05","line":38,"updated":"2024-07-03 22:11:24.000000000","message":"Does the redfish endpoint have vendor information? If so, I would almost prefer that instead of having a different hardware type, we just teach the redfish hardware type how to navigate this specific case. We do attempt to extract the value and store it, and have some similar examples I can point you to if you\u0027d like.\n\nThat being said, I guess some understanding of why this is needed, and ultimately if there are any other cases would help us understand if an entire hardware type is really needed, or if we can just enhance the existing driver.\n\nA plus for a fix inside of the existing driver is we can easily backport that change, where a hardware type we cannot backport.","commit_id":"59cd25a21eb138b044af225cc6ae582f3bf807d6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8ff24a791ed0d72510f2880eff8ffd13445321dd","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        :raises: RedfishError on an error from the Sushy library"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        try:"},{"line_number":38,"context_line":"            system \u003d redfish_utils.get_system(task.node)"},{"line_number":39,"context_line":"            system.reset_system(sushy.RESET_FORCE_RESTART)"},{"line_number":40,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":41,"context_line":"            error_msg \u003d (_(\u0027Reboot failed for node %(node)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5efcfa0_f8690a8a","line":38,"in_reply_to":"36dd5025_4f27af05","updated":"2024-08-16 21:26:28.000000000","message":"Honestly, even just adding this as a power interface on the existing redfish driver might be an easier middle ground. Then operators can opt-in if they know their hardware supports it. This is how we handle the intel IPMI management stuff IIRC","commit_id":"59cd25a21eb138b044af225cc6ae582f3bf807d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aeafef4de9adf8bcac805132dc81b29470d59f66","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        :raises: RedfishError on an error from the Sushy library"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        try:"},{"line_number":38,"context_line":"            system \u003d redfish_utils.get_system(task.node)"},{"line_number":39,"context_line":"            system.reset_system(sushy.RESET_FORCE_RESTART)"},{"line_number":40,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":41,"context_line":"            error_msg \u003d (_(\u0027Reboot failed for node %(node)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"24f3fa6a_e8e9c3f0","line":38,"in_reply_to":"e5efcfa0_f8690a8a","updated":"2024-08-19 18:27:27.000000000","message":"Intel ipmi has it\u0027s own class, its own singular management interface which has it\u0027s own deploy step... Truthfully we should deprecate that interface since Speedstep never got really adopted outside of IPMI since Intel chose not to push redfish support forward with the DMTF.","commit_id":"59cd25a21eb138b044af225cc6ae582f3bf807d6"}]}