)]}'
{"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dba557a4f761a2b436f6c0cde6e09d2e8371fb03","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            inventory[\u0027interfaces\u0027] \u003d []"},{"line_number":137,"context_line":"            mac_addresses \u003d list(system.ethernet_interfaces.summary.keys())"},{"line_number":138,"context_line":"            for mac_address in mac_addresses:"},{"line_number":139,"context_line":"                if not mac_address:"},{"line_number":140,"context_line":"                    LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":141,"context_line":"                                \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":142,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d160551_df2c1701","line":139,"updated":"2024-07-25 14:57:04.000000000","message":"Hmm, it should be impossible for summary to contain empty MAC\u0027s. Are you observing an empty string here instead of None? I think it should be fixed in https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/system/ethernet_interface.py#L72 (change \"is not None\" to just \"if eth.mac_address\")","commit_id":"ed680187336fa0adf8755a66175271baf39e6360"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"bd30aa5f373db8c15c8eaa8ac46c239991ebfc2c","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            inventory[\u0027interfaces\u0027] \u003d []"},{"line_number":137,"context_line":"            mac_addresses \u003d list(system.ethernet_interfaces.summary.keys())"},{"line_number":138,"context_line":"            for mac_address in mac_addresses:"},{"line_number":139,"context_line":"                if not mac_address:"},{"line_number":140,"context_line":"                    LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":141,"context_line":"                                \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":142,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f9646dc_3f67ebd7","line":139,"in_reply_to":"07ae6e8e_78f0704f","updated":"2024-07-25 15:18:38.000000000","message":"In fact the code base has that same check already that I used. https://opendev.org/openstack/ironic/src/commit/acf1c7d43ef437450f86190672758b9ec8cbb8b9/ironic/drivers/modules/redfish/utils.py#L490","commit_id":"ed680187336fa0adf8755a66175271baf39e6360"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d5ef98ca92d91efd8f4284391e9cb75c747b72f0","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            inventory[\u0027interfaces\u0027] \u003d []"},{"line_number":137,"context_line":"            mac_addresses \u003d list(system.ethernet_interfaces.summary.keys())"},{"line_number":138,"context_line":"            for mac_address in mac_addresses:"},{"line_number":139,"context_line":"                if not mac_address:"},{"line_number":140,"context_line":"                    LOG.warning(\"Ignoring device for %(node)s as no MAC \""},{"line_number":141,"context_line":"                                \"reported\", {\u0027node\u0027: task.node.uuid})"},{"line_number":142,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"07ae6e8e_78f0704f","line":139,"in_reply_to":"6d160551_df2c1701","updated":"2024-07-25 15:16:18.000000000","message":"Yes. I see that today.\n\n    \"interfaces\": [\n      {\n        \"mac_address\": \"C4:CB:E1:BF:8F:95\"\n      },\n      {\n        \"mac_address\": \"C4:CB:E1:BF:8F:94\"\n      },\n      {\n        \"mac_address\": \"\"\n      }\n      \nFrom a Dell R7615 running iDRAC 7.00.60.00","commit_id":"ed680187336fa0adf8755a66175271baf39e6360"}]}