)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8b647e491379aa15e5065f8d62e6ccc35f5e7c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44cfb0bf_976faf75","updated":"2024-08-07 22:43:12.000000000","message":"Three things:\n\n1) Please add Related-bug: #xxxxx with the existing runbook rfe attached to the commit message\n\n2) Fix the build:\n\napi-ref build is failing with:\nNo field definition for ``runbook_name`` found in ``/home/zuul/src/opendev.org/openstack/ironic/api-ref/source/parameters.yaml``. Skipping.\n\nPlease fix this and retest. You can run this locally with `tox -eapi-ref` and view the results (to validate it looks as you expect) by pointing your web browser to ironic/api-ref/build/html/index.html\n\n3) Add updates for node API changes:\n\nYou\u0027re missing updates to node set provision state; you need to update here: https://opendev.org/openstack/ironic/src/branch/master/api-ref/source/baremetal-api-v1-node-management.inc#L455 with the information about the new api version, and add the runbook identifier as a new payload item in the request.","commit_id":"2b37201170523d732452e8e260437a333e5f0783"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"98c548c4a690cdeee322a07acaa24d1e11d20250","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"712f0368_fa1fdf97","updated":"2024-08-08 20:54:25.000000000","message":"This is still missing an update to the node provision state documentation indicating that as of this microversion, you can also pass a runbook_ident into set provision state in lieu of a service_steps/clean_steps dictionary.","commit_id":"593ccab93bef1a8c5439ca01e9455dcf0f94db49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"731cd03888ac474cc9c60048a5f73b339a253666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80212862_4cc32862","updated":"2024-08-12 22:53:29.000000000","message":"Would leave it optional to do the revision I suggest, but at a minimum you have to make the backticks match.","commit_id":"f113befdb082b238e42f4e466d0e7c82f4cdf99c"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"98c548c4a690cdeee322a07acaa24d1e11d20250","unresolved":true,"context_lines":[{"line_number":2039,"context_line":"  type: string"},{"line_number":2040,"context_line":"runbook_name:"},{"line_number":2041,"context_line":"  description: |"},{"line_number":2042,"context_line":"    The unique name of the runbook."},{"line_number":2043,"context_line":"  in: body"},{"line_number":2044,"context_line":"  required: true"},{"line_number":2045,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"43558d2f_55a4555a","line":2042,"updated":"2024-08-08 20:54:25.000000000","message":"This should identify that it must match that CUSTOM_ format.","commit_id":"593ccab93bef1a8c5439ca01e9455dcf0f94db49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"731cd03888ac474cc9c60048a5f73b339a253666","unresolved":false,"context_lines":[{"line_number":2039,"context_line":"  type: string"},{"line_number":2040,"context_line":"runbook_name:"},{"line_number":2041,"context_line":"  description: |"},{"line_number":2042,"context_line":"    The unique name of the runbook."},{"line_number":2043,"context_line":"  in: body"},{"line_number":2044,"context_line":"  required: true"},{"line_number":2045,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d00abebd_afe398e4","line":2042,"in_reply_to":"43558d2f_55a4555a","updated":"2024-08-12 22:53:29.000000000","message":"Done","commit_id":"593ccab93bef1a8c5439ca01e9455dcf0f94db49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"98c548c4a690cdeee322a07acaa24d1e11d20250","unresolved":true,"context_lines":[{"line_number":2051,"context_line":"  type: string"},{"line_number":2052,"context_line":"runbook_public:"},{"line_number":2053,"context_line":"  description: |"},{"line_number":2054,"context_line":"    Indicates whether a runbook is available for public use or not."},{"line_number":2055,"context_line":"  in: body"},{"line_number":2056,"context_line":"  required: false"},{"line_number":2057,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4a1d1d5f_dc72d485","line":2054,"updated":"2024-08-08 20:54:25.000000000","message":"We should indicate here, and in owner, the relationship between these two fields. (e.g. maybe under runbook_public, in the description, add \"This must be false if owner is not null.\" and under runbook_public, add \"This must be null if public is true.\"","commit_id":"593ccab93bef1a8c5439ca01e9455dcf0f94db49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"731cd03888ac474cc9c60048a5f73b339a253666","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"  type: string"},{"line_number":2052,"context_line":"runbook_public:"},{"line_number":2053,"context_line":"  description: |"},{"line_number":2054,"context_line":"    Indicates whether a runbook is available for public use or not."},{"line_number":2055,"context_line":"  in: body"},{"line_number":2056,"context_line":"  required: false"},{"line_number":2057,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"249ef9dd_4ce03bbd","line":2054,"in_reply_to":"4a1d1d5f_dc72d485","updated":"2024-08-12 22:53:29.000000000","message":"Done","commit_id":"593ccab93bef1a8c5439ca01e9455dcf0f94db49"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"731cd03888ac474cc9c60048a5f73b339a253666","unresolved":true,"context_lines":[{"line_number":2043,"context_line":"    which makes it conform to the TRAITS_SCHEMA format. This is the same"},{"line_number":2044,"context_line":"    schema format that every node\u0027s trait name follows. The runbook name"},{"line_number":2045,"context_line":"    needs to match one of these node trait names when being associated"},{"line_number":2046,"context_line":"    with a node."},{"line_number":2047,"context_line":"  in: body"},{"line_number":2048,"context_line":"  required: true"},{"line_number":2049,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4eafa40c_33fb1ca1","line":2046,"updated":"2024-08-12 22:53:29.000000000","message":"This is a pretty good description, I think it can be clarified:\n\nThe unique name of the runbook. It must be prefixed with ```CUSTOM_```, which makes it conform to the TRAITS_SCHEMA format. The runbook name must match a node trait indicating it can run on a node.\n\nAlso note when revising this, you are missing a backtick before CUSTOM_ (2 on the left, 3 on the right)","commit_id":"f113befdb082b238e42f4e466d0e7c82f4cdf99c"}]}