)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e2932d02413eeea8dd08ef966f8797ef25e584fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9bf762c9_b084906a","updated":"2024-08-16 20:57:27.000000000","message":"I like this change in theory, but I think the implementation is off by a hair.","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"32c8b0dc02fbe104758ca4f5c551fad553bf25e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36ed354d_eceae404","updated":"2024-08-26 17:39:59.000000000","message":"Hoping to get your feedback on this Dmitry and Jay. I think this would be a good inclusion for Dalmatian given the release notes around the change for the iDRAC driver.","commit_id":"9f1752a4ee794334397dd7e577bd62ef6540529e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"62c0ff9da125d7d56cbce0c18554dba4c5aa6224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2266fe3b_a48833d3","updated":"2024-08-26 18:28:15.000000000","message":"This needs an extremely meaty release note stating:\n- DracRedfishPower is deprecated (and whatever changes should be done in drivers.modules.drac.power to support this)\n- RedfishPower is identical to DracRedfishPower\n- An enumeration of previously-unavailable interfaces that now are available for DRAC hardware types.","commit_id":"9f1752a4ee794334397dd7e577bd62ef6540529e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c400183cc6ed442584283cb9f0c471a2135f7946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"598afe48_7ed09569","updated":"2024-08-27 22:29:30.000000000","message":"Just one small query","commit_id":"5c00d0c27f51f88f46b466a2947b6db71865e33e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66d42d7c2bbe004132bd42731c70951f63eb7294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a56da2a7_234428b2","updated":"2024-08-28 18:26:03.000000000","message":"@jay@jvf.cc and @dtantsur@protonmail.com this should now function identically to the redfish driver but replace out specific DRAC implementations with their own. No change to any order.","commit_id":"52fdbb743d5d84ab3309822ae758c1f76a26f186"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1df2242af70826f9ca965ed18e33d8ce5638f4cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3c1694b6_37a0c862","updated":"2024-08-29 03:44:51.000000000","message":"Thanks!","commit_id":"52fdbb743d5d84ab3309822ae758c1f76a26f186"}],"ironic/drivers/drac.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e2932d02413eeea8dd08ef966f8797ef25e584fb","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"},{"line_number":57,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":58,"context_line":"        return (super().supported_power_interfaces"},{"line_number":59,"context_line":"                + [power.DracRedfishPower])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Optional hardware interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"2c3991f4_92e7d4ab","line":58,"updated":"2024-08-16 20:57:27.000000000","message":"I\u0027m going to be honest, I\u0027m not 100% sure, but I think the ordering here matters -- like the earlier ones in the list are default. So I think you may want to prepend power.DracRedfishPower instead of appending it. (throughout)","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7ae74102d07ee147717d70b54bd4fb66b8a84b64","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"},{"line_number":57,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":58,"context_line":"        return (super().supported_power_interfaces"},{"line_number":59,"context_line":"                + [power.DracRedfishPower])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Optional hardware interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"f9f27f2f_e34982d6","line":58,"in_reply_to":"2c3991f4_92e7d4ab","updated":"2024-08-26 14:15:13.000000000","message":"Agreed. With some of the others I wanted to make the non iDRAC version first since the iDRAC version is now just a pass through. But not this one.","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"62c0ff9da125d7d56cbce0c18554dba4c5aa6224","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"},{"line_number":57,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":58,"context_line":"        return (super().supported_power_interfaces"},{"line_number":59,"context_line":"                + [power.DracRedfishPower])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Optional hardware interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"e16eef9e_dc9d7c6b","line":58,"in_reply_to":"637070cc_e1b5175d","updated":"2024-08-26 18:28:15.000000000","message":"It seems to be like we should also deprecate power.DracRedfishPower if it\u0027s not already deprecated, too.","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"9118a7865ff3f7224d2374e7a62008d772379a51","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"},{"line_number":57,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":58,"context_line":"        return (super().supported_power_interfaces"},{"line_number":59,"context_line":"                + [power.DracRedfishPower])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Optional hardware interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"77b9ac6f_3a460d9b","line":58,"in_reply_to":"e16eef9e_dc9d7c6b","updated":"2024-08-26 19:42:09.000000000","message":"Done","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"5dae4c673ff7b02e59d084c0c47b53f31ea84d1a","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @property"},{"line_number":56,"context_line":"    def supported_power_interfaces(self):"},{"line_number":57,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":58,"context_line":"        return (super().supported_power_interfaces"},{"line_number":59,"context_line":"                + [power.DracRedfishPower])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Optional hardware interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"637070cc_e1b5175d","line":58,"in_reply_to":"f9f27f2f_e34982d6","updated":"2024-08-26 14:41:02.000000000","message":"Actually this is one of the ones that we want to append. Because it\u0027s a no-op pass through for \"redfish\". By making it use \"redfish\" first, we\u0027ll be silently steering new users to not use an interface that can go away.","commit_id":"03910965225d69c360f85b9f0fbbac78b517b6a4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c400183cc6ed442584283cb9f0c471a2135f7946","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        # remove the generic redfish one in favor of the Dell specific"},{"line_number":46,"context_line":"        inherited.remove(redfish_boot.RedfishVirtualMediaBoot)"},{"line_number":47,"context_line":"        inherited.append(boot.DracRedfishVirtualMediaBoot)"},{"line_number":48,"context_line":"        return inherited"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @property"},{"line_number":51,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"2ca31a81_778f01ce","line":48,"updated":"2024-08-27 22:29:30.000000000","message":"Should the preference of VirtualMediaBoot over HttpsBoot be preserved here by doing a replace instead of an append?","commit_id":"5c00d0c27f51f88f46b466a2947b6db71865e33e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"9bf7e6e91ac9762f27c363a87336a61df2d274fb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        # remove the generic redfish one in favor of the Dell specific"},{"line_number":46,"context_line":"        inherited.remove(redfish_boot.RedfishVirtualMediaBoot)"},{"line_number":47,"context_line":"        inherited.append(boot.DracRedfishVirtualMediaBoot)"},{"line_number":48,"context_line":"        return inherited"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @property"},{"line_number":51,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"6cd96b2b_3be032fc","line":48,"in_reply_to":"2ca31a81_778f01ce","updated":"2024-08-28 13:52:52.000000000","message":"Replaced the operations with in place replacements in patch set 10.","commit_id":"5c00d0c27f51f88f46b466a2947b6db71865e33e"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66d42d7c2bbe004132bd42731c70951f63eb7294","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # remove the generic redfish one in favor of the Dell specific"},{"line_number":46,"context_line":"        inherited.remove(redfish_boot.RedfishVirtualMediaBoot)"},{"line_number":47,"context_line":"        inherited.append(boot.DracRedfishVirtualMediaBoot)"},{"line_number":48,"context_line":"        return inherited"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @property"},{"line_number":51,"context_line":"    def supported_management_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"f9636b88_0f593c28","line":48,"in_reply_to":"6cd96b2b_3be032fc","updated":"2024-08-28 18:26:03.000000000","message":"Done","commit_id":"5c00d0c27f51f88f46b466a2947b6db71865e33e"}]}