)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a4a66ef46d4c9b52f3ff8b09360968756234b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aad00583_2dbd1fc0","updated":"2024-09-03 14:25:47.000000000","message":"A few minor comments inline. More importantly, please add unit tests and a release note.","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9c5e13409756804f6dc0c2d217678f381cca89dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5d808b9_0322eb05","in_reply_to":"aad00583_2dbd1fc0","updated":"2024-09-03 14:29:43.000000000","message":"will do","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6548b1641f25ccc9ca596473893b9c1c84ee10d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"952ff310_6b35babe","updated":"2024-09-10 14:41:07.000000000","message":"LGTM, Thanks!","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"cfd451feb329e8f49cb4da37ea8e4be844a32e18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfffb1e6_0da33922","updated":"2024-09-11 07:43:23.000000000","message":"recheck","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"9986f05c7bbf42935b112ce3ebf4e41ef82ed4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"95b52fe8_d5fd1920","updated":"2024-09-11 11:58:01.000000000","message":"recheck (Failure seems unrelated)","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"54539f815621eef8a5ceb70d193de52a8841c5be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f1c0c52_e8e22952","updated":"2024-09-04 16:04:03.000000000","message":"recheck tempest error, should be fixed now","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"c06a60c69265456ffa3087461f1a22d2132f7214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a55bc9b_79b514bb","updated":"2024-09-12 13:59:33.000000000","message":"recheck unrelated error setting up neutron router","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"},{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"481620be3efacc3fb3c93984d977dee9dd7b11b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"14322c90_604d5da5","in_reply_to":"95b52fe8_d5fd1920","updated":"2024-09-11 12:00:47.000000000","message":"I just realized that Derek had already rechecked and the it was in progress, apologies","commit_id":"b07ebc4123d08f81e67dc52e7c0cce0292711317"}],"ironic/conductor/cleaning.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a4a66ef46d4c9b52f3ff8b09360968756234b6e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                     \u0027%s\u0027, node.uuid)"},{"line_number":97,"context_line":"            prepare_result \u003d None"},{"line_number":98,"context_line":"    except Exception as e:"},{"line_number":99,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":100,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":101,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":102,"context_line":"            target_state \u003d states.MANAGEABLE if manual_clean else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1273605_2b7ee10b","line":99,"updated":"2024-09-03 14:25:47.000000000","message":"A more Pythonic way would be to have a separate \"except\" statement before \"except Exception\"","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9c5e13409756804f6dc0c2d217678f381cca89dd","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                     \u0027%s\u0027, node.uuid)"},{"line_number":97,"context_line":"            prepare_result \u003d None"},{"line_number":98,"context_line":"    except Exception as e:"},{"line_number":99,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":100,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":101,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":102,"context_line":"            target_state \u003d states.MANAGEABLE if manual_clean else None"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8a26ed6_5a3efa2e","line":99,"in_reply_to":"c1273605_2b7ee10b","updated":"2024-09-03 14:29:43.000000000","message":"Agreed, I was following the precedent already set in this file but I can change it","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a4a66ef46d4c9b52f3ff8b09360968756234b6e","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    except Exception as e:"},{"line_number":99,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":100,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":101,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":102,"context_line":"            target_state \u003d states.MANAGEABLE if manual_clean else None"},{"line_number":103,"context_line":"            task.process_event(\u0027wait\u0027, target_state\u003dtarget_state)"},{"line_number":104,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d8de7a8_436fca13","line":101,"updated":"2024-09-03 14:25:47.000000000","message":"Maybe mention fast track for more context?","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9c5e13409756804f6dc0c2d217678f381cca89dd","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    except Exception as e:"},{"line_number":99,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":100,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":101,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":102,"context_line":"            target_state \u003d states.MANAGEABLE if manual_clean else None"},{"line_number":103,"context_line":"            task.process_event(\u0027wait\u0027, target_state\u003dtarget_state)"},{"line_number":104,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"eddcd6c9_a67d618b","line":101,"in_reply_to":"3d8de7a8_436fca13","updated":"2024-09-03 14:29:43.000000000","message":"will do","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"}],"ironic/conductor/deployments.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a4a66ef46d4c9b52f3ff8b09360968756234b6e","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    try:"},{"line_number":189,"context_line":"        task.driver.deploy.prepare(task)"},{"line_number":190,"context_line":"    except exception.IronicException as e:"},{"line_number":191,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":192,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":193,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":194,"context_line":"            node.set_driver_internal_info(async_steps.SKIP_CURRENT_DEPLOY_STEP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"566be4de_05aa8740","line":191,"updated":"2024-09-03 14:25:47.000000000","message":"same","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9c5e13409756804f6dc0c2d217678f381cca89dd","unresolved":true,"context_lines":[{"line_number":188,"context_line":"    try:"},{"line_number":189,"context_line":"        task.driver.deploy.prepare(task)"},{"line_number":190,"context_line":"    except exception.IronicException as e:"},{"line_number":191,"context_line":"        if isinstance(e, exception.AgentConnectionFailed):"},{"line_number":192,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":193,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":194,"context_line":"            node.set_driver_internal_info(async_steps.SKIP_CURRENT_DEPLOY_STEP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"33903672_0d236df8","line":191,"in_reply_to":"566be4de_05aa8740","updated":"2024-09-03 14:29:43.000000000","message":"as above","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a4a66ef46d4c9b52f3ff8b09360968756234b6e","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":193,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":194,"context_line":"            node.set_driver_internal_info(async_steps.SKIP_CURRENT_DEPLOY_STEP,"},{"line_number":195,"context_line":"                                          False)"},{"line_number":196,"context_line":"            task.process_event(\u0027wait\u0027)"},{"line_number":197,"context_line":"            return"},{"line_number":198,"context_line":"        with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"16a9085e_b4611d84","line":195,"updated":"2024-09-03 14:25:47.000000000","message":"I don\u0027t think there are any \"current deploy steps\" yet? We only set it on line 285.","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"9c5e13409756804f6dc0c2d217678f381cca89dd","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            LOG.info(\u0027Agent is not yet running on node %(node)s, \u0027"},{"line_number":193,"context_line":"                     \u0027waiting for agent to come up\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":194,"context_line":"            node.set_driver_internal_info(async_steps.SKIP_CURRENT_DEPLOY_STEP,"},{"line_number":195,"context_line":"                                          False)"},{"line_number":196,"context_line":"            task.process_event(\u0027wait\u0027)"},{"line_number":197,"context_line":"            return"},{"line_number":198,"context_line":"        with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"91f03bb4_85e994f1","line":195,"in_reply_to":"16a9085e_b4611d84","updated":"2024-09-03 14:29:43.000000000","message":"Acknowledged","commit_id":"54b4f0446af7dc4c22f4d69fcfd348d53ceb6736"}]}