)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f1634ac0cdaf2bacca2d8b45b402e3dc6ba6ec7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cdf53595_b189ad2e","updated":"2024-11-22 20:26:39.000000000","message":"Lets add a release note to this, indicating we\u0027re now validating input schemas more explicitly?","commit_id":"bc6dd5a7bb6d8d1b7f23f028f0ccad400014828e"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"182b20c51aa2010924d209abc1d20f8880fa6cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"278f9d3b_14b62576","updated":"2025-01-24 23:30:02.000000000","message":"recheck - its been a little bit, see if CI is stable.","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"0b3c90f68e23deb1d1ecd1ff5c997fea1e482f7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6bff0b12_93addbd5","updated":"2025-01-30 01:52:11.000000000","message":"recheck - not sure what happened, but it ran twice one after another","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a480fd919497950aed3a79a2bc7fd1e2ebfffb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f29c38f4_7d654ecf","updated":"2025-01-27 14:50:36.000000000","message":"recheck ci didn\u0027t seem to recheck this when last requested... twice","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0b6f1409eac443d6788d60dfeb5c23f2981887f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"39847761_738668d3","updated":"2025-01-20 22:10:15.000000000","message":"recheck metal3 failure seeing if reproducable","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0c2e914bd26bf80d7eda1686bbfb4ec974dc6102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf632caa_b839296d","updated":"2025-01-21 17:13:41.000000000","message":"recheck metal3 job fixed","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"191cb4bd1729d267509affb33151b390f894b837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b8d0626_c74c4a2e","updated":"2025-01-21 22:07:39.000000000","message":"recheck metal3-integration appears to be good again","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"182b20c51aa2010924d209abc1d20f8880fa6cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8168bdb_f24a0d1d","in_reply_to":"39847761_738668d3","updated":"2025-01-24 23:30:02.000000000","message":"Done","commit_id":"93ad67a445b98971fc2a3ee18bf0b17f35947595"}],"ironic/api/controllers/v1/shard.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f1634ac0cdaf2bacca2d8b45b402e3dc6ba6ec7f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from ironic.api.controllers.v1 import utils as api_utils"},{"line_number":19,"context_line":"from ironic.api.controllers.v1 import versions"},{"line_number":20,"context_line":"from ironic.api import method"},{"line_number":21,"context_line":"from ironic.api.schemas.v1 import shard as schema"},{"line_number":22,"context_line":"from ironic.api import validation"},{"line_number":23,"context_line":"from ironic.common.i18n import _"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e8972cee_80662269","line":21,"updated":"2024-11-22 20:26:39.000000000","message":"Maybe a style thing, but I\u0027d probably prefer shard_schema or shard here, but won\u0027t -1 for this kinda opinion/naming thing.","commit_id":"bc6dd5a7bb6d8d1b7f23f028f0ccad400014828e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"124a7cbd3c541bdc43f2939ae0cc84a21196d7a8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ironic.api.controllers.v1 import utils as api_utils"},{"line_number":19,"context_line":"from ironic.api.controllers.v1 import versions"},{"line_number":20,"context_line":"from ironic.api import method"},{"line_number":21,"context_line":"from ironic.api.schemas.v1 import shard as schema"},{"line_number":22,"context_line":"from ironic.api import validation"},{"line_number":23,"context_line":"from ironic.common.i18n import _"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"449bdbde_df8d6705","line":21,"in_reply_to":"e57143e2_e649e7c2","updated":"2024-11-25 14:50:53.000000000","message":"Indeed. In addition, the `shard_` prefix is unnecessary visual noise given this file only concerns the shard API and there\u0027s a 1:1 correlation expected between the files containing the controllers and the files containing the schemas for the controllers. Lastly, I\u0027ve found in nova that using import names like e.g. `shard_schema` forces a lot of wrapping in the decorators.","commit_id":"bc6dd5a7bb6d8d1b7f23f028f0ccad400014828e"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"c4f5d1161a00cc960e4b3ef79f4a3c24fed705fe","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from ironic.api.controllers.v1 import utils as api_utils"},{"line_number":19,"context_line":"from ironic.api.controllers.v1 import versions"},{"line_number":20,"context_line":"from ironic.api import method"},{"line_number":21,"context_line":"from ironic.api.schemas.v1 import shard as schema"},{"line_number":22,"context_line":"from ironic.api import validation"},{"line_number":23,"context_line":"from ironic.common.i18n import _"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e57143e2_e649e7c2","line":21,"in_reply_to":"e8972cee_80662269","updated":"2024-11-23 21:17:40.000000000","message":"I imagine this is a pattern from other repos? \nhttps://opendev.org/openstack/nova/src/commit/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/admin_actions.py#L18","commit_id":"bc6dd5a7bb6d8d1b7f23f028f0ccad400014828e"}],"ironic/api/validation/__init__.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"1ed3a9f5cafb4c4588d88f25bd336cabc83cc3f4","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    # be run."},{"line_number":96,"context_line":"    if ("},{"line_number":97,"context_line":"        (min_version and api.request.version.minor \u003c min_version)"},{"line_number":98,"context_line":"        or (max_version and api.request.version.minor \u003e max_version)"},{"line_number":99,"context_line":"    ):"},{"line_number":100,"context_line":"        return"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4c8c7288_bc28947a","line":98,"updated":"2025-01-09 12:18:15.000000000","message":"The second condition should likely be: max_version and api.request.version.major \u003e max_version","commit_id":"6ec2fca37a22c49e06e7496e998e7795e3d8913e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f1f579d075178fb0b0059517c6209df855e0b6b2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # be run."},{"line_number":96,"context_line":"    if ("},{"line_number":97,"context_line":"        (min_version and api.request.version.minor \u003c min_version)"},{"line_number":98,"context_line":"        or (max_version and api.request.version.minor \u003e max_version)"},{"line_number":99,"context_line":"    ):"},{"line_number":100,"context_line":"        return"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e5646f98_acf925b0","line":98,"in_reply_to":"4c8c7288_bc28947a","updated":"2025-01-09 13:56:47.000000000","message":"No, this is correct. `max_version` and `min_version` refer to the maximum and minimum *minor* version, respectively. `api.request.version.major` is always `2` since there we only support the 2.x API version and therefore we don\u0027t bother checking for that.","commit_id":"6ec2fca37a22c49e06e7496e998e7795e3d8913e"}]}