)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"53e590c9333046deec0eb4d355d6ffaccd674b77","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class CustomAgentDeploy(agent_base.AgentBaseMixin,"},{"line_number":211,"context_line":"                        agent_base.HeartbeatMixin,"},{"line_number":212,"context_line":"                        agent_base.AgentOobStepsMixin,"},{"line_number":213,"context_line":"                        base.DeployInterface):"},{"line_number":214,"context_line":"    \"\"\"A deploy interface that relies on a custom agent to deploy."}],"source_content_type":"text/x-python","patch_set":2,"id":"13f0285d_68295b63","line":211,"updated":"2024-09-24 22:18:14.000000000","message":"Just curious, I know it\u0027s not in scope for this change, but I wonder if we could do a similar refactor around HeartbeatMixin","commit_id":"4724eb9d6f7219f068e4b50741c56bea0417de04"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aad217347779c33f5338df111f191e859e0c7de8","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class CustomAgentDeploy(agent_base.AgentBaseMixin,"},{"line_number":211,"context_line":"                        agent_base.HeartbeatMixin,"},{"line_number":212,"context_line":"                        agent_base.AgentOobStepsMixin,"},{"line_number":213,"context_line":"                        base.DeployInterface):"},{"line_number":214,"context_line":"    \"\"\"A deploy interface that relies on a custom agent to deploy."}],"source_content_type":"text/x-python","patch_set":2,"id":"8caf3d57_d066e1d9","line":211,"in_reply_to":"13f0285d_68295b63","updated":"2024-09-25 09:25:36.000000000","message":"I\u0027ve checked all 4 mixins (even draw a diagram in my notebook!), and the 3 remaining are used in different combinations:\n\nAnaconda \u003d Heartbeat + AgentBase\n\nRamdisk \u003d Heartbeat + AgentBase\n\nAnsible \u003d Heartbeat + AgentOobSteps\n\nThe ansible one has a lot of copy-paste from AgentBase, so there may be some space for DRY.. but I\u0027m not ready to dive into it in the near future.","commit_id":"4724eb9d6f7219f068e4b50741c56bea0417de04"}],"releasenotes/notes/agent-deploy-cacaf7f2585992e8.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"53e590c9333046deec0eb4d355d6ffaccd674b77","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Because of the code reorganization, some metrics have been removed: all"},{"line_number":5,"context_line":"    metrics prefixed with ``AgentDeployMixin`` are now prefixed with"},{"line_number":6,"context_line":"    ``CustomAgentDeploy`` or ``AgentDeploy`` instead."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    The ``AgentDeployMixin`` class has been removed from ``agent_base.py``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"426c3944_53e32043","line":6,"updated":"2024-09-24 22:18:14.000000000","message":"Thank you for remembering this!","commit_id":"4724eb9d6f7219f068e4b50741c56bea0417de04"}]}