)]}'
{"id":"openstack%2Fironic~930203","triplet_id":"openstack%2Fironic~master~Ib670571eb511d2f2e724ecfab1d2abb1ab471346","project":"openstack/ironic","branch":"master","topic":"agent-deploy","attention_set":{},"removed_from_attention_set":{"10342":{"account":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"last_update":"2024-09-25 11:03:14.000000000","reason":"Change was submitted"},"10239":{"account":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"last_update":"2024-09-25 11:03:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib670571eb511d2f2e724ecfab1d2abb1ab471346","subject":"Refactoring: get rid of AgentDeployMixin","status":"MERGED","created":"2024-09-23 14:13:48.000000000","updated":"2024-09-25 11:04:27.000000000","submitted":"2024-09-25 11:03:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"930203-agent-deploy","meta_rev_id":"cc4295ce23ad746dbc93ad2ba496a1a04a40982c","_number":930203,"virtual_id_number":930203,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-09-25 11:03:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":2,"date":"2024-09-24 22:18:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-09-25 09:53:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-09-25 09:53:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-23 15:56:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-09-23 16:46:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-24 22:18:14.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2024-09-25 09:53:50.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"d54fbc4c26a2fb45440b9d0967c94f4a8bc08bdc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2024-09-23 14:13:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e07cf4521a12a204369abcdaf73ea118dcd7c81d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2024-09-23 15:24:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3077273e013085b2024ab0cf2f0aa9f71b46d0d3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-23 15:56:30.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/07b6c1bfabc04679a711602150075e1f\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/d331f174d7074f1f870e6340736d44ed : SUCCESS in 20m 42s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/c0a2163a792641a5976054be2137577f : FAILURE in 17m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"088474e949e5717611799165eee72ee356c5a88f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-23 16:46:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cacc64fac70e407482e0c92af28e0884\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/36187d2c21624ee0a850080cca36d41b : SUCCESS in 11m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/72d9e7d13a0c447bba0d7df012fb355a : SUCCESS in 4m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/10d3e345a05942dbb8520cdd8bbd62f8 : SUCCESS in 9m 50s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4600a54a3158429c9a5c22cc766dbae4 : SUCCESS in 8m 15s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/936560e30fc5436ab07e1fc1881f1cfd : SUCCESS in 9m 29s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa353cb886fd4ccf826fab2581a15d68 : SUCCESS in 13m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3be99651ab88495884a104cdae041e40 : SUCCESS in 18m 03s\n- ironic-tox-bandit https://zuul.opendev.org/t/openstack/build/9c0bb8bf0b1c4fda9e5aa74a22d4c26d : SUCCESS in 4m 56s\n- ironic-tox-codespell https://zuul.opendev.org/t/openstack/build/ff786893ccee49c19e0cce9f629e3684 : SUCCESS in 4m 10s\n- ironic-tox-unit-mysql-migrations https://zuul.opendev.org/t/openstack/build/53bb9162de874213a237346b28265f48 : SUCCESS in 3m 30s\n- ironic-tox-unit-with-driver-libs https://zuul.opendev.org/t/openstack/build/61048e7f87f948de8ab9bf5fcce69ea2 : SUCCESS in 6m 51s\n- ironic-cross-sushy https://zuul.opendev.org/t/openstack/build/7af95a5754c445cab8442b02efdd1f61 : SUCCESS in 6m 18s (non-voting)\n- ironic-tempest-functional-python3 https://zuul.opendev.org/t/openstack/build/658307828bfd4d4c9d5de8b49e518dcc : SUCCESS in 28m 35s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/1b333112e6d2481a89c917e5b53efb0b : SUCCESS in 56m 34s\n- ironic-grenade-skip-level https://zuul.opendev.org/t/openstack/build/a08efd4576014574a5cd049dd80ec595 : FAILURE in 25m 07s (non-voting)\n- ironic-standalone-redfish https://zuul.opendev.org/t/openstack/build/c5244ae2c7e04aae9fe9f91f22c876b4 : SUCCESS in 1h 07m 54s (non-voting)\n- ironic-tempest-bios-redfish-pxe https://zuul.opendev.org/t/openstack/build/17c4f313ab2647d1ad9ebdad92cb8da1 : SUCCESS in 29m 32s\n- ironic-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/59a1b30f7fe74210b1e7b613941d3e73 : SUCCESS in 36m 56s\n- ironic-tempest-ramdisk-bios-snmp-pxe https://zuul.opendev.org/t/openstack/build/c95f7ae2798f490daa6bb91b10fd5759 : SUCCESS in 30m 23s\n- ironic-tempest-uefi-redfish-https https://zuul.opendev.org/t/openstack/build/848136cc5c404085a2c117403f5e1c43 : SUCCESS in 39m 27s\n- ironic-tempest-ovn-uefi-ipmi-pxe https://zuul.opendev.org/t/openstack/build/3bb6240b291e4931a2ffda71d9ffd61b : SUCCESS in 37m 05s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/7c56d1f66b664b969c73a0725cee501c : SUCCESS in 1h 21m 21s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-shard https://zuul.opendev.org/t/openstack/build/2add327b565b4d6c9354b810f8fbc951 : SUCCESS in 47m 27s (non-voting)\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/2ebc2c12db5b45c09ff06cbd476a0804 : SUCCESS in 46m 47s\n- ironic-tempest-bfv https://zuul.opendev.org/t/openstack/build/ae069376f85a4cd6acbfa1e1db0481d5 : SUCCESS in 34m 32s\n- ironic-tempest-ipa-partition-uefi-pxe-grub2 https://zuul.opendev.org/t/openstack/build/955f158816a64e82a7dd369c3ef2ed46 : SUCCESS in 33m 59s\n- metalsmith-integration-glance-centos9-legacy https://zuul.opendev.org/t/openstack/build/3e647d3936074255af563a7ce1361c15 : SUCCESS in 1h 05m 44s (non-voting)\n- metal3-integration https://zuul.opendev.org/t/openstack/build/0f30992f633241adb9284b9139f92a24 : SUCCESS in 36m 46s\n- ironic-inspector-tempest https://zuul.opendev.org/t/openstack/build/784ea8c04c5e4b12941a05d033aa0075 : SUCCESS in 46m 28s (non-voting)\n- ironic-inspector-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/c3ead5cea493498d96b2b231d59d4318 : SUCCESS in 49m 11s (non-voting)\n- ironic-standalone-aarch64 https://zuul.opendev.org/t/openstack/build/e233a1a313a64e218feb32aef524155c : SUCCESS in 39m 17s (non-voting)\n- ironic-tempest-ipa-wholedisk-bios-ipmi-direct-dib https://zuul.opendev.org/t/openstack/build/0a0101f3e449418f85a4c260bcfc52e2 : SUCCESS in 44m 27s (non-voting)\n- ironic-tempest-ipxe-ipv6 https://zuul.opendev.org/t/openstack/build/a14e056eaa9043c2a35652014287222d : SUCCESS in 52m 38s (non-voting)\n- ironic-standalone-anaconda https://zuul.opendev.org/t/openstack/build/f6463b0c31cb4e6286f15269a5ba9bae : SUCCESS in 44m 04s (non-voting)\n- bifrost-integration-tinyipa-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/67e508ce36b14bee80739e8aa64db8e6 : SUCCESS in 25m 08s (non-voting)\n- bifrost-integration-redfish-vmedia-uefi-centos-9 https://zuul.opendev.org/t/openstack/build/23541aa6710c4211bd63c8b5e18d0914 : SUCCESS in 46m 45s (non-voting)\n- ironic-tempest-pxe_ipmitool-postgres https://zuul.opendev.org/t/openstack/build/49b005ae54204094ae131ac221da614b : FAILURE in 25m 41s (non-voting)\n- bifrost-benchmark-ironic https://zuul.opendev.org/t/openstack/build/db9c683e2d164573a0090df3fccd1f2b : SUCCESS in 44m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"53e590c9333046deec0eb4d355d6ffaccd674b77","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-09-24 22:18:14.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"aad217347779c33f5338df111f191e859e0c7de8","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2024-09-25 09:25:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7a0938a668f6998fd7cf5ab64de9ac02ef1f94f7","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2024-09-25 09:53:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ac6a5b2f97714a454538bcfda6d93de1f4fda920","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-25 09:54:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1170e69f8bd3314f0be336180d1f9a7541c06af7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-25 11:03:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/03f9c118e94948b9b36c9eb6cc2b39ea\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b7d333fb0f7f4ecab26b6f111579eb20 : SUCCESS in 4m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/75400c68ad9c4063806093e4aae562db : SUCCESS in 8m 30s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/f1bbdaa74c9c4142bf0ae8d4dfe5d06d : SUCCESS in 8m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ffc635fa788c4416a304772546c1c409 : SUCCESS in 15m 49s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e28f55c5416b4a04a15a3950297c90f1 : SUCCESS in 18m 42s\n- ironic-tox-bandit https://zuul.opendev.org/t/openstack/build/2d18809cc66f4e0e88ef6bd1045844ef : SUCCESS in 5m 20s\n- ironic-tox-codespell https://zuul.opendev.org/t/openstack/build/f471d7a6a50345038e20801ebdb2c662 : SUCCESS in 4m 49s\n- ironic-tox-unit-mysql-migrations https://zuul.opendev.org/t/openstack/build/ed73064b04bf4b94a4d73e1ec11a7bd0 : SUCCESS in 7m 18s\n- ironic-tox-unit-with-driver-libs https://zuul.opendev.org/t/openstack/build/f5556b1682b646a0a07f184ffb361c1d : SUCCESS in 8m 52s\n- ironic-tempest-functional-python3 https://zuul.opendev.org/t/openstack/build/1fc480b6f8b5476b8a0df8f8d7740992 : SUCCESS in 20m 47s\n- ironic-grenade https://zuul.opendev.org/t/openstack/build/ab28e8f601dc461b847beb11921888b7 : SUCCESS in 44m 45s\n- ironic-tempest-bios-redfish-pxe https://zuul.opendev.org/t/openstack/build/e46b534b0af14f72b2991fe3457f44a4 : SUCCESS in 37m 04s\n- ironic-tempest-uefi-redfish-vmedia https://zuul.opendev.org/t/openstack/build/fc0c04c876f645a0a011e5b9d7dc5801 : SUCCESS in 37m 03s\n- ironic-tempest-ramdisk-bios-snmp-pxe https://zuul.opendev.org/t/openstack/build/ca7746c2729e47a7bd3b8dc18f467b4b : SUCCESS in 21m 17s\n- ironic-tempest-uefi-redfish-https https://zuul.opendev.org/t/openstack/build/e332622e883b44c1bd5637140b46acfb : SUCCESS in 43m 14s\n- ironic-tempest-ovn-uefi-ipmi-pxe https://zuul.opendev.org/t/openstack/build/80641e6aa35f421abc4d5130ee58065a : SUCCESS in 42m 54s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/397922e65dfb4913b92128fae920c45a : SUCCESS in 49m 14s\n- ironic-tempest-bfv https://zuul.opendev.org/t/openstack/build/6109ef00dc1542bd9ec837931d931fee : SUCCESS in 49m 08s\n- ironic-tempest-ipa-partition-uefi-pxe-grub2 https://zuul.opendev.org/t/openstack/build/e266a4c25fd440a3a4f2f36bbb475de8 : SUCCESS in 43m 16s\n- metal3-integration https://zuul.opendev.org/t/openstack/build/99d86f7df785407696ea4d3d24be1143 : SUCCESS in 38m 19s","accounts_in_message":[],"_revision_number":2},{"id":"1e8d1b5f71c39100db134e831329df5aa9c9375d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-25 11:03:14.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"cc4295ce23ad746dbc93ad2ba496a1a04a40982c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-25 11:04:27.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ca3e26e785a454eb7e6bde16b4ec8a5\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/89123051d9c0422ab73e0a51b9ea6533 : SUCCESS in 53s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ebe51c8b5dd64673ba6ec21c8f8b5a81 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4724eb9d6f7219f068e4b50741c56bea0417de04","revisions":{"58894a5e6c0a0361731f3116768b4d8b8fd154d8":{"kind":"REWORK","_number":1,"created":"2024-09-23 14:13:48.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/03/930203/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/03/930203/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/03/930203/1"}}},"commit":{"parents":[{"commit":"fd2572f463ef406d9468dddf0c18013effcb47fb","subject":"Update master for stable/2024.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/fd2572f463ef406d9468dddf0c18013effcb47fb"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2024-09-23 13:48:21.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2024-09-23 14:12:06.000000000","tz":120},"subject":"[WIP] Refactoring: get rid of AgentDeployMixin","message":"[WIP] Refactoring: get rid of AgentDeployMixin\n\nIts existence is probably a legacy of the iSCSI deploy times. Grouping\nall deploy steps in CustomAgentDeploy (the only descendant of\nAgentDeployMixin) allows more easy code navigation.\n\nChange-Id: Ib670571eb511d2f2e724ecfab1d2abb1ab471346\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/58894a5e6c0a0361731f3116768b4d8b8fd154d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/58894a5e6c0a0361731f3116768b4d8b8fd154d8"}]},"branch":"refs/heads/master"},"4724eb9d6f7219f068e4b50741c56bea0417de04":{"kind":"REWORK","_number":2,"created":"2024-09-23 15:24:10.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/03/930203/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/03/930203/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/03/930203/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/03/930203/2"}}},"commit":{"parents":[{"commit":"fd2572f463ef406d9468dddf0c18013effcb47fb","subject":"Update master for stable/2024.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/fd2572f463ef406d9468dddf0c18013effcb47fb"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2024-09-23 13:48:21.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2024-09-23 15:22:58.000000000","tz":120},"subject":"Refactoring: get rid of AgentDeployMixin","message":"Refactoring: get rid of AgentDeployMixin\n\nIts existence is probably a legacy of the iSCSI deploy times. Currently,\nwe have 4 different base classes/mixins in agent_base, which is\nconfusing even for a long-term contributor like me. AgentDeployMixin is\nonly used in CustomAgentDeploy, so it makes sense to get rid of it to\nsimplify the code navigation.\n\nAll deploy steps are moved to CustomAgentDeploy. Two two helper methods,\nprepare_instance_to_boot and configure_local_boot are only used in\nAgentDeploy, so moving them there.\n\nChange-Id: Ib670571eb511d2f2e724ecfab1d2abb1ab471346\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/4724eb9d6f7219f068e4b50741c56bea0417de04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/4724eb9d6f7219f068e4b50741c56bea0417de04"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}