)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7cc9432f3f1840b21316c1825f6e4c30190059ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a475b60a_0a8ab832","updated":"2024-09-27 00:10:36.000000000","message":"looks like a good start","commit_id":"80caa32fc8e3e046c0a8e5b3ace9f8e4da9655cd"}],"devstack/lib/ironic":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7cc9432f3f1840b21316c1825f6e4c30190059ad","unresolved":true,"context_lines":[{"line_number":395,"context_line":"# DHCP timeout for the dhcp-all-interfaces element."},{"line_number":396,"context_line":"IRONIC_DIB_DHCP_TIMEOUT\u003d${IRONIC_DIB_DHCP_TIMEOUT:-60}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# Options ofr building a DIB image"},{"line_number":399,"context_line":"IRONIC_BUILD_DIB_IMAGE\u003d${IRONIC_BUILD_DIB_IMAGE:-False}"},{"line_number":400,"context_line":"IRONIC_DIB_IMAGE_OPTIONS\u003d${IRONIC_DIB_IMAGE_OPTIONS:-}"},{"line_number":401,"context_line":"if [[ -z \"$IRONIC_DIB_IMAGE_OPTIONS\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"890b48ec_113f6192","line":398,"range":{"start_line":398,"start_character":10,"end_line":398,"end_character":13},"updated":"2024-09-27 00:10:36.000000000","message":"for","commit_id":"80caa32fc8e3e046c0a8e5b3ace9f8e4da9655cd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"17cd6c0d814525784fe6e8c816f6d00f3be3b58a","unresolved":true,"context_lines":[{"line_number":401,"context_line":"IRONIC_DIB_IMAGE_OS\u003d${IRONIC_DIB_IMAGE_OS:-centos}"},{"line_number":402,"context_line":"IRONIC_DIB_IMAGE_RELEASE\u003d${IRONIC_DIB_IMAGE_RELEASE:-9-stream}"},{"line_number":403,"context_line":"if [[ -z \"$IRONIC_DIB_IMAGE_OPTIONS\" ]]; then"},{"line_number":404,"context_line":"    IRONIC_DIB_IMAGE_OPTIONS\u003d\"$IRONIC_DIB_IMAGE_OS bootloader block-device-efi\""},{"line_number":405,"context_line":"fi"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"c91f217b_bb268cd9","line":404,"updated":"2024-10-01 18:32:59.000000000","message":"currently thinking block-device-efi-lvm and the growvols element sa well.\n\nhttps://github.com/openstack/diskimage-builder/tree/master/diskimage_builder/elements/growvols\n\nThat would at least allow us to ensure an end to end workflow and then we can just trigger this job on the dib-builds as well.","commit_id":"f2bb2776e8dac71b401af19c227bc0012cf79495"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"42c88a196fee1aa25508ce6b857123d353df18ce","unresolved":true,"context_lines":[{"line_number":401,"context_line":"IRONIC_DIB_IMAGE_OS\u003d${IRONIC_DIB_IMAGE_OS:-centos}"},{"line_number":402,"context_line":"IRONIC_DIB_IMAGE_RELEASE\u003d${IRONIC_DIB_IMAGE_RELEASE:-9-stream}"},{"line_number":403,"context_line":"if [[ -z \"$IRONIC_DIB_IMAGE_OPTIONS\" ]]; then"},{"line_number":404,"context_line":"    IRONIC_DIB_IMAGE_OPTIONS\u003d\"$IRONIC_DIB_IMAGE_OS bootloader block-device-efi\""},{"line_number":405,"context_line":"fi"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"cb825b5d_6a524f34","line":404,"in_reply_to":"a4063710_05aa78d3","updated":"2024-10-14 18:17:59.000000000","message":"Yes, existing tests do ssh in by default, they really don\u0027t do much inside the VM. It might be worth exploring separately at some point. If you look at the next patch in the series, it to auto-run, since we know if it fails the machine really doesn\u0027t boot and needs to be rescued.","commit_id":"f2bb2776e8dac71b401af19c227bc0012cf79495"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"88eded3b838372adfc6bd953b4ca4ee6608b9d40","unresolved":true,"context_lines":[{"line_number":401,"context_line":"IRONIC_DIB_IMAGE_OS\u003d${IRONIC_DIB_IMAGE_OS:-centos}"},{"line_number":402,"context_line":"IRONIC_DIB_IMAGE_RELEASE\u003d${IRONIC_DIB_IMAGE_RELEASE:-9-stream}"},{"line_number":403,"context_line":"if [[ -z \"$IRONIC_DIB_IMAGE_OPTIONS\" ]]; then"},{"line_number":404,"context_line":"    IRONIC_DIB_IMAGE_OPTIONS\u003d\"$IRONIC_DIB_IMAGE_OS bootloader block-device-efi\""},{"line_number":405,"context_line":"fi"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"a4063710_05aa78d3","line":404,"in_reply_to":"c91f217b_bb268cd9","updated":"2024-10-14 01:10:10.000000000","message":"This raises the question of how growvols gets run and what asserts that it did a thing. Do tests already ssh into the resulting test node?","commit_id":"f2bb2776e8dac71b401af19c227bc0012cf79495"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3426e6eec12f4358b7a63907b34dfab1e13c0f01","unresolved":false,"context_lines":[{"line_number":401,"context_line":"IRONIC_DIB_IMAGE_OS\u003d${IRONIC_DIB_IMAGE_OS:-centos}"},{"line_number":402,"context_line":"IRONIC_DIB_IMAGE_RELEASE\u003d${IRONIC_DIB_IMAGE_RELEASE:-9-stream}"},{"line_number":403,"context_line":"if [[ -z \"$IRONIC_DIB_IMAGE_OPTIONS\" ]]; then"},{"line_number":404,"context_line":"    IRONIC_DIB_IMAGE_OPTIONS\u003d\"$IRONIC_DIB_IMAGE_OS bootloader block-device-efi\""},{"line_number":405,"context_line":"fi"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"446dd1ee_be8d57dc","line":404,"in_reply_to":"cb825b5d_6a524f34","updated":"2024-10-17 14:29:51.000000000","message":"See the next change in the series, where this becomes run.","commit_id":"f2bb2776e8dac71b401af19c227bc0012cf79495"}]}