)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"012af5d8e76e265678306a352b99bc377e2dc36f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26e8529a_8280fb04","updated":"2024-10-14 19:44:59.000000000","message":"If CI passes, I\u0027m happy.","commit_id":"4f84e14417c6b98c11df8e1a6cd83316ecedc542"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"40c4c91d1702545a114e5e901bca83dfbfbda60e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b9e40c83_ed534523","updated":"2024-10-22 16:55:56.000000000","message":"PTG Review Jam\n\n- (Jay) I\u0027m concerned the json schema will no longer enforce that address is a required field to create ports, can we please add that test.","commit_id":"0886b27007aff6a08cb864e49777a817f49afee4"}],"api-ref/source/baremetal-api-v1-ports.inc":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"40c4c91d1702545a114e5e901bca83dfbfbda60e","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - node_ident: req_node_ident"},{"line_number":133,"context_line":"    - address: req_port_address"},{"line_number":134,"context_line":"    - portgroup_uuid: req_portgroup_uuid"},{"line_number":135,"context_line":"    - name: req_port_name"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1c57af9f_7ccc11b4","line":132,"updated":"2024-10-22 16:55:56.000000000","message":"if you use `node_ident` here instead of `req_node_ident` you likely can reuse the existing parameter","commit_id":"0886b27007aff6a08cb864e49777a817f49afee4"}],"doc/source/contributor/webapi-version-history.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b714a1ff66d95e6658ebb88d5a41e0528fd879b4","unresolved":true,"context_lines":[{"line_number":5,"context_line":"1.93 (Epoxy)"},{"line_number":6,"context_line":"-----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Add support to create ports passing in either the node name or UUID."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"1.92 (Dalmatian)"},{"line_number":11,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a05c614_a0537cfa","line":8,"updated":"2024-10-02 18:31:20.000000000","message":"We need updates to api-ref as well, to update the port documentation.","commit_id":"10a0a3ca9cc4453b862107d10c2acfef972ed336"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"d2ceadef2cdcf9c0d4cc90eda032c49c83abefce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"1.93 (Epoxy)"},{"line_number":6,"context_line":"-----------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Add support to create ports passing in either the node name or UUID."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"1.92 (Dalmatian)"},{"line_number":11,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"537fec65_754f1376","line":8,"in_reply_to":"7a05c614_a0537cfa","updated":"2024-10-14 19:42:54.000000000","message":"Acknowledged","commit_id":"10a0a3ca9cc4453b862107d10c2acfef972ed336"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b714a1ff66d95e6658ebb88d5a41e0528fd879b4","unresolved":true,"context_lines":[{"line_number":566,"context_line":"        if (node_uuid"},{"line_number":567,"context_line":"            and not api_utils.allow_node_uuid_as_param_for_port_creation()):"},{"line_number":568,"context_line":"            LOG.warning(\"The \u0027node_uuid\u0027 parameter is deprecated. \""},{"line_number":569,"context_line":"                        \"Use \u0027node_ident\u0027 instead.\")"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        if node_ident:"},{"line_number":572,"context_line":"            if not api_utils.allow_node_ident_as_param_for_port_creation():"}],"source_content_type":"text/x-python","patch_set":2,"id":"43d125bc_54c03576","line":569,"updated":"2024-10-02 18:31:20.000000000","message":"Logging in response to a weird API request is not ideal, because the operator will see this warning but the API caller will not.\n\nWe have two paths forward:\n- Require all requests on the microversion with node_ident *use* node_ident and throw BAD REQUEST when they don\u0027t\n- Permit node_uuid to be used when provided, assuming node_ident is not also set (we should likely consider it a bad request, and I think the schema is written to do this, if both are set). This is the route I think will be the least breaky.","commit_id":"10a0a3ca9cc4453b862107d10c2acfef972ed336"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"d2ceadef2cdcf9c0d4cc90eda032c49c83abefce","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        if (node_uuid"},{"line_number":567,"context_line":"            and not api_utils.allow_node_uuid_as_param_for_port_creation()):"},{"line_number":568,"context_line":"            LOG.warning(\"The \u0027node_uuid\u0027 parameter is deprecated. \""},{"line_number":569,"context_line":"                        \"Use \u0027node_ident\u0027 instead.\")"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        if node_ident:"},{"line_number":572,"context_line":"            if not api_utils.allow_node_ident_as_param_for_port_creation():"}],"source_content_type":"text/x-python","patch_set":2,"id":"acac1db5_a8234097","line":569,"in_reply_to":"43d125bc_54c03576","updated":"2024-10-14 19:42:54.000000000","message":"Acknowledged","commit_id":"10a0a3ca9cc4453b862107d10c2acfef972ed336"}],"ironic/tests/unit/api/controllers/v1/test_port.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"40c4c91d1702545a114e5e901bca83dfbfbda60e","unresolved":true,"context_lines":[{"line_number":2004,"context_line":"        pdict[\u0027node_ident\u0027] \u003d self.node.uuid"},{"line_number":2005,"context_line":"        response \u003d self.post_json(\u0027/ports\u0027, pdict, headers\u003dself.headers,"},{"line_number":2006,"context_line":"                                  expect_errors\u003dTrue)"},{"line_number":2007,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"    def test_create_port_without_node_or_node_uuid(self, mock_create):"},{"line_number":2010,"context_line":"        pdict \u003d post_get_test_port(node_uuid\u003dself.node.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6437c666_221269b8","line":2007,"updated":"2024-10-22 16:55:56.000000000","message":"Can we add a negative test proving that we are still enforcing that address is required?","commit_id":"0886b27007aff6a08cb864e49777a817f49afee4"}]}