)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"af090a6e08d888d3e19949bcb7037765130c6ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee57f4ae_78cbb2dd","updated":"2024-10-14 17:27:32.000000000","message":"At this point, I will be taking a second look at this change.","commit_id":"f9b2385d6da2223db3c2819a04d2e34536669e2f"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"61b9a7831535acdb9673aa80c62b29284862d026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"13b93e33_5cceeba9","updated":"2024-10-09 12:32:13.000000000","message":"Instead of retaining the current shape of the error message in unit tests, as is, an alternative to this approach will be to update the unit tests as well.","commit_id":"f9b2385d6da2223db3c2819a04d2e34536669e2f"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e70e2c59223ddaaba3049f39fe3b692fa750b55f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97fe460c_85f0c850","updated":"2024-10-14 15:35:50.000000000","message":"recheck - one more time: (volume target update cannot be performed on node ** while it is in state \"power on\"","commit_id":"f9b2385d6da2223db3c2819a04d2e34536669e2f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"76918f6ca03ac249ad8e98c679e6d4acb7e8d373","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57d9dc6b_2f381ba8","updated":"2024-10-09 14:43:21.000000000","message":"recheck unsure why the functional tests failed; seems like maybe random/slow VMs?\n\nI wanna see this pass functional tests before voting on it, but code lgtm","commit_id":"f9b2385d6da2223db3c2819a04d2e34536669e2f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8b19705d580bb5fe0e42c542cad63e45557bc837","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d0f0bdf_373e499c","updated":"2024-10-16 20:08:07.000000000","message":"My i-t-p change this depends on needs to land with this.","commit_id":"c6d695c4d137f5b0e73e7d2349b81268bcfd7921"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1086e524525d0dfc156141979f08a7786ea3bdef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"991a7d88_de41f525","updated":"2024-10-21 16:04:02.000000000","message":"oh hell, you\u0027re right 😞","commit_id":"c6d695c4d137f5b0e73e7d2349b81268bcfd7921"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"c84277722212e20b17280ef34a9c1e6251c78066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b82393f_7d480566","updated":"2024-11-19 12:27:07.000000000","message":"If this is in the right shape, I will add unit tests next.","commit_id":"8b3bd9a38d6c2d987156cd2cc4d005b1b1e48b08"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"66ab3f804dd25630322e46f0a94a8acdee990381","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    if request_version:"},{"line_number":274,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if minor and minor \u003c feature_version:"},{"line_number":277,"context_line":"        return True"},{"line_number":278,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"87e6f592_78802144","line":276,"updated":"2024-10-23 19:48:32.000000000","message":"So a couple of things here..\n\n```suggestion\n    return (minor and minor \u003c feature_version)\n```\n\nis all you need without the two return lines. But this will fail when there is no minor when request_version isn\u0027t set with\n\nTypeError: \u0027\u003c\u0027 not supported between instances of \u0027NoneType\u0027 and \u0027int\u0027\n\nor \n\nTypeError: \u0027\u003c\u0027 not supported between instances of \u0027NoneType\u0027 and \u0027str\u0027","commit_id":"84fdd12e59317dd83c9efacd376bce59f1ef02ac"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"345e0e630bb3ae4a5026409a9ef36b3484f7711d","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    if request_version:"},{"line_number":274,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if minor and minor \u003c feature_version:"},{"line_number":277,"context_line":"        return True"},{"line_number":278,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"bdcf8827_61cfa9f9","line":276,"in_reply_to":"55bc6c5e_eff782ba","updated":"2024-10-23 20:03:42.000000000","message":"\u0027cus that\u0027s why I have two return lines","commit_id":"84fdd12e59317dd83c9efacd376bce59f1ef02ac"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"880d225b92cbb8efb95d88901f7cb4503639438d","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    if request_version:"},{"line_number":274,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if minor and minor \u003c feature_version:"},{"line_number":277,"context_line":"        return True"},{"line_number":278,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"55bc6c5e_eff782ba","line":276,"in_reply_to":"87e6f592_78802144","updated":"2024-10-23 19:57:34.000000000","message":"You mean your suggested edit will fail (?) or ...","commit_id":"84fdd12e59317dd83c9efacd376bce59f1ef02ac"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"57d91f951a78a6453d5585c55b3ffa80ebc8f05a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    if request_version:"},{"line_number":274,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if minor and minor \u003c feature_version:"},{"line_number":277,"context_line":"        return True"},{"line_number":278,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8c2cef9_69914241","line":276,"in_reply_to":"bdcf8827_61cfa9f9","updated":"2024-10-23 21:59:51.000000000","message":"bah no. you\u0027re checking if minor is not-falsey. It\u0027s a late day.","commit_id":"84fdd12e59317dd83c9efacd376bce59f1ef02ac"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"65d073e37cd9cd63622cbeb0119abf6c4503e37d","unresolved":true,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    \"\"\""},{"line_number":272,"context_line":"    minor \u003d None"},{"line_number":273,"context_line":"    version_string \u003d \u0027HTTP_%s\u0027 % base.Version.string.replace(\u0027-\u0027, \u0027_\u0027).upper()"},{"line_number":274,"context_line":"    request_version \u003d environ.get(version_string, \u0027\u0027)"},{"line_number":275,"context_line":"    if request_version:"},{"line_number":276,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4802fd84_ab7580d3","line":273,"updated":"2024-11-13 19:30:59.000000000","message":"I think we should be using https://opendev.org/openstack/microversion-parse unless there\u0027s something I don\u0027t understand.","commit_id":"603a78a80cb1463cfad838cb24556a9dff4b23ff"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"86a875bdeedec7a679b312b269c92100225a7e18","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    \"\"\""},{"line_number":272,"context_line":"    minor \u003d None"},{"line_number":273,"context_line":"    version_string \u003d \u0027HTTP_%s\u0027 % base.Version.string.replace(\u0027-\u0027, \u0027_\u0027).upper()"},{"line_number":274,"context_line":"    request_version \u003d environ.get(version_string, \u0027\u0027)"},{"line_number":275,"context_line":"    if request_version:"},{"line_number":276,"context_line":"        _, minor \u003d mvp.parse_version_string(request_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3872df60_3f7dd92f","line":273,"in_reply_to":"4802fd84_ab7580d3","updated":"2024-11-19 12:21:36.000000000","message":"Acknowledged","commit_id":"603a78a80cb1463cfad838cb24556a9dff4b23ff"}],"ironic/api/middleware/parsable_error.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"65d073e37cd9cd63622cbeb0119abf6c4503e37d","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            body \u003d [item.encode(\u0027utf-8\u0027) for item in body]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            if versions.allow_feature_on_microversion("},{"line_number":78,"context_line":"                    environ, versions.MINOR_95_DOUBLE_JSON_ENCODING):"},{"line_number":79,"context_line":"                error_message \u003d \u0027\\n\u0027.join(app_iter)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                # Conditionally wrap in a JSON object if not already JSON"}],"source_content_type":"text/x-python","patch_set":6,"id":"dc9b82d7_d45899e6","line":78,"updated":"2024-11-13 19:30:59.000000000","message":"I would suggest adding a comment above this line, maybe with a link to the bug ticket and a short description of the old broken behavior that we\u0027re preserving.","commit_id":"603a78a80cb1463cfad838cb24556a9dff4b23ff"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"86a875bdeedec7a679b312b269c92100225a7e18","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            body \u003d [item.encode(\u0027utf-8\u0027) for item in body]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            if versions.allow_feature_on_microversion("},{"line_number":78,"context_line":"                    environ, versions.MINOR_95_DOUBLE_JSON_ENCODING):"},{"line_number":79,"context_line":"                error_message \u003d \u0027\\n\u0027.join(app_iter)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                # Conditionally wrap in a JSON object if not already JSON"}],"source_content_type":"text/x-python","patch_set":6,"id":"81f6f1f3_81b2a59d","line":78,"in_reply_to":"dc9b82d7_d45899e6","updated":"2024-11-19 12:21:36.000000000","message":"Acknowledged","commit_id":"603a78a80cb1463cfad838cb24556a9dff4b23ff"}]}